-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rebase LLVM to 8.0.0 final #59285
Rebase LLVM to 8.0.0 final #59285
Conversation
|
Want to update src/rustllvm/llvm-rebuild-trigger while you're at it? Feel free to r=me with that in |
Oops, updated! Was this not an issue on prior LLVM updates since then? @bors r=alexcrichton |
@cuviper: 🔑 Insufficient privileges: Not in reviewers |
@bors delegate+ r=alexcrichton |
📌 Commit 0dabf8c has been approved by |
✌️ @cuviper can now approve this pull request |
What are the plans regarding LLVM updates from this point on? Will we stay on the LLVM 8 branch or go back to master now that the release is out? |
It's never an issue for CI because we always build from scratch and let sccache cache. It's in theory always an issue for local users though because we don't clear out the cached llvm build directory unless this file changes. Now that being said it's probably pretty trivial for us to clear out the build directory somewhat automatically if the llvm git commit changes or something like that. But for now it's what we have!
I think we'll probably stick to the defacto policy we've had for awhile that for small features and updates we can cherry-pick to our own branch but if a major feature is needed we can upgrade the submodule. |
@bors p=1 |
⌛ Testing commit 0dabf8c with merge d615b111ad3f43493f62248ea9adbf1e813a1c54... |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry |
Rebase LLVM to 8.0.0 final r? @alexcrichton
☀️ Test successful - checks-travis, status-appveyor |
replace llvm-rebuild-trigger with submodule commit hash As mentioned in #59285. This PR removes the need to update the `llvm-rebuild-trigger` file. Instead, the latest commit hash of the appropriate LLVM submodule will be stored in the stamp file and used to detect if a build is required. Fixes #42405. Fixes #54959. Fixes #55537.
r? @alexcrichton