Skip to content

Conversation

ollie27
Copy link
Contributor

@ollie27 ollie27 commented Apr 9, 2019

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Apr 9, 2019
@QuietMisdreavus
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Apr 9, 2019

📌 Commit d6fd57a has been approved by QuietMisdreavus

@bors
Copy link
Collaborator

bors commented Apr 9, 2019

🌲 The tree is currently closed for pull requests below priority 15, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Apr 9, 2019
sanxiyn added a commit to sanxiyn/rust that referenced this pull request Apr 11, 2019
…sdreavus

Fix broken links on std::boxed doc page

r? @QuietMisdreavus
@@ -65,7 +65,7 @@
#![allow(explicit_outlives_requirements)]

#![warn(deprecated_in_future)]
#![warn(intra_doc_link_resolution_failure)]
#![deny(intra_doc_link_resolution_failure)]
Copy link
Member

@RalfJung RalfJung Apr 11, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We compile with -D warnings, why does this even make a difference?

I remember trying this locally, and #![warn] things turned into errors as expected.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't yet pass -D warnings to rustdoc when building the docs unfortunately.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I see. When/if you change this next time, please add a comment explaining that. :)

@ollie27
Copy link
Contributor Author

ollie27 commented Apr 11, 2019

Looks like I was premature with changing intra_doc_link_resolution_failure lint back to deny as we now have some failures from stdsimd #59868 (comment) so I've removed the lint changes.

@ollie27
Copy link
Contributor Author

ollie27 commented Apr 11, 2019

@bors r=QuietMisdreavus

@bors
Copy link
Collaborator

bors commented Apr 11, 2019

📌 Commit ae2a68b has been approved by QuietMisdreavus

Centril added a commit to Centril/rust that referenced this pull request Apr 12, 2019
…sdreavus

Fix broken links on std::boxed doc page

r? @QuietMisdreavus
bors added a commit that referenced this pull request Apr 12, 2019
Rollup of 15 pull requests

Successful merges:

 - #59680 (Document the -Z flag to the rustc book)
 - #59711 (Add back the substring test)
 - #59806 (compiletest: Improve no_prefer_dynamic docs)
 - #59809 (Make trait_methods_not_found use a lock)
 - #59811 (Kill dead code dominator code.)
 - #59814 (Fix broken links on std::boxed doc page)
 - #59821 (improve unknown enum variant errors)
 - #59831 (Remove strange formatting in `Ordering` docs.)
 - #59836 (std::ops::Div examples: correct nominator to numerator)
 - #59857 (SGX target: fix cfg(test) build)
 - #59876 (Update TRPL to use mdbook 0.2)
 - #59880 (Remove note about transmute for float bitpatterns.)
 - #59889 (Update diagnostics.rs)
 - #59891 (Fix the link to sort_by_cached_key)
 - #59894 (save-analysis: Pull associated type definition using `qpath_def`)

Failed merges:

r? @ghost
@bors bors merged commit ae2a68b into rust-lang:master Apr 12, 2019
@ollie27 ollie27 deleted the dead_boxed_links branch April 12, 2019 14:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants