Fix the link to sort_by_cached_key #59891
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's a primitive slice method, not a standalone function.
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 90d9727 has been approved by |
bors
added
S-waiting-on-bors
jonas-schievink
added
the
T-release
|
Oops, I just realized that I made this branch on the rust-lang repo (through the GitHub editor). Should I close and redo this PR using my own fork, or just let it be? |
|
@cuviper should be fine, people do that from time to time |
|
Also marking this for backport discussion. If there ever is a 1.34.1, would be nice to get this in as well. |
jonas-schievink
added
beta-nominated
Centril
added a commit
to Centril/rust
that referenced
this pull request
Apr 12, 2019
…as-schievink Fix the link to sort_by_cached_key It's a primitive slice method, not a standalone function.
bors
added a commit
that referenced
this pull request
Apr 12, 2019
Rollup of 15 pull requests Successful merges: - #59680 (Document the -Z flag to the rustc book) - #59711 (Add back the substring test) - #59806 (compiletest: Improve no_prefer_dynamic docs) - #59809 (Make trait_methods_not_found use a lock) - #59811 (Kill dead code dominator code.) - #59814 (Fix broken links on std::boxed doc page) - #59821 (improve unknown enum variant errors) - #59831 (Remove strange formatting in `Ordering` docs.) - #59836 (std::ops::Div examples: correct nominator to numerator) - #59857 (SGX target: fix cfg(test) build) - #59876 (Update TRPL to use mdbook 0.2) - #59880 (Remove note about transmute for float bitpatterns.) - #59889 (Update diagnostics.rs) - #59891 (Fix the link to sort_by_cached_key) - #59894 (save-analysis: Pull associated type definition using `qpath_def`) Failed merges: r? @ghost
|
@rustbot modify labels: beta-accepted stable-accepted |
rustbot
added
beta-accepted
pietroalbini
added
stable-accepted
bors
added a commit
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors
added a commit
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
bors
added a commit
that referenced
this pull request
Apr 24, 2019
[stable] 1.34.1 point release The release date is April 25th. Included in this point release: * #59891: Fix the link to sort_by_cached_key * #59989: Fix links to Atomic* in RELEASES.md * rust-lang/rust-clippy#3805: Fix ICE https://github.com/rust-lang/rust-clippy/issue/3747 * rust-lang/rust-clippy#3821: do not trigger redundant_closure when there is a difference in borrow... * rust-lang/rust-clippy#3844: Fix two missing_const_for_fn false positives
pietroalbini
removed
the
beta-nominated
bors
added a commit
that referenced
this pull request
Apr 27, 2019
[beta] Rollup backports Cherry-picked: * #59886: musl: do not compress debug section * #59891: Fix the link to sort_by_cached_key * #59911: Revert "compile crates under test w/ -Zemit-stack-sizes" * #59978: rustdoc: Remove default keyword from re-exported trait methods * #59989: Fix links to Atomic* in RELEASES.md * #60186: Temporarily accept [i|u][32|size] suffixes on a tuple index and warn * #60309: Add 1.34.1 release notes Rolled up: * #60273: [beta] bootstrap; remove redundant imports. r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It's a primitive slice method, not a standalone function.