-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't generate unnecessary rmeta files. #60190
Conversation
79c73b4
to
0e70582
Compare
@alexcrichton: removing the first rmeta generation as you suggested worked fine. The second one (conditional on it not being a dylib) didn't work... maybe I got the condition wrong? Details are in the comment in the code. |
0e70582
to
8d4ecef
Compare
@alexcrichton New code is up! |
@bors: r+ |
📌 Commit 8d4ecef7af84564eba78686a308ba0236031321f has been approved by |
@bors r- @alexcrichton: I realize now that this change should do more -- the creation of |
8d4ecef
to
3fc0936
Compare
I ended up only making a tiny change -- I moved the creation of I had thought a bigger change was possible, that I could do the same thing with @bors r=alexcrichton |
📌 Commit 3fc0936 has been approved by |
…excrichton Don't generate unnecessary rmeta files. As per rust-lang#60006 (comment). r? @alexcrichton
…excrichton Don't generate unnecessary rmeta files. As per rust-lang#60006 (comment). r? @alexcrichton
Rollup of 5 pull requests Successful merges: - #56278 (Future-proof MIR for dedicated debuginfo.) - #59739 (Stabilize futures_api) - #59822 (Fix dark css rule) - #60186 (Temporarily accept [i|u][32|size] suffixes on a tuple index and warn) - #60190 (Don't generate unnecessary rmeta files.) Failed merges: r? @ghost
This PR broke clippy's test suite. We are using compiletest and are some of our ui tests use
I'm assuming this is a compiletest bug or misconfiguration on our side. Any tips? Do we even need that file (like is it just wrongly generating the need for it)? Or do we need to pass a flag so it is generated again? |
@oli-obk Can you check if rust-lang/rust-clippy#4115 fixes your issue? |
Fix compile-test from forcing a rebuild. If the `compile-test` test was run, then running a cargo build command immediately after caused everything to be rebuilt. This is because the `compile-test` test was deleting all `.rmeta` files in the target directory. Cargo recently switched to always generating `.rmeta` files (rust-lang/cargo#6883), and when the files are deleted, it thinks it needs to be rebuilt. I am not very familiar with compiletest or clippy, so please take a close look and test this out (with the most recent nightly). In particular, make sure it doesn't revert the fixes from #3380 (it seems to work for me). Also @oli-obk mentioned something related in rust-lang/rust#60190 (comment), and I want to make sure that is addressed as well. Fixes #4114
As per #60006 (comment).
r? @alexcrichton