Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explain that ? converts the error type using From #60924

Merged
merged 1 commit into from
May 19, 2019
Merged

Explain that ? converts the error type using From #60924

merged 1 commit into from
May 19, 2019

Conversation

estebank
Copy link
Contributor

Fix #60917.

@rust-highfive
Copy link
Collaborator

r? @petrochenkov

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 17, 2019
@estebank estebank mentioned this pull request May 17, 2019
Closed
@cuviper
Copy link
Member

cuviper commented May 17, 2019

FWIW, I'm experimenting with using Into instead in #60796, although it doesn't look promising. I'm not sure if type inference can be improved to avoid massive breaking changes.

@estebank
Copy link
Contributor Author

estebank commented May 17, 2019 •
edited
Loading

@cuviper the regression on error messages should make it obvious when hacks like this are in use. I believe the weird error you note in that PR is partly one of these cases.

sunjay
sunjay approved these changes May 17, 2019
View reviewed changes
Copy link
Member

@sunjay sunjay left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome! Thank you Esteban! ❤️

@Centril
Copy link
Contributor

Centril commented May 17, 2019

I'm not sure if type inference can be improved to avoid massive breaking changes.

Scheduled a try build for crater.

@petrochenkov
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 17, 2019

📌 Commit 65b7319 has been approved by petrochenkov

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 17, 2019
Centril added a commit to Centril/rust that referenced this pull request May 19, 2019
@Centril
Rollup merge of rust-lang#60924 - estebank:try-msg, r=petrochenkov
80d372f 
Explain that ? converts the error type using From

Fix rust-lang#60917.
@Centril Centril mentioned this pull request May 19, 2019
Merged
bors added a commit that referenced this pull request May 19, 2019
@bors
Auto merge of #60949 - Centril:rollup-f918e1v, r=Centril
26ab324 
Rollup of 8 pull requests

Successful merges:

 - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const)
 - #60678 (Stabilize vecdeque_rotate)
 - #60924 (Explain that ? converts the error type using From)
 - #60931 (Use iter() for iterating arrays by slice)
 - #60934 (Declare DefIndex with the newtype_index macro)
 - #60943 (fix copy-paste typo in docs for ptr::read_volatile)
 - #60945 (Simplify BufRead::fill_buf doc example using NLL)
 - #60947 (Fix typos in docs of GlobalAlloc)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 19, 2019

☔ The latest upstream changes (presumably #60949) made this pull request unmergeable. Please resolve the merge conflicts.

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 19, 2019
@bors bors merged commit 65b7319 into rust-lang:master May 19, 2019
@sunjay
Copy link
Member

sunjay commented May 19, 2019

Bors was able to merge this even though it was unmergeable?

@tesuji
Copy link
Contributor

tesuji commented May 19, 2019

The rollup #60949 contains this PR.

@estebank estebank deleted the try-msg branch November 9, 2023 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sunjay sunjay sunjay approved these changes

Assignees

@petrochenkov petrochenkov

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Error message for question mark operator should message conversion
8 participants
@estebank @rust-highfive @cuviper @Centril @petrochenkov @bors @sunjay @tesuji