Simplify BufRead::fill_buf doc example using NLL #60945
Conversation
|
Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @shepmaster (or someone else) soon. If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes. Please see the contribution instructions for more information. |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 01cf36e has been approved by |
bors
added
S-waiting-on-bors
|
Thanks! If you are looking for more fun things to clean up in this type of thing, doctests can also use |
…=shepmaster Simplify BufRead::fill_buf doc example using NLL With non-lexical lifetimes, in this example it is no longer necessary to use a block to end the borrow early.
Rollup of 8 pull requests Successful merges: - #60370 (Mark core::alloc::Layout::from_size_align_unchecked const) - #60678 (Stabilize vecdeque_rotate) - #60924 (Explain that ? converts the error type using From) - #60931 (Use iter() for iterating arrays by slice) - #60934 (Declare DefIndex with the newtype_index macro) - #60943 (fix copy-paste typo in docs for ptr::read_volatile) - #60945 (Simplify BufRead::fill_buf doc example using NLL) - #60947 (Fix typos in docs of GlobalAlloc) Failed merges: r? @ghost
With non-lexical lifetimes, in this example it is no longer necessary to use a block to end the borrow early.