Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rustc_metadata: parametrize schema::CrateRoot by 'tcx and rip out old unused incremental infra. #61034

Merged
merged 2 commits into from
May 23, 2019

Conversation

eddyb
Copy link
Member

@eddyb eddyb commented May 22, 2019

These are the first two commits of #59953, already reviewed and approved by @michaelwoerister.

r? @michaelwoerister

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 22, 2019
@eddyb
Copy link
Member Author

eddyb commented May 22, 2019

@bors r=michaelwoerister (as per #59953 (comment))

@bors
Copy link
Contributor

bors commented May 22, 2019

📌 Commit 7327768 has been approved by michaelwoerister

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 22, 2019
Copy link
Member

@michaelwoerister michaelwoerister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes!

@michaelwoerister
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented May 22, 2019

💡 This pull request was already approved, no need to approve it again.

@bors
Copy link
Contributor

bors commented May 22, 2019

📌 Commit 7327768 has been approved by michaelwoerister

Centril added a commit to Centril/rust that referenced this pull request May 22, 2019
…lwoerister

rustc_metadata: parametrize schema::CrateRoot by 'tcx and rip out old unused incremental infra.

These are the first two commits of rust-lang#59953, already reviewed and approved by @michaelwoerister.

r? @michaelwoerister
bors added a commit that referenced this pull request May 22, 2019
Rollup of 8 pull requests

Successful merges:

 - #60300 (Allow null-pointer-optimized enums in FFI if their underlying representation is FFI safe)
 - #60773 (Always try to project predicates when finding auto traits in rustdoc)
 - #60809 (Add FAQ for NLL migration)
 - #61023 (Migrate from recursion to iterate on qualify consts visitor impl)
 - #61029 (Simplify RefCell minimum_spanning_tree example)
 - #61030 (Make maybe_codegen_consume_direct iterate instead of doing recursion)
 - #61034 (rustc_metadata: parametrize schema::CrateRoot by 'tcx and rip out old unused incremental infra.)
 - #61037 (Update clippy submodule)

Failed merges:

r? @ghost
@bors bors merged commit 7327768 into rust-lang:master May 23, 2019
@eddyb eddyb deleted the soa-metadata-prereq branch May 23, 2019 16:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants