Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add missing error code explanation for E0183 #61225

Closed
wants to merge 1 commit into from
Closed

Add missing error code explanation for E0183 #61225

wants to merge 1 commit into from

Conversation

ewk
Copy link
Contributor

@ewk ewk commented May 27, 2019

This is part of the ongoing work for #61137

@rust-highfive
Copy link
Collaborator

Some changes occurred in diagnostic error codes

cc @GuillaumeGomez

@rust-highfive
Copy link
Collaborator

r? @eddyb

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 27, 2019
GuillaumeGomez
GuillaumeGomez reviewed May 27, 2019
View reviewed changes
src/librustc_typeck/error_codes.rs
E0183: r##"
Fn* traits (`unboxed closures`) are experimental.

Functions must have exactly one (non self) argument, a tuple representing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a failing code example.

GuillaumeGomez
GuillaumeGomez reviewed May 27, 2019
View reviewed changes
src/librustc_typeck/error_codes.rs
the argument list [1]. This feature can be enabled with:

```
#![feature(unboxed_closures)]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please show a complete fixed code example.

GuillaumeGomez
GuillaumeGomez requested changes May 27, 2019
View reviewed changes
Copy link
Member

@GuillaumeGomez GuillaumeGomez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please follow the same "template" the other long error explanations are using too please.

@oli-obk oli-obk added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 7, 2019
@oli-obk oli-obk assigned GuillaumeGomez and unassigned eddyb Jun 7, 2019
@fmckeogh
Copy link
Member

Ping from triage @ewk, waiting on changes.

@wirelessringo
Copy link

Ping from triage. @ewk any updates on this?

@Karrq
Copy link

Karrq commented Jul 26, 2019 •
edited
Loading

I'll get it done tonight, if that's not a problem

(I'm not @ewk)

@Dylan-DPC-zz
Copy link

Closing this as @Karrq will work on it in a separate PR

@Karrq Karrq mentioned this pull request Jul 26, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GuillaumeGomez GuillaumeGomez GuillaumeGomez requested changes

Assignees

@GuillaumeGomez GuillaumeGomez

Labels
S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@ewk @rust-highfive @fmckeogh @wirelessringo @Karrq @Dylan-DPC-zz @GuillaumeGomez @eddyb @oli-obk