Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 9 pull requests #61258

Merged
merged 23 commits into from
May 28, 2019
Merged

Rollup of 9 pull requests #61258

merged 23 commits into from
May 28, 2019

Conversation

Centril
Copy link
Contributor

@Centril Centril commented May 28, 2019

Successful merges:

Failed merges:

r? @ghost

blkerby and others added 23 commits May 23, 2019 09:04
Co-Authored-By: Ralf Jung <post@ralfj.de>
Use .await syntax instead of await!

Tiny doc fix.
avoid creating Boxes of uninitalized values in RawVec

`RawVec<bool>::into_box` is definitely instant UB, if not all values are initialized.

See https://gankro.github.io/blah/initialize-me-maybe/
…-Simulacrum

Updated the Iterator docs with information about overriding methods.

# Description

Updated the Iterator docs with information about overriding methods.

closes rust-lang#60223
…e, r=oli-obk

Make dest_needs_borrow iterate instead of recurse

r? @oli-obk
…sleywiser

Make eval_place iterate instead of recurse

r? @oli-obk
@Centril
Copy link
Contributor Author

Centril commented May 28, 2019

@bors r+ rollup=never p=9

@bors
Copy link
Contributor

bors commented May 28, 2019

📌 Commit 149c53f has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 28, 2019
@bors
Copy link
Contributor

bors commented May 28, 2019

⌛ Testing commit 149c53f with merge 05de9f3...

bors added a commit that referenced this pull request May 28, 2019
Rollup of 9 pull requests

Successful merges:

 - #61084 (Clarify docs for unreachable! macro)
 - #61220 (Added error message for E0284)
 - #61227 (Use .await syntax instead of await!)
 - #61230 (avoid creating Boxes of uninitalized values in RawVec)
 - #61237 (Updated the Iterator docs with information about overriding methods.)
 - #61241 (Check place iterative)
 - #61242 (Make dest_needs_borrow iterate instead of recurse)
 - #61247 (Make eval_place iterate instead of recurse)
 - #61248 (Use Place::local)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 28, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job arm-android of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[01:49:28] test string::test_str_truncate ... ok
[01:49:28] test string::test_str_truncate_invalid_len ... ok
[01:49:28] test string::test_str_truncate_split_codepoint ... ok
[01:49:28] test string::test_split_off_empty ... ok
[01:49:28] died due to signal 11
[01:49:28] error: test failed, to rerun pass '-p alloc --test collectionstests'
[01:49:28] 
[01:49:28] 
[01:49:28] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "arm-linux-androideabi" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind backtrace compiler-builtins-c" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "-p" "alloc" "--"
[01:49:28] 
[01:49:28] 
[01:49:28] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test --target arm-linux-androideabi
[01:49:28] Build completed unsuccessfully in 1:38:29
---
travis_time:end:05b4703b:start=1559044026159210400,finish=1559044026170679331,duration=11468931
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:13136565
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:04ffed98
travis_time:start:04ffed98
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:110f519c
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels May 28, 2019
@Centril
Copy link
Contributor Author

Centril commented May 28, 2019

@bors retry

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 28, 2019
@bors
Copy link
Contributor

bors commented May 28, 2019

⌛ Testing commit 149c53f with merge 7da1185...

bors added a commit that referenced this pull request May 28, 2019
Rollup of 9 pull requests

Successful merges:

 - #61084 (Clarify docs for unreachable! macro)
 - #61220 (Added error message for E0284)
 - #61227 (Use .await syntax instead of await!)
 - #61230 (avoid creating Boxes of uninitalized values in RawVec)
 - #61237 (Updated the Iterator docs with information about overriding methods.)
 - #61241 (Check place iterative)
 - #61242 (Make dest_needs_borrow iterate instead of recurse)
 - #61247 (Make eval_place iterate instead of recurse)
 - #61248 (Use Place::local)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented May 28, 2019

☀️ Test successful - checks-travis, status-appveyor
Approved by: Centril
Pushing 7da1185 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label May 28, 2019
@bors bors merged commit 149c53f into rust-lang:master May 28, 2019
@Centril Centril deleted the rollup-l2mof9t branch May 28, 2019 15:25
@Centril Centril added the rollup A PR which is a rollup label Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants