-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 14 pull requests #61509
Rollup of 14 pull requests #61509
Conversation
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Here follows the main reverts applied in order to make this commit: Revert "Rollup merge of rust-lang#60676 - davidtwco:issue-60674, r=cramertj" This reverts commit 45b0945, reversing changes made to f6df1f6. Revert "Rollup merge of rust-lang#60437 - davidtwco:issue-60236, r=nikomatsakis" This reverts commit 16939a5, reversing changes made to 12bf981. Revert "Rollup merge of rust-lang#59823 - davidtwco:issue-54716, r=cramertj" This reverts commit 62d1574, reversing changes made to 4eff852.
This commit re-implements the async fn drop order lowering changes so that it all takes place in HIR lowering, building atop the work done by `@eddyb` to refactor `Res::Upvar`. Previously, this types involved in the lowering were constructed in libsyntax as they had to be used during name resolution and HIR lowering. This was awful because none of that logic should have existed in libsyntax. This commit also changes `ArgSource` to keep a `HirId` to the original argument pattern rather than a cloned copy of the pattern.
This commit removes the `HirId` from `ArgSource::AsyncFn`, relying on the fact that only `simple_ident` is used in each of the locations that previously took the original pattern from the `ArgSource::AsyncFn`.
This commit changes the lowering to stop creating HIR statements, expressions and patterns directly and instead uses the pre-existing helper functions.
This commit simplifies the previous logic to construct the statement vector directly rather than constructing a `Vec` of `(hir::Stmt, Option<hir::Stmt>)` first.
`ArgSource` is no longer used anywhere, so it can be removed.
This was accidentally regressed in rust-lang#60777 by accident, and we've stopped printing out step timings on AppVeyor recently reducing the ability for us to track build times over time!
Also removes stage1, stage2 cfgs being passed to rustc to ensure that stage1 and stage2 are only differentiated as a group (i.e., only through not bootstrap).
…rk-Simulacrum Fix documentation of `Rc::make_mut` regarding `rc::Weak`. Closes rust-lang#60961
miri unsizing: fix projecting into a field of an operand I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings. Fixes rust-lang/miri#754 r? @oli-obk
…=oli-obk Fix an ICE with a const argument in a trait This goes some way towards fixing rust-lang#61383 (the reduced test case is fixed).
…-sane-way, r=eddyb Re-implement async fn drop order lowering This PR re-implements the async fn drop order lowering changes so that it all takes place in HIR lowering, building atop the work done by @eddyb to refactor `Res::Upvar`. Previously, this types involved in the lowering were constructed in libsyntax as they had to be used during name resolution and HIR lowering. This was awful because none of that logic should have existed in libsyntax. This commit also changes `ArgSource` to keep a `HirId` to the original argument pattern rather than a cloned copy of the pattern. Only b7aa4ed and 71fb8fa should be reviewed, any other commits are from rust-lang#61276 (though 447e336 might end up staying in this PR). As a nice side effect, it also fixes rust-lang#61187 (cc rust-lang#61192). r? @eddyb cc @cramertj
…amertj Add an unusual-conversion example to to_uppercase Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
Succinctify splice docs
…jasper Suggest using `as_ref` on `*const T` Fix rust-lang#21596.
…asper On TerminatorKind::DropAndReplace still handle unused_mut correctly Closes rust-lang#61424 - [x] Todo add regression test
…alexcrichton azure: retry s3 upload if it fails We had some cases (like [this](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/370/logs/734) a few hours ago) when uploading to S3 fails with a network error. This retries the upload if it fails. r? @alexcrichton
…etroalbini ci: Reenable step timings on AppVeyor This was accidentally regressed in rust-lang#60777 by accident, and we've stopped printing out step timings on AppVeyor recently reducing the ability for us to track build times over time!
…ap, r=alexcrichton Utilize cfg(bootstrap) over cfg(stage0) Also removes stage1, stage2 cfgs being passed to rustc to ensure that stage1 and stage2 are only differentiated as a group (i.e., only through not bootstrap). Fixes rust-lang#53582 r? @alexcrichton
…ens, r=varkor Do not panic in tidy on unbalanced parentheses in cfg's Fixes rust-lang#60505
…um-cpus, r=alexcrichton Treat 0 as special value for codegen-units-std Fixes rust-lang#57669
Add regression test for existential type ICE rust-lang#53457 Closes rust-lang#53457.
@bors r+ p=14 rollup=never |
📌 Commit 70865fc has been approved by |
⌛ Testing commit 70865fc with merge 3d65e1878e6e459beb8de79990deb5997311447f... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-travis |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
Rc::make_mut
regardingrc::Weak
. #61135 (Fix documentation ofRc::make_mut
regardingrc::Weak
.)as_ref
on*const T
#61444 (Suggest usingas_ref
on*const T
)Failed merges:
r? @ghost