Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 14 pull requests #61509

Closed
wants to merge 45 commits into from
Closed

Conversation

Centril
Copy link
Contributor

@Centril Centril commented Jun 4, 2019

Successful merges:

Failed merges:

r? @ghost

czipperz and others added 30 commits May 24, 2019 15:28
Co-Authored-By: Jonas Schievink <jonasschievink@gmail.com>
Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
Co-Authored-By: Mazdak Farrokhzad <twingoow@gmail.com>
Here follows the main reverts applied in order to make this commit:

Revert "Rollup merge of rust-lang#60676 - davidtwco:issue-60674, r=cramertj"

This reverts commit 45b0945, reversing
changes made to f6df1f6.

Revert "Rollup merge of rust-lang#60437 - davidtwco:issue-60236, r=nikomatsakis"

This reverts commit 16939a5, reversing
changes made to 12bf981.

Revert "Rollup merge of rust-lang#59823 - davidtwco:issue-54716, r=cramertj"

This reverts commit 62d1574, reversing
changes made to 4eff852.
This commit re-implements the async fn drop order lowering changes so
that it all takes place in HIR lowering, building atop the work done by
`@eddyb` to refactor `Res::Upvar`.

Previously, this types involved in the lowering were constructed in
libsyntax as they had to be used during name resolution and HIR
lowering. This was awful because none of that logic should have existed
in libsyntax.

This commit also changes `ArgSource` to keep a `HirId` to the original
argument pattern rather than a cloned copy of the pattern.
This commit removes the `HirId` from `ArgSource::AsyncFn`, relying on
the fact that only `simple_ident` is used in each of the locations that
previously took the original pattern from the `ArgSource::AsyncFn`.
This commit changes the lowering to stop creating HIR statements,
expressions and patterns directly and instead uses the pre-existing
helper functions.
This commit simplifies the previous logic to construct the statement
vector directly rather than constructing a `Vec` of
`(hir::Stmt, Option<hir::Stmt>)` first.
`ArgSource` is no longer used anywhere, so it can be removed.
This was accidentally regressed in rust-lang#60777 by accident, and we've stopped
printing out step timings on AppVeyor recently reducing the ability for
us to track build times over time!
Also removes stage1, stage2 cfgs being passed to rustc to ensure that
stage1 and stage2 are only differentiated as a group (i.e., only through
not bootstrap).
Mark-Simulacrum and others added 15 commits June 3, 2019 12:57
…rk-Simulacrum

Fix documentation of `Rc::make_mut` regarding `rc::Weak`.

Closes rust-lang#60961
miri unsizing: fix projecting into a field of an operand

I don't know why this open-coded an operand field projection. Probably this code predates one or more of my refactorings.

Fixes rust-lang/miri#754

r? @oli-obk
…=oli-obk

Fix an ICE with a const argument in a trait

This goes some way towards fixing rust-lang#61383 (the reduced test case is fixed).
…-sane-way, r=eddyb

Re-implement async fn drop order lowering

This PR re-implements the async fn drop order lowering changes so
that it all takes place in HIR lowering, building atop the work done by
@eddyb to refactor `Res::Upvar`.

Previously, this types involved in the lowering were constructed in
libsyntax as they had to be used during name resolution and HIR
lowering. This was awful because none of that logic should have existed
in libsyntax.

This commit also changes `ArgSource` to keep a `HirId` to the original
argument pattern rather than a cloned copy of the pattern.

Only b7aa4ed and 71fb8fa should be reviewed, any other commits
are from rust-lang#61276 (though 447e336 might end up staying in this PR).

As a nice side effect, it also fixes rust-lang#61187 (cc rust-lang#61192).

r? @eddyb
cc @cramertj
…amertj

Add an unusual-conversion example to to_uppercase

Like how to_lowercase has ὈΔΥΣΣΕΎΣ.
…asper

On TerminatorKind::DropAndReplace still handle unused_mut correctly

Closes rust-lang#61424

- [x] Todo add regression test
…alexcrichton

azure: retry s3 upload if it fails

We had some cases (like [this](https://dev.azure.com/rust-lang/e71b0ddf-dd27-435a-873c-e30f86eea377/_apis/build/builds/370/logs/734) a few hours ago) when uploading to S3 fails with a network error. This retries the upload if it fails.

r? @alexcrichton
…etroalbini

ci: Reenable step timings on AppVeyor

This was accidentally regressed in rust-lang#60777 by accident, and we've stopped
printing out step timings on AppVeyor recently reducing the ability for
us to track build times over time!
…ap, r=alexcrichton

Utilize cfg(bootstrap) over cfg(stage0)

Also removes stage1, stage2 cfgs being passed to rustc to ensure that
stage1 and stage2 are only differentiated as a group (i.e., only through
not bootstrap).

Fixes rust-lang#53582

r? @alexcrichton
…ens, r=varkor

Do not panic in tidy on unbalanced parentheses in cfg's

Fixes rust-lang#60505
…um-cpus, r=alexcrichton

Treat 0 as special value for codegen-units-std

Fixes rust-lang#57669
@Centril
Copy link
Contributor Author

Centril commented Jun 4, 2019

@bors r+ p=14 rollup=never

@bors
Copy link
Contributor

bors commented Jun 4, 2019

📌 Commit 70865fc has been approved by Centril

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label Jun 4, 2019
@bors
Copy link
Contributor

bors commented Jun 4, 2019

⌛ Testing commit 70865fc with merge 3d65e1878e6e459beb8de79990deb5997311447f...

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
travis_time:end:22da64cc:start=1559615694654688155,finish=1559615794894299143,duration=100239610988
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
[00:04:01]    Compiling std v0.0.0 (/checkout/src/libstd)
[00:04:03] error[E0093]: unrecognized intrinsic function: `unchecked_add`
[00:04:03]     --> src/libcore/intrinsics.rs:1246:5
[00:04:03]      |
[00:04:03] 1246 |     pub fn unchecked_add<T>(x: T, y: T) -> T;
[00:04:03]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:04:03] 
[00:04:03] error[E0093]: unrecognized intrinsic function: `unchecked_sub`
[00:04:03]      |
[00:04:03]      |
[00:04:03] 1251 |     pub fn unchecked_sub<T>(x: T, y: T) -> T;
[00:04:03]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:04:03] 
[00:04:03] error[E0093]: unrecognized intrinsic function: `unchecked_mul`
[00:04:03]      |
[00:04:03]      |
[00:04:03] 1256 |     pub fn unchecked_mul<T>(x: T, y: T) -> T;
[00:04:03]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:04:03]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:04:03]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:04:04]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:04:04]    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
---
travis_time:end:07656ac8:start=1559616055171504766,finish=1559616055176159209,duration=4654443
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:0f54cdec
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0adac73c
travis_time:start:0adac73c
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors
Copy link
Contributor

bors commented Jun 4, 2019

💔 Test failed - checks-travis

@rust-highfive
Copy link
Collaborator

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.
[00:05:04]    Compiling std v0.0.0 (/checkout/src/libstd)
[00:05:06] error[E0093]: unrecognized intrinsic function: `unchecked_add`
[00:05:06]     --> src/libcore/intrinsics.rs:1246:5
[00:05:06]      |
[00:05:06] 1246 |     pub fn unchecked_add<T>(x: T, y: T) -> T;
[00:05:06]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:05:06] 
[00:05:06] error[E0093]: unrecognized intrinsic function: `unchecked_sub`
[00:05:06]      |
[00:05:06]      |
[00:05:06] 1251 |     pub fn unchecked_sub<T>(x: T, y: T) -> T;
[00:05:06]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:05:06] 
[00:05:06] error[E0093]: unrecognized intrinsic function: `unchecked_mul`
[00:05:06]      |
[00:05:06]      |
[00:05:06] 1256 |     pub fn unchecked_mul<T>(x: T, y: T) -> T;
[00:05:06]      |     ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^ unrecognized intrinsic
[00:05:06]    Compiling rustc_tsan v0.0.0 (/checkout/src/librustc_tsan)
[00:05:06]    Compiling rustc_lsan v0.0.0 (/checkout/src/librustc_lsan)
[00:05:07]    Compiling rustc_msan v0.0.0 (/checkout/src/librustc_msan)
[00:05:07]    Compiling rustc_asan v0.0.0 (/checkout/src/librustc_asan)
---
travis_time:end:0645e16c:start=1559616100525901506,finish=1559616100532084297,duration=6182791
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:25ed23c0
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:11a6eaf8
travis_time:start:11a6eaf8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:058b8288
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

@bors bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jun 4, 2019
@Centril Centril closed this Jun 4, 2019
@Centril Centril deleted the rollup-s26bbh0 branch June 4, 2019 02:48
@Centril Centril added the rollup A PR which is a rollup label Oct 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rollup A PR which is a rollup S-waiting-on-review Status: Awaiting review from the assignee but also interested parties.
Projects
None yet
Development

Successfully merging this pull request may close these issues.