-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make dep node indices persistent between sessions #62038
Conversation
r? @zackmdavis (rust_highfive has picked a reviewer for you, use r? to override) |
|
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #62018) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors try |
🔒 Merge conflict This pull request and the master branch diverged in a way that cannot be automatically merged. Please rebase on top of the latest master branch, and let the reviewer approve again. How do I rebase?Assuming
You may also read Git Rebasing to Resolve Conflicts by Drew Blessing for a short tutorial. Please avoid the "Resolve conflicts" button on GitHub. It uses Sometimes step 4 will complete without asking for resolution. This is usually due to difference between how Error message
|
@bors try |
[WIP] Make dep node indices persistent between sessions This makes marking dep nodes green faster (and lock free in the case with no diagnostics). This change is split out from #60035. Unlike #60035 this makes loading the dep graph slower because it loads 2 copies of the dep graph, one immutable and one mutable. Based on #61845, #61779 and #61923.
☀️ Try build successful - checks-travis |
@rust-timer build b397c11 |
Success: Queued b397c11 with parent e562b24, comparison URL. |
Finished benchmarking try commit b397c11, comparison URL. |
@bors try |
⌛ Trying commit fe23b602bc95491632a4bd7421600f40e91c3bb3 with merge 7830caefb62c9c8d3fb7a742c66c64c89bf3aafe... |
☀️ Try build successful - checks-travis |
@rust-timer build 7830caefb62c9c8d3fb7a742c66c64c89bf3aafe |
Success: Queued 7830caefb62c9c8d3fb7a742c66c64c89bf3aafe with parent 4a365a2, comparison URL. |
Finished benchmarking try commit 7830caefb62c9c8d3fb7a742c66c64c89bf3aafe, comparison URL. |
☔ The latest upstream changes (presumably #68944) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #70118) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #70211) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #70296) made this pull request unmergeable. Please resolve the merge conflicts. |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
☔ The latest upstream changes (presumably #70343) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #70383) made this pull request unmergeable. Please resolve the merge conflicts. |
☔ The latest upstream changes (presumably #70162) made this pull request unmergeable. Please resolve the merge conflicts. |
// For green nodes, we either executed the query (which always uses valid nodes) | ||
// or we marked it as green because all its dependencies are green and valid. | ||
DepNodeState::Green | | ||
// Red nodes were always exexuted. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*executed
// the dep-node color having been properly updated. | ||
// This means that the query system has reached an | ||
// invalid state. We let the compiler continue (by | ||
// returning `None`) so it can emit error messages |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
*returning false
☔ The latest upstream changes (presumably #70536) made this pull request unmergeable. Please resolve the merge conflicts. |
@rustbot claim |
Closing this pull request as Zoxc is stepping back from compiler development; see rust-lang/team#316. |
This makes marking dep nodes green faster (and lock free in the case with no diagnostics). This change is split out from #60035.
Unlike #60035 this makes loading the dep graph slower because it loads 2 copies of the dep graph, one immutable and one mutable.
Based on #61845.