-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move the query system to a dedicated crate #70162
Conversation
☔ The latest upstream changes (presumably #70211) made this pull request unmergeable. Please resolve the merge conflicts. |
3b43778
to
8d22625
Compare
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 8d22625da2fe03beca659384566a38fdab040351 with merge 0d717b485ce2213e0c429a599935baa71c4286ca... |
☀️ Try build successful - checks-azure |
@rust-timer build 0d717b485ce2213e0c429a599935baa71c4286ca |
Queued 0d717b485ce2213e0c429a599935baa71c4286ca with parent 2dcf54f, future comparison URL. |
Rebased TLS commit removed and review applied. |
Finished benchmarking try commit 0d717b485ce2213e0c429a599935baa71c4286ca, comparison URL. |
☔ The latest upstream changes (presumably #70383) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased with review applied. |
☔ The latest upstream changes (presumably #70297) made this pull request unmergeable. Please resolve the merge conflicts. |
Rebased. |
src/librustc_query_system/lib.rs
Outdated
pub trait HashStableContext { | ||
fn debug_dep_tasks(&self) -> bool; | ||
} | ||
pub trait HashStableContext {} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This trait seems useless now =P
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It is used by the macro HashStable_Generic
for WorkProductId
. I can implement it by hand also.
@bors p=1 r+ |
📌 Commit 222d010 has been approved by |
Oops, sorry. |
@bors r+ |
📌 Commit 2d7bbda has been approved by |
☀️ Test successful - checks-azure |
Looks like this regressed incremental benchmarks. There's probably some things that could use |
The query system
rustc::ty::query
is split out into therustc_query_system
crate.Some commits are unformatted, to ease rebasing.
Based on #67761 and #69910.
r? @Zoxc