Remove needless lifetimes (rustc) #62039

jeremystucki · 2019-06-21T22:09:00Z

No description provided.

rust-highfive · 2019-06-21T23:34:18Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:22cbbb80:start=1561155001507457737,finish=1561155005433717111,duration=3926259374
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:04:55] 
[01:04:55] running 9 tests
[01:04:55] iiiiiiiii
[01:04:55] 
[01:04:55]  finished in 0.151
[01:04:55] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:05:11] 
[01:05:11] running 122 tests
[01:05:35] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:05:40] .i.i......iii.i.....ii
[01:05:40] 
[01:05:40]  finished in 29.485
[01:05:40] travis_fold:end:test_debuginfo

---
[01:23:52]    Compiling rustc_data_structures v0.0.0 (/checkout/src/librustc_data_structures)
[01:23:53] error: hidden lifetime parameters in types are deprecated
[01:23:53]   --> src/librustc_data_structures/graph/test.rs:62:42
[01:23:53]    |
[01:23:53] 62 |     fn successors(&self, node: usize) -> <Self as GraphSuccessors>::Iter {
[01:23:53] 
[01:23:55] error: aborting due to previous error
[01:23:55] 
[01:23:55] error: Could not compile `rustc_data_structures`.
[01:23:55] error: Could not compile `rustc_data_structures`.
[01:23:55] 
[01:23:55] To learn more, run the command again with --verbose.
[01:23:55] 
[01:23:55] 
[01:23:55] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "rustc_data_structures" "--" "--quiet"
[01:23:55] 
[01:23:55] 
[01:23:55] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:23:55] Build completed unsuccessfully in 1:19:04

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc_data_structures/graph/test.rs

bors · 2019-06-22T05:21:56Z

☔ The latest upstream changes (presumably #62041) made this pull request unmergeable. Please resolve the merge conflicts.

tesuji · 2019-06-23T15:38:17Z

You need to rebase on top of master instead.

rust-highfive · 2019-06-23T19:36:26Z

The job x86_64-gnu-llvm-6.0 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

travis_time:end:03c00924:start=1561313219021875745,finish=1561313221482241957,duration=2460366212
$ git checkout -qf FETCH_HEAD
travis_fold:end:git.checkout

Encrypted environment variables have been removed for security reasons.
See https://docs.travis-ci.com/user/pull-requests/#pull-requests-and-security-restrictions
$ export SCCACHE_BUCKET=rust-lang-ci-sccache2
$ export SCCACHE_REGION=us-west-1
$ export GCP_CACHE_BUCKET=rust-lang-ci-cache
$ export AWS_ACCESS_KEY_ID=AKIA46X5W6CZEJZ6XT55
---
travis_time:start:test_assembly
Check compiletest suite=assembly mode=assembly (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:06:49] 
[01:06:49] running 9 tests
[01:06:49] iiiiiiiii
[01:06:49] 
[01:06:49]  finished in 0.156
[01:06:49] travis_fold:end:test_assembly

---
travis_time:start:test_debuginfo
Check compiletest suite=debuginfo mode=debuginfo-gdb+lldb (x86_64-unknown-linux-gnu -> x86_64-unknown-linux-gnu)
[01:07:06] 
[01:07:06] running 122 tests
[01:07:31] .iiiii...i.....i..i...i..i.i.i..i.ii..i.i.....i..i....i..........iiii..........i...ii...i.......ii.i 100/122
[01:07:36] .i.i......iii.i.....ii
[01:07:36] 
[01:07:36]  finished in 30.434
[01:07:36] travis_fold:end:test_debuginfo

---
[01:28:56]    Compiling syntax v0.0.0 (/checkout/src/libsyntax)
[01:29:01] error: hidden lifetime parameters in types are deprecated
[01:29:01]   --> src/libsyntax/util/parser_testing.rs:23:64
[01:29:01]    |
[01:29:01] 23 | pub fn string_to_parser(ps: &ParseSess, source_str: String) -> Parser {
[01:29:01] 
[01:29:09] error: aborting due to previous error
[01:29:09] 
[01:29:09] error: Could not compile `syntax`.
[01:29:09] error: Could not compile `syntax`.
[01:29:09] 
[01:29:09] To learn more, run the command again with --verbose.
[01:29:09] 
[01:29:09] 
[01:29:09] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "test" "--target" "x86_64-unknown-linux-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "" "--manifest-path" "/checkout/src/rustc/Cargo.toml" "-p" "syntax" "--" "--quiet"
[01:29:09] 
[01:29:09] 
[01:29:09] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
[01:29:09] Build completed unsuccessfully in 1:23:59
---
travis_time:end:03d9c598:start=1561318582755011415,finish=1561318582761247371,duration=6235956
travis_fold:end:after_failure.3
travis_fold:start:after_failure.4
travis_time:start:048c76a4
$ ln -s . checkout && for CORE in obj/cores/core.*; do EXE=$(echo $CORE | sed 's|obj/cores/core\.[0-9]*\.!checkout!\(.*\)|\1|;y|!|/|'); if [ -f "$EXE" ]; then printf travis_fold":start:crashlog\n\033[31;1m%s\033[0m\n" "$CORE"; gdb --batch -q -c "$CORE" "$EXE" -iex 'set auto-load off' -iex 'dir src/' -iex 'set sysroot .' -ex bt -ex q; echo travis_fold":"end:crashlog; fi; done || true
travis_fold:end:after_failure.4
travis_fold:start:after_failure.5
travis_time:start:0e4f5bf8
travis_time:start:0e4f5bf8
$ cat ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers || true
cat: ./obj/build/x86_64-unknown-linux-gnu/native/asan/build/lib/asan/clang_rt.asan-dynamic-i386.vers: No such file or directory
travis_fold:end:after_failure.5
travis_fold:start:after_failure.6
travis_time:start:08c22952
$ dmesg | grep -i kill

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-06-24T16:15:12Z

☔ The latest upstream changes (presumably #62092) made this pull request unmergeable. Please resolve the merge conflicts.

tesuji

You should file PRs on seperate repository of submodules if you want to change them
and after they are approved, file other PRs here to update those submodules.

tesuji · 2019-06-24T16:22:41Z

src/libcore/marker.rs

@@ -498,7 +498,7 @@ macro_rules! impls{
 /// #     end: *const T,
 /// #     phantom: PhantomData<&'a T>,
 /// # }
-/// fn borrow_vec<'a, T>(vec: &'a Vec<T>) -> Slice<'a, T> {
+/// fn borrow_vec<T>(vec: &Vec<T>) -> Slice<T> {


-> Slice<'_, T>

eddyb · 2019-06-24T16:32:53Z

r=me on the rustc changes, but you have some accidental submodule changes to remove, and someone else (i.e. from @rust-lang/libs) needs to review the standard library changes (it would be easier if the rustc parts and the std parts were split into two PRs, IMO).

jeremystucki · 2019-06-24T19:03:00Z

So just move the changes to src/libstd to its own PR?

eddyb · 2019-06-25T12:05:34Z

@jeremystucki Yeah, liballoc, libcore and libstd, they are part of "the standard library".
You can keep the changes to librustc*, libsyntax* and libproc_macro/bridge in a rustc-only PR.

bors · 2019-06-25T21:40:39Z

☔ The latest upstream changes (presumably #62119) made this pull request unmergeable. Please resolve the merge conflicts.

eddyb · 2019-06-26T09:54:22Z

r=me after a rebase

bors · 2019-06-30T15:43:39Z

☔ The latest upstream changes (presumably #59722) made this pull request unmergeable. Please resolve the merge conflicts.

jeremystucki · 2019-07-01T21:04:44Z

r? @eddyb

jeremystucki · 2019-07-01T21:05:09Z

On mobile, accidentally closed the PR

eddyb · 2019-07-02T03:15:45Z

@bors r+

bors · 2019-07-02T03:15:46Z

📌 Commit 4c221b3 has been approved by eddyb

Moved to its own PR

eddyb · 2019-07-03T14:19:54Z

@bors r+

bors · 2019-07-03T14:19:57Z

📌 Commit 88c515d has been approved by eddyb

…eddyb Remove needless lifetimes (rustc)

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

…eddyb Remove needless lifetimes (rustc)

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

…eddyb Remove needless lifetimes (rustc)

@ghost

Rollup of 17 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62153 (Update the `rust-installer` submodule) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost

…eddyb Remove needless lifetimes (rustc)

@ghost

Rollup of 16 pull requests Successful merges: - #62039 (Remove needless lifetimes (rustc)) - #62173 (rename InterpretCx -> InterpCx) - #62240 (wfcheck: resolve the type-vars in `AdtField` types) - #62249 (Use mem::take instead of mem::replace with default) - #62252 (Update mem::replace example to not be identical to mem::take) - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser) - #62268 (Clean up inherent_impls) - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind) - #62295 (miri realloc: do not require giving old size+align) - #62297 (refactor check_for_substitution) - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.) - #62317 (Migrate `compile-pass` annotations to `build-pass`) - #62337 (Fix bucket in CPU usage script) - #62344 (simplify Option::get_or_insert) - #62346 (enable a few more tests in Miri and update the comment for others) - #62351 (remove bogus example from drop_in_place) Failed merges: r? @ghost

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

rust-highfive assigned eddyb Jun 21, 2019

tesuji reviewed Jun 22, 2019

View reviewed changes

src/librustc_data_structures/graph/test.rs Outdated Show resolved Hide resolved

bors added the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jun 22, 2019

jeremystucki force-pushed the needless_lifetimes branch from c2ef324 to c8c2f97 Compare June 23, 2019 17:05

tesuji reviewed Jun 24, 2019

View reviewed changes

jeremystucki changed the title ~~Remove needless lifetimes~~ Remove needless lifetimes (rustc) Jun 25, 2019

jeremystucki mentioned this pull request Jun 25, 2019

Remove needless lifetimes (std) #62123

Merged

eddyb approved these changes Jun 26, 2019

View reviewed changes

jeremystucki force-pushed the needless_lifetimes branch from 15f8cee to 73511fc Compare June 26, 2019 12:17

jeremystucki force-pushed the needless_lifetimes branch 3 times, most recently from f5d67a3 to 4c221b3 Compare July 1, 2019 10:31

jeremystucki closed this Jul 1, 2019

jeremystucki reopened this Jul 1, 2019

bors removed the S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. label Jul 2, 2019

jeremystucki added 6 commits July 3, 2019 10:01

Remove needless lifetimes

d28832d

Add missing lifetime specifier

3cd4df7

Add missing lifetime specifier

80f4c49

Add missing lifetime specifier

b17cec5

Add missing lifetime specifier

edcde70

Revert changes to the standard library

88c515d

Moved to its own PR

jeremystucki force-pushed the needless_lifetimes branch from 4c221b3 to 88c515d Compare July 3, 2019 08:01

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 3, 2019

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62039 - jeremystucki:needless_lifetimes, r=…

7a4f891

…eddyb Remove needless lifetimes (rustc)

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…

dad3222

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

Centril mentioned this pull request Jul 3, 2019

Rollup of 17 pull requests #62349

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62039 - jeremystucki:needless_lifetimes, r=…

2970a13

…eddyb Remove needless lifetimes (rustc)

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…

8d3cc45

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

Centril mentioned this pull request Jul 3, 2019

Rollup of 18 pull requests #62352

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62039 - jeremystucki:needless_lifetimes, r=…

4c87ba3

…eddyb Remove needless lifetimes (rustc)

Centril mentioned this pull request Jul 3, 2019

Rollup of 17 pull requests #62354

Closed

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019

Rollup merge of rust-lang#62039 - jeremystucki:needless_lifetimes, r=…

e8a88f7

…eddyb Remove needless lifetimes (rustc)

Centril mentioned this pull request Jul 3, 2019

Rollup of 16 pull requests #62355

Merged

bors merged commit 88c515d into rust-lang:master Jul 4, 2019

jeremystucki deleted the needless_lifetimes branch July 4, 2019 08:41

Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 4, 2019

Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…

73fa329

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019

Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…

65826d2

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

Centril added a commit to Centril/rust that referenced this pull request Jul 5, 2019

Rollup merge of rust-lang#62123 - jeremystucki:needless_lifetimes_std…

0f92eb8

…, r=alexcrichton Remove needless lifetimes (std) Split from rust-lang#62039

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove needless lifetimes (rustc) #62039

Remove needless lifetimes (rustc) #62039

jeremystucki commented Jun 21, 2019

rust-highfive commented Jun 21, 2019

bors commented Jun 22, 2019

tesuji commented Jun 23, 2019

rust-highfive commented Jun 23, 2019

bors commented Jun 24, 2019

tesuji left a comment •

edited

Loading

tesuji Jun 24, 2019

eddyb commented Jun 24, 2019

jeremystucki commented Jun 24, 2019

eddyb commented Jun 25, 2019 •

edited

Loading

bors commented Jun 25, 2019

eddyb commented Jun 26, 2019

bors commented Jun 30, 2019

jeremystucki commented Jul 1, 2019

jeremystucki commented Jul 1, 2019

eddyb commented Jul 2, 2019

bors commented Jul 2, 2019

eddyb commented Jul 3, 2019

bors commented Jul 3, 2019

Remove needless lifetimes (rustc) #62039

Remove needless lifetimes (rustc) #62039

Conversation

jeremystucki commented Jun 21, 2019

rust-highfive commented Jun 21, 2019

bors commented Jun 22, 2019

tesuji commented Jun 23, 2019

rust-highfive commented Jun 23, 2019

bors commented Jun 24, 2019

tesuji left a comment • edited Loading

Choose a reason for hiding this comment

tesuji Jun 24, 2019

Choose a reason for hiding this comment

eddyb commented Jun 24, 2019

jeremystucki commented Jun 24, 2019

eddyb commented Jun 25, 2019 • edited Loading

bors commented Jun 25, 2019

eddyb commented Jun 26, 2019

bors commented Jun 30, 2019

jeremystucki commented Jul 1, 2019

jeremystucki commented Jul 1, 2019

eddyb commented Jul 2, 2019

bors commented Jul 2, 2019

eddyb commented Jul 3, 2019

bors commented Jul 3, 2019

tesuji left a comment •

edited

Loading

eddyb commented Jun 25, 2019 •

edited

Loading