Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the rust-installer submodule #62153

Merged
merged 1 commit into from
Jul 5, 2019

Conversation

alexcrichton
Copy link
Member

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.

@rust-highfive
Copy link
Collaborator

r? @nikomatsakis

(rust_highfive has picked a reviewer for you, use r? to override)

@rust-highfive
Copy link
Collaborator

⚠️ Warning ⚠️

  • These commits modify submodules.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Jun 26, 2019
@Mark-Simulacrum
Copy link
Member

@bors r+

@bors
Copy link
Contributor

bors commented Jun 26, 2019

📌 Commit 722cfc4 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jun 26, 2019

🌲 The tree is currently closed for pull requests below priority 999, this pull request will be tested once the tree is reopened

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Jun 26, 2019
@cuviper
Copy link
Member

cuviper commented Jun 27, 2019

What's the impact on compression ratio?

We took pains to order files such that similar files are close to each other, to hopefully enable more compression opportunities. That might be over-engineered, but I imagine some of this will be lost if it's now splitting the stream out to separate threads.

@alexcrichton
Copy link
Member Author

Randomly testing https://static.rust-lang.org/dist/rustc-nightly-x86_64-unknown-linux-gnu.tar.xz the difference is:

-rw-rw-r-- 1 alex alex 90639944 Jun 28 01:08 out.tar.xz
-rw-rw-r-- 1 alex alex 89913856 Jun 28 01:09 rustc-nightly-x86_64-unknown-linux-gnu.tar.xz

so it looks like it does increase sizes slightly, but not too much?

@cuviper
Copy link
Member

cuviper commented Jun 28, 2019

Wow, that's less than 1% increase -- seems totally fine to me!

Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
Centril added a commit to Centril/rust that referenced this pull request Jun 29, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
bors added a commit that referenced this pull request Jun 29, 2019
Rollup of 4 pull requests

Successful merges:

 - #60260 (Add support for UWP targets)
 - #62128 (Adjust warning of -C extra-filename with -o.)
 - #62153 (Update the `rust-installer` submodule)
 - #62224 (rustdoc: remove unused derives and variants)

Failed merges:

r? @ghost
Mark-Simulacrum added a commit to Mark-Simulacrum/rust that referenced this pull request Jul 3, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@Mark-Simulacrum
Copy link
Member

@bors r+ p=1

This should improve CI times a little, so let's bump it's priority up.

@bors
Copy link
Contributor

bors commented Jul 3, 2019

📌 Commit f5b2541 has been approved by Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 3, 2019

⌛ Testing commit f5b2541 with merge cc358a793c40852d72913f0c70cfa2417887ec56...

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

@bors retry rolled up.

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

@bors retry rolled up.

@bors
Copy link
Contributor

bors commented Jul 3, 2019

⌛ Testing commit f5b2541 with merge 44173d97041969fa3607ed277cbd9923287fae0d...

Centril added a commit to Centril/rust that referenced this pull request Jul 3, 2019
…ark-Simulacrum

Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

@bors retry rolled up.

bors added a commit that referenced this pull request Jul 3, 2019
Rollup of 17 pull requests

Successful merges:

 - #62039 (Remove needless lifetimes (rustc))
 - #62153 (Update the `rust-installer` submodule)
 - #62173 (rename InterpretCx -> InterpCx)
 - #62240 (wfcheck: resolve the type-vars in `AdtField` types)
 - #62249 (Use mem::take instead of mem::replace with default)
 - #62252 (Update mem::replace example to not be identical to mem::take)
 - #62258 (syntax: Unsupport `foo! bar { ... }` macros in the parser)
 - #62268 (Clean up inherent_impls)
 - #62287 (Use link attributes on extern "C" blocks with llvm-libuwind)
 - #62295 (miri realloc: do not require giving old size+align)
 - #62297 (refactor check_for_substitution)
 - #62316 (When possible without changing semantics, implement Iterator::last in terms of DoubleEndedIterator::next_back for types in liballoc and libcore.)
 - #62317 (Migrate `compile-pass` annotations to `build-pass`)
 - #62337 (Fix bucket in CPU usage script)
 - #62344 (simplify Option::get_or_insert)
 - #62346 (enable a few more tests in Miri and update the comment for others)
 - #62351 (remove bogus example from drop_in_place)

Failed merges:

r? @ghost
@bors
Copy link
Contributor

bors commented Jul 3, 2019

⌛ Testing commit f5b2541 with merge ddfdb9f34d123cd02a15d6dd5e29d5a870aa4cfc...

@Centril
Copy link
Contributor

Centril commented Jul 3, 2019

Failed in #62354 (comment), @bors r- retry

@bors bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Jul 3, 2019
This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@alexcrichton
Copy link
Member Author

@bors: r=Mark-Simulacrum

@bors
Copy link
Contributor

bors commented Jul 4, 2019

📌 Commit 2fb2e00 has been approved by Mark-Simulacrum

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Jul 4, 2019
@bors
Copy link
Contributor

bors commented Jul 4, 2019

⌛ Testing commit 2fb2e00 with merge 4ca7a34...

bors added a commit that referenced this pull request Jul 4, 2019
Update the `rust-installer` submodule

This pulls in a commit which uses parallel xz encoding which should
hopefully help shave some time off the dist builders which spend an
inordinate amount of time compressing this data.
@bors
Copy link
Contributor

bors commented Jul 5, 2019

☀️ Test successful - checks-azure, checks-travis, status-appveyor
Approved by: Mark-Simulacrum
Pushing 4ca7a34 to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jul 5, 2019
@bors bors merged commit 2fb2e00 into rust-lang:master Jul 5, 2019
@alexcrichton alexcrichton deleted the parallel-compress branch July 8, 2019 20:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants