bump rand in libcore/liballoc test suites #63261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
It seems like SmallRng was only used in tests, so that seems fine to switch to StdRng to me. @bors r+ rollup |
|
📌 Commit 0cb16f7 has been approved by |
bors
added
S-waiting-on-bors
|
Note: I have released |
|
@bors r- @newpavlov thanks! I added that here. @nikomatsakis is that okay? |
bors
added
S-waiting-on-author
RalfJung
added
S-waiting-on-review
bors
added
S-waiting-on-author
RalfJung
added
S-waiting-on-review
|
@bors r+ rollup |
|
📌 Commit 39185dd has been approved by |
bors
added
S-waiting-on-bors
pietroalbini
added a commit
to pietroalbini/rust
that referenced
this pull request
Aug 7, 2019
bump rand in libcore/liballoc test suites This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites. `SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 8, 2019
bump rand in libcore/liballoc test suites This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites. `SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 8, 2019
bump rand in libcore/liballoc test suites This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites. `SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
Centril
added a commit
to Centril/rust
that referenced
this pull request
Aug 8, 2019
bump rand in libcore/liballoc test suites This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites. `SmallRng` (formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch to `StdRng` instead. Or should I enable the feature gate?
bors
added a commit
that referenced
this pull request
Aug 8, 2019
Rollup of 8 pull requests Successful merges: - #63261 (bump rand in libcore/liballoc test suites) - #63316 (Update rustfmt to 1.4.4) - #63332 (Add an overflow check in truncate implementation for Unix.) - #63342 (Don't use remap-path-prefix in dep-info files.) - #63366 (doc: Fix typo in float from bytes methods) - #63370 (Fix ICE #63364) - #63377 (Improved documentation for compile_error!()) - #63379 (Add test for issue 53096) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls in the fix for rust-random/rand#779, which trips Miri when running these test suites.
SmallRng(formerly used by libcore) is no longer built by default, it needs a feature gate. I opted to switch toStdRnginstead. Or should I enable the feature gate?