Skip to content

Fix ICE #63364 #63370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 8, 2019
Merged

Fix ICE #63364 #63370

merged 1 commit into from
Aug 8, 2019

Conversation

JohnTitor
Copy link
Member

Fixes #63364

r? @estebank cc @varkor

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Aug 8, 2019
@varkor
Copy link
Member

varkor commented Aug 8, 2019

@bors r+ rollup

@bors
Copy link
Collaborator

bors commented Aug 8, 2019

📌 Commit e2b3543 has been approved by varkor

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Aug 8, 2019
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Centril added a commit to Centril/rust that referenced this pull request Aug 8, 2019

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
bors added a commit that referenced this pull request Aug 8, 2019
Rollup of 8 pull requests

Successful merges:

 - #63261 (bump rand in libcore/liballoc test suites)
 - #63316 (Update rustfmt to 1.4.4)
 - #63332 (Add an overflow check in truncate implementation for Unix.)
 - #63342 (Don't use remap-path-prefix in dep-info files.)
 - #63366 (doc: Fix typo in float from bytes methods)
 - #63370 (Fix ICE #63364)
 - #63377 (Improved documentation for compile_error!())
 - #63379 (Add test for issue 53096)

Failed merges:

r? @ghost
@bors bors merged commit e2b3543 into rust-lang:master Aug 8, 2019
@JohnTitor JohnTitor deleted the fix-ice-63364 branch August 8, 2019 21:20
@estebank estebank added beta-nominated Nominated for backporting to the compiler in the beta channel. stable-nominated Nominated for backporting to the compiler in the stable channel. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue. labels Aug 8, 2019
@pietroalbini
Copy link
Member

Ping @rust-lang/compiler, do y'all want to backport this to the beta branch?

I'm removing the stable nomination myself as 1.37 is going to be released next week and there won't surely be a point release with just this.

@rustbot modify labels: -stable-nominated

@rustbot rustbot removed the stable-nominated Nominated for backporting to the compiler in the stable channel. label Aug 9, 2019
@Mark-Simulacrum Mark-Simulacrum removed the beta-nominated Nominated for backporting to the compiler in the beta channel. label Aug 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. T-compiler Relevant to the compiler team, which will review and decide on the PR/issue.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

ICE when iterating over a u16 range whose bounds exceed 64k
8 participants