-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added table containing the system calls used by Instant and SystemTime. #63846
Added table containing the system calls used by Instant and SystemTime. #63846
Conversation
r? @rkruppe (rust_highfive has picked a reviewer for you, use r? to override) |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for the PR! There seem to be a few mistakes in these tables, could you please correct them and also apply the out-of-line link style suggested by @lzutao to all the links in the tables?
Co-Authored-By: lzutao <taolzu@gmail.com>
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
I have a busy week upcoming, but I hope to fix all the suggestions next week! |
Thanks for the triage! I wanted to work on this but unfortunately something went wrong when swapping Internet subscriptions here... So I have been without since last monday but they hope to fix it next monday. So once again unfortunately!: I hope to fix it next week! |
I hope these changes do the trick! Some URLs are so long that they still bypass the checks though... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Co-Authored-By: Robin Kruppe <robin.kruppe@gmail.com>
Great, CI is green now. Thanks again for working on this :) @bors r+ rollup |
📌 Commit b3b6713 has been approved by |
No probs! I tried my best! I wish I had more time to work on things like this :) |
…alls, r=rkruppe Added table containing the system calls used by Instant and SystemTime. # Description See rust-lang#32626 for a discussion on documenting system calls used by Instant and SystemTime. ## Changes - Added a table containing the system calls used by each platform. EDIT: If I can format this table better (due to the large links) please let me know. I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: `python x.py doc --stage 0 src/libstd` but that gives me some `unrecognized intrinsic` errors. Advice is always welcome :) closes rust-lang#32626
…alls, r=rkruppe Added table containing the system calls used by Instant and SystemTime. # Description See rust-lang#32626 for a discussion on documenting system calls used by Instant and SystemTime. ## Changes - Added a table containing the system calls used by each platform. EDIT: If I can format this table better (due to the large links) please let me know. I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using: `python x.py doc --stage 0 src/libstd` but that gives me some `unrecognized intrinsic` errors. Advice is always welcome :) closes rust-lang#32626
Rollup of 17 pull requests Successful merges: - #63846 (Added table containing the system calls used by Instant and SystemTime.) - #64116 (Fix minor typo in docs.) - #64203 (A few cosmetic improvements to code & comments in liballoc and libcore) - #64302 (Shrink `ObligationCauseCode`) - #64372 (use randSecure and randABytes) - #64374 (Box `DiagnosticBuilder`.) - #64375 (Fast path for vec.clear/truncate ) - #64378 (Fix inconsistent link formatting.) - #64384 (Trim rustc-workspace-hack) - #64393 ( declare EnvKey before use to fix build error) - #64420 (Inline `mark_neighbours_as_waiting_from`.) - #64422 (Remove raw string literal quotes from error index descriptions) - #64423 (Add self to .mailmap) - #64425 (typo fix) - #64431 (fn ptr is structural match) - #64435 (codegen: use "_N" (like for other locals) instead of "argN", for argument names.) - #64439 (fix #64430, confusing `owned_box` error message in no_std build) Failed merges: r? @ghost
Description
See #32626 for a discussion on documenting system calls used by Instant and SystemTime.
Changes
EDIT: If I can format this table better (due to the large links) please let me know.
I'd also be happy to learn a quick command to generate the docs on my host machine! Currently I am using:
python x.py doc --stage 0 src/libstd
but that gives me someunrecognized intrinsic
errors. Advice is always welcome :)closes #32626