Stabilize nested self receivers in 1.41.0 #64325

cramertj · 2019-09-09T22:32:21Z

Previously, only Self, &Self, &mut Self, Arc<Self>, Rc<Self>,
and Box<Self> were available as stable method receivers.

This commit stabilizes nested uses of all the above types.
However, nested receivers remain non-object-safe.

rust-highfive · 2019-09-09T22:32:25Z

r? @zackmdavis

(rust_highfive has picked a reviewer for you, use r? to override)

src/librustc_typeck/check/wfcheck.rs

src/test/ui/self/arbitrary_self_types_nested.rs

src/librustc_typeck/check/wfcheck.rs

zackmdavis · 2019-09-14T02:38:13Z

(going through my review debt now; since Centril has already stepped up to comment in depth, I hope it's OK if I abdicate reviewer status on this one)

r? @Centril

Centril · 2019-09-14T11:23:55Z

I'm gonna pass the torch to @mikeyhew since this is the first time I've read this code. ;)

Centril · 2019-09-14T11:24:40Z

Forgot to actually do that... 😅

r? @mikeyhew

Centril · 2019-09-14T11:27:06Z

I guess they cannot be assigned... assigning to @nikomatsakis who reviewed #56805 and also cc @arielb1 who reviewed #45870.

r? @nikomatsakis

mikeyhew

I thought I'd take a look anyway. LGTM

src/librustc_typeck/check/wfcheck.rs

Centril · 2019-09-18T18:44:16Z

I'm gonna move this over to r? @arielb1 to reduce Niko's reviewer load.

rust-highfive · 2019-11-27T04:51:18Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-11-27T03:59:58.2821125Z 
2019-11-27T03:59:58.2821158Z 
2019-11-27T03:59:58.3398907Z kill: 1585: No such process
2019-11-27T03:59:58.3413319Z kill: 1584: No such process
2019-11-27T04:43:59.9503756Z Chocolatey timed out waiting for the command to finish. The timeout 
2019-11-27T04:43:59.9504617Z  specified (or the default value) was '2700' seconds. Perhaps try a 
2019-11-27T04:44:00.7718160Z  higher `--execution-timeout`? See `choco -h` for details.
2019-11-27T04:44:00.7718324Z The install of msys2 was NOT successful.
2019-11-27T04:44:00.7835065Z Error while running 'C:\ProgramData\chocolatey\lib\msys2\tools\chocolateyinstall.ps1'.
2019-11-27T04:44:00.7835263Z  See log for details.
2019-11-27T04:44:02.8558202Z Chocolatey installed 0/1 packages. 1 packages failed.
2019-11-27T04:44:02.8558774Z  See the log for details (C:\ProgramData\chocolatey\logs\chocolatey.log).
2019-11-27T04:44:02.8563110Z 
2019-11-27T04:44:02.8568417Z Failures
2019-11-27T04:44:02.8568417Z Failures
2019-11-27T04:44:02.8575332Z  - msys2 (exited -1) - Error while running 'C:\ProgramData\chocolatey\lib\msys2\tools\chocolateyinstall.ps1'.
2019-11-27T04:44:02.8576029Z  See log for details.
2019-11-27T04:44:13.3527501Z The STDIO streams did not close within 10 seconds of the exit event from process 'C:\Program Files\Git\bin\bash.exe'. This may indicate a child process inherited the STDIO streams and has not yet exited.
2019-11-27T04:44:13.3604047Z ##[error]Bash exited with code '127'.
2019-11-27T04:44:18.3772442Z ##[section]Starting: Checkout
2019-11-27T04:44:18.9947847Z ==============================================================================
2019-11-27T04:44:18.9947989Z Task         : Get sources
2019-11-27T04:44:18.9948086Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

bors · 2019-11-27T04:51:25Z

💔 Test failed - checks-azure

cramertj · 2019-11-27T17:56:07Z

The build was cancelled by Alex Crichton.

@alexcrichton

Centril · 2019-11-27T18:41:24Z

@bors retry looks spurious.

@cramertj that's just Alex's token, he didn't do that manually.

bors · 2019-11-27T21:00:39Z

⌛ Testing commit 2083e2a with merge b34d4ca761270292a51f2c8e9ea2ac94422c5cbf...

Stabilize nested self receivers in 1.41.0 Previously, only `Self`, `&Self`, `&mut Self`, `Arc<Self>`, `Rc<Self>`, and `Box<Self>` were available as stable method receivers. This commit stabilizes nested uses of all the above types. However, nested receivers remain non-object-safe.

tmandry · 2019-11-27T21:30:07Z

@bors retry rolled up

@steveklabnik

Rollup of 17 pull requests Successful merges: - #64325 (Stabilize nested self receivers in 1.41.0) - #66222 (Use `eq_opaque_type_and_type` when type-checking closure signatures) - #66305 (Add by-value arrays to `improper_ctypes` lint) - #66399 (rustc_metadata: simplify the interactions between Lazy and Table.) - #66534 (Allow global references via ForeignItem and Item for the same symbol name during LLVM codegen) - #66700 (Fix pointing at arg for fulfillment errors in function calls) - #66704 (Intra doc enum variant field) - #66718 (Refactor `parse_enum_item` to use `parse_delim_comma_seq`) - #66722 (Handle non_exhaustive in borrow checking) - #66744 (Fix shrink_to panic documentation) - #66761 (Use LLVMDisposePassManager instead of raw delete in rustllvm) - #66769 (Add core::{f32,f64}::consts::TAU.) - #66774 (Clean up error codes) - #66777 (Put back tidy check on error codes) - #66797 (Fixes small typo in array docs r? @steveklabnik) - #66798 (Fix spelling typos) - #66800 (Combine similar tests for const match) Failed merges: r? @ghost

bors · 2019-11-28T00:37:05Z

☔ The latest upstream changes (presumably #66824) made this pull request unmergeable. Please resolve the merge conflicts.

manuthambi · 2020-02-11T17:19:44Z

Seems like lifetime elision doesn't work quite right with nested self receivers. The error messages are also misleading. Of course this can be worked around by providing the annotation in the code.

https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=c5630a9a5637fbdd1151cea7effb2e60

Version 1.41.0 (2020-01-30) =========================== Language -------- - [You can now pass type parameters to foreign items when implementing traits.][65879] E.g. You can now write `impl<T> From<Foo> for Vec<T> {}`. - [You can now arbitrarily nest receiver types in the `self` position.][64325] E.g. you can now write `fn foo(self: Box<Box<Self>>) {}`. Previously only `Self`, `&Self`, `&mut Self`, `Arc<Self>`, `Rc<Self>`, and `Box<Self>` were allowed. - [You can now use any valid identifier in a `format_args` macro.][66847] Previously identifiers starting with an underscore were not allowed. - [Visibility modifiers (e.g. `pub`) are now syntactically allowed on trait items and enum variants.][66183] These are still rejected semantically, but can be seen and parsed by procedural macros and conditional compilation. Compiler -------- - [Rustc will now warn if you have unused loop `'label`s.][66325] - [Removed support for the `i686-unknown-dragonfly` target.][67255] - [Added tier 3 support\* for the `riscv64gc-unknown-linux-gnu` target.][66661] - [You can now pass an arguments file passing the `@path` syntax to rustc.][66172] Note that the format differs somewhat from what is found in other tooling; please see [the documentation][argfile-docs] for more information. - [You can now provide `--extern` flag without a path, indicating that it is available from the search path or specified with an `-L` flag.][64882] \* Refer to Rust's [platform support page][forge-platform-support] for more information on Rust's tiered platform support. [argfile-docs]: https://doc.rust-lang.org/nightly/rustc/command-line-arguments.html#path-load-command-line-flags-from-a-path Libraries --------- - [The `core::panic` module is now stable.][66771] It was already stable through `std`. - [`NonZero*` numerics now implement `From<NonZero*>` if it's a smaller integer width.][66277] E.g. `NonZeroU16` now implements `From<NonZeroU8>`. - [`MaybeUninit<T>` now implements `fmt::Debug`.][65013] Stabilized APIs --------------- - [`Result::map_or`] - [`Result::map_or_else`] - [`std::rc::Weak::weak_count`] - [`std::rc::Weak::strong_count`] - [`std::sync::Weak::weak_count`] - [`std::sync::Weak::strong_count`] Cargo ----- - [Cargo will now document all the private items for binary crates by default.][cargo/7593] - [`cargo-install` will now reinstall the package if it detects that it is out of date.][cargo/7560] - [Cargo.lock now uses a more git friendly format that should help to reduce merge conflicts.][cargo/7579] - [You can now override specific dependencies's build settings][cargo/7591] E.g. `[profile.dev.overrides.image] opt-level = 2` sets the `image` crate's optimisation level to `2` for debug builds. You can also use `[profile.<profile>.build_overrides]` to override build scripts and their dependencies. Misc ---- - [You can now specify `edition` in documentation code blocks to compile the block for that edition.][66238] E.g. `edition2018` tells rustdoc that the code sample should be compiled the 2018 edition of Rust. - [You can now provide custom themes to rustdoc with `--theme`, and check the current theme with `--check-theme`.][54733] - [You can use `#[cfg(doc)]` to compile an item when building documentation.][61351] Compatibility Notes ------------------- - [As previously announced 1.41.0 will be the last tier 1 release for 32-bit Apple targets.][apple-32bit-drop] This means that the source code is still available to build, but the targets are no longer being tested and release binaries for those platforms will no longer be distributed by the Rust project. Please refer to the linked blog post for more information. [54733]: rust-lang/rust#54733 [61351]: rust-lang/rust#61351 [67255]: rust-lang/rust#67255 [66661]: rust-lang/rust#66661 [66771]: rust-lang/rust#66771 [66847]: rust-lang/rust#66847 [66238]: rust-lang/rust#66238 [66277]: rust-lang/rust#66277 [66325]: rust-lang/rust#66325 [66172]: rust-lang/rust#66172 [66183]: rust-lang/rust#66183 [65879]: rust-lang/rust#65879 [65013]: rust-lang/rust#65013 [64882]: rust-lang/rust#64882 [64325]: rust-lang/rust#64325 [cargo/7560]: rust-lang/cargo#7560 [cargo/7579]: rust-lang/cargo#7579 [cargo/7591]: rust-lang/cargo#7591 [cargo/7593]: rust-lang/cargo#7593 [`Result::map_or_else`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or_else [`Result::map_or`]: https://doc.rust-lang.org/std/result/enum.Result.html#method.map_or [`std::rc::Weak::weak_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.weak_count [`std::rc::Weak::strong_count`]: https://doc.rust-lang.org/std/rc/struct.Weak.html#method.strong_count [`std::sync::Weak::weak_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.weak_count [`std::sync::Weak::strong_count`]: https://doc.rust-lang.org/std/sync/struct.Weak.html#method.strong_count [apple-32bit-drop]: https://blog.rust-lang.org/2020/01/03/reducing-support-for-32-bit-apple-targets.html

Ralith · 2021-10-12T18:25:33Z

Is there any work ongoing to make these object-safe?

rust-highfive assigned zackmdavis Sep 9, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Sep 9, 2019

cramertj added T-lang Relevant to the language team, which will review and decide on the PR/issue. relnotes Marks issues that should be documented in the release notes of the next release. labels Sep 9, 2019

Centril reviewed Sep 9, 2019

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

src/librustc_typeck/check/wfcheck.rs Show resolved Hide resolved

src/librustc_typeck/check/wfcheck.rs Outdated Show resolved Hide resolved

src/test/ui/self/arbitrary_self_types_nested.rs Show resolved Hide resolved

cramertj force-pushed the nested-self-types branch from 0e077b0 to 4355661 Compare September 9, 2019 23:21

cramertj mentioned this pull request Sep 9, 2019

Add take_... functions to slices #62282

Closed

Centril reviewed Sep 9, 2019

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Show resolved Hide resolved

taiki-e mentioned this pull request Sep 11, 2019

Tracking issue for pin-project 0.4 taiki-e/pin-project#21

Closed

11 tasks

cramertj mentioned this pull request Sep 11, 2019

ManuallyDrop should be a dyn-compatible receiver type #64351

Open

This comment has been minimized.

Sign in to view

rust-highfive assigned Centril and unassigned zackmdavis Sep 14, 2019

Centril added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Sep 14, 2019

rust-highfive assigned nikomatsakis and unassigned Centril Sep 14, 2019

mikeyhew approved these changes Sep 15, 2019

View reviewed changes

src/librustc_typeck/check/wfcheck.rs Show resolved Hide resolved

jonas-schievink added this to the 1.39 milestone Sep 15, 2019

rust-highfive assigned arielb1 and unassigned nikomatsakis Sep 18, 2019

bors added S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 27, 2019

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 27, 2019

tmandry mentioned this pull request Nov 27, 2019

Rollup of 17 pull requests #66824

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Nov 28, 2019

bors merged commit 2083e2a into rust-lang:master Nov 28, 2019

cramertj deleted the nested-self-types branch November 28, 2019 01:22

ehuss mentioned this pull request Nov 30, 2019

Update for nested receivers. rust-lang/reference#724

Merged

manuthambi mentioned this pull request Feb 11, 2020

Lifetime elision doesn't work right with nested self receivers. #69064

Open

jonhoo mentioned this pull request Feb 19, 2020

013 rustacean-station/rustacean-station.org#33

Merged

tertsdiepraam mentioned this pull request Apr 19, 2021

Optimize recursive ls uutils/coreutils#2083

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Stabilize nested self receivers in 1.41.0 #64325

Stabilize nested self receivers in 1.41.0 #64325

cramertj commented Sep 9, 2019 •

edited by Centril

Loading

rust-highfive commented Sep 9, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zackmdavis commented Sep 14, 2019

Centril commented Sep 14, 2019

Centril commented Sep 14, 2019

Centril commented Sep 14, 2019

mikeyhew left a comment

Centril commented Sep 18, 2019

rust-highfive commented Nov 27, 2019

bors commented Nov 27, 2019

cramertj commented Nov 27, 2019

Centril commented Nov 27, 2019

bors commented Nov 27, 2019

tmandry commented Nov 27, 2019

bors commented Nov 28, 2019

manuthambi commented Feb 11, 2020

Ralith commented Oct 12, 2021

Stabilize nested self receivers in 1.41.0 #64325

Stabilize nested self receivers in 1.41.0 #64325

Conversation

cramertj commented Sep 9, 2019 • edited by Centril Loading

rust-highfive commented Sep 9, 2019

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

This comment has been minimized.

zackmdavis commented Sep 14, 2019

Centril commented Sep 14, 2019

Centril commented Sep 14, 2019

Centril commented Sep 14, 2019

mikeyhew left a comment

Choose a reason for hiding this comment

Centril commented Sep 18, 2019

rust-highfive commented Nov 27, 2019

bors commented Nov 27, 2019

cramertj commented Nov 27, 2019

Centril commented Nov 27, 2019

bors commented Nov 27, 2019

tmandry commented Nov 27, 2019

bors commented Nov 28, 2019

manuthambi commented Feb 11, 2020

Ralith commented Oct 12, 2021

cramertj commented Sep 9, 2019 •

edited by Centril

Loading