-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix suggestion to constrain trait for method to be found #65242
Conversation
r? @varkor (rust_highfive has picked a reviewer for you, use r? to override) |
} | ||
_ => { | ||
has_bounds = !param.bounds.is_empty(); | ||
debug!("suggest_traits_to_import {:?} {:?}", hir.get(id), generics); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The current method is getting rather large; would be good to subdivide things.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I feel that splitting this method would lead to with smaller methods with too many arguments, beyond the point for to be worth it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That suggests that a struct should be invented to carry the additional state.
☔ The latest upstream changes (presumably #65322) made this pull request unmergeable. Please resolve the merge conflicts. |
Looks good. r=me with spelling fix. |
57f456e
to
dee53d7
Compare
Rebased. @bors r=varkor |
📌 Commit dee53d7 has been approved by |
Fix suggestion to constrain trait for method to be found Fix rust-lang#65044.
Fix suggestion to constrain trait for method to be found Fix rust-lang#65044.
Rollup of 14 pull requests Successful merges: - #64603 (Reducing spurious unused lifetime warnings.) - #64623 (Remove last uses of gensyms) - #65235 (don't assume we can *always* find a return type hint in async fn) - #65242 (Fix suggestion to constrain trait for method to be found) - #65265 (Cleanup librustc mir err codes) - #65293 (Optimize `try_expand_impl_trait_type`) - #65307 (Try fix incorrect "explicit lifetime name needed") - #65308 (Add long error explanation for E0574) - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members) - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.) - #65402 (Add troubleshooting section to PGO chapter in rustc book.) - #65425 (Optimize `BitIter`) - #65438 (Organize `never_type` tests) - #65444 (Implement AsRef<[T]> for List<T>) Failed merges: - #65390 (Add long error explanation for E0576) r? @ghost
Fix #65044.