Try fix incorrect "explicit lifetime name needed" #65307

Phosphorus15 · 2019-10-11T12:20:04Z

This pr is trying to fixes #65285 .

rust-highfive · 2019-10-11T12:20:07Z

r? @cramertj

(rust_highfive has picked a reviewer for you, use r? to override)

Phosphorus15 · 2019-10-11T12:33:09Z

r? @varkor maybe?

varkor · 2019-10-11T14:32:25Z

Can you add a test with the new diagnostic?

Phosphorus15 · 2019-10-11T15:15:20Z

Sure yes, there ought to be a test correspond to this issue.

Phosphorus15 · 2019-10-12T10:16:55Z

It seems enough to solve this issue, please review 😃

varkor · 2019-10-13T15:08:40Z

src/librustc/hir/lowering.rs

+    /// Refer to issue #65285
+    /// return a "error lifetime".
+    fn new_missing_lifetime(&mut self, id: Option<NodeId>, span: Span) -> hir::Lifetime {
+        match id {


This could be if id.is_some() { … }.

varkor · 2019-10-13T15:21:09Z

src/librustc/hir/lowering.rs

@@ -3284,7 +3295,7 @@ impl<'a> LoweringContext<'a> {
            // This is the normal case.
            AnonymousLifetimeMode::PassThrough => self.new_implicit_lifetime(span),

-            AnonymousLifetimeMode::ReportError => self.new_error_lifetime(None, span),
+            AnonymousLifetimeMode::ReportError => self.new_missing_lifetime(None, span),


This is always called with None, so you might as well just use new_implicit_lifetime here, no?

Well, shame of me. Thanks for pointing out XD

varkor · 2019-10-14T12:53:35Z

src/librustc/hir/lowering.rs

@@ -3283,8 +3283,10 @@ impl<'a> LoweringContext<'a> {
            }
            // This is the normal case.
            AnonymousLifetimeMode::PassThrough => self.new_implicit_lifetime(span),
-
-            AnonymousLifetimeMode::ReportError => self.new_error_lifetime(None, span),
+            // elide the lifetime parameter (if possible) for the lifetime resolver to check


It's not clear to me from this comment why this change works. Could you try to elaborate what this does in your comment?

rust-highfive · 2019-10-14T14:14:17Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-14T13:55:00.0675543Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-14T13:55:00.1169025Z ##[command]git config gc.auto 0
2019-10-14T13:55:00.1203668Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-14T13:55:00.1255141Z ##[command]git config --get-all http.proxy
2019-10-14T13:55:00.1389624Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65307/merge:refs/remotes/pull/65307/merge
---
2019-10-14T14:01:29.7202354Z    Compiling serde_json v1.0.40
2019-10-14T14:01:31.4379471Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-14T14:01:42.6096955Z     Finished release [optimized] target(s) in 1m 27s
2019-10-14T14:01:42.6171282Z tidy check
2019-10-14T14:01:43.3193873Z tidy error: /checkout/src/librustc/hir/lowering.rs:3297: line longer than 100 chars
2019-10-14T14:01:43.3194075Z tidy error: /checkout/src/librustc/hir/lowering.rs:3298: line longer than 100 chars
2019-10-14T14:01:43.3194121Z tidy error: /checkout/src/librustc/hir/lowering.rs:3299: line longer than 100 chars
2019-10-14T14:01:43.3194181Z tidy error: /checkout/src/librustc/hir/lowering.rs:3300: line longer than 100 chars
2019-10-14T14:01:44.6577604Z Found 482 error codes
2019-10-14T14:01:44.6577900Z Found 0 error codes with no tests
2019-10-14T14:01:44.6581925Z Done!
2019-10-14T14:01:44.6582206Z some tidy checks failed
2019-10-14T14:01:44.6582206Z some tidy checks failed
2019-10-14T14:01:44.6582252Z 
2019-10-14T14:01:44.6582274Z 
2019-10-14T14:01:44.6583465Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-14T14:01:44.6583695Z 
2019-10-14T14:01:44.6583716Z 
2019-10-14T14:01:44.6583805Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-14T14:01:44.6583846Z Build completed unsuccessfully in 0:01:31
2019-10-14T14:01:44.6583846Z Build completed unsuccessfully in 0:01:31
2019-10-14T14:01:44.6627303Z == clock drift check ==
2019-10-14T14:01:44.6644847Z   local time: Mon Oct 14 14:01:44 UTC 2019
2019-10-14T14:01:44.7608054Z   network time: Mon, 14 Oct 2019 14:01:44 GMT
2019-10-14T14:01:44.7615251Z == end clock drift check ==
2019-10-14T14:01:45.6525208Z ##[error]Bash exited with code '1'.
2019-10-14T14:01:45.6677724Z ##[section]Starting: Checkout
2019-10-14T14:01:45.6679480Z ==============================================================================
2019-10-14T14:01:45.6679540Z Task         : Get sources
2019-10-14T14:01:45.6679580Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

src/librustc/hir/lowering.rs

varkor · 2019-10-14T14:17:57Z

r=me with comment suggestion and squashing the commits.

rust-highfive · 2019-10-14T15:11:01Z

The job x86_64-gnu-llvm-6.0 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-14T14:51:56.1422827Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-14T14:51:56.1531249Z ##[command]git config gc.auto 0
2019-10-14T14:51:56.1615446Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-14T14:51:56.1674274Z ##[command]git config --get-all http.proxy
2019-10-14T14:51:56.1849625Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65307/merge:refs/remotes/pull/65307/merge
---
2019-10-14T14:58:09.7838720Z    Compiling serde_json v1.0.40
2019-10-14T14:58:11.7817399Z    Compiling tidy v0.1.0 (/checkout/src/tools/tidy)
2019-10-14T14:58:24.3443050Z     Finished release [optimized] target(s) in 1m 36s
2019-10-14T14:58:24.3524722Z tidy check
2019-10-14T14:58:25.1209972Z tidy error: /checkout/src/librustc/hir/lowering.rs:3300: trailing whitespace
2019-10-14T14:58:26.7715847Z some tidy checks failed
2019-10-14T14:58:26.7716009Z Found 482 error codes
2019-10-14T14:58:26.7716058Z Found 0 error codes with no tests
2019-10-14T14:58:26.7716102Z Done!
2019-10-14T14:58:26.7716102Z Done!
2019-10-14T14:58:26.7716131Z 
2019-10-14T14:58:26.7716176Z 
2019-10-14T14:58:26.7718096Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/tidy" "/checkout/src" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "--no-vendor"
2019-10-14T14:58:26.7718253Z 
2019-10-14T14:58:26.7718279Z 
2019-10-14T14:58:26.7718327Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test src/tools/tidy
2019-10-14T14:58:26.7718407Z Build completed unsuccessfully in 0:01:40
2019-10-14T14:58:26.7718407Z Build completed unsuccessfully in 0:01:40
2019-10-14T14:58:26.7763841Z == clock drift check ==
2019-10-14T14:58:26.7777766Z   local time: Mon Oct 14 14:58:26 UTC 2019
2019-10-14T14:58:26.9274879Z   network time: Mon, 14 Oct 2019 14:58:26 GMT
2019-10-14T14:58:26.9279791Z == end clock drift check ==
2019-10-14T14:58:27.7247259Z ##[error]Bash exited with code '1'.
2019-10-14T14:58:27.7294733Z ##[section]Starting: Checkout
2019-10-14T14:58:27.7296516Z ==============================================================================
2019-10-14T14:58:27.7296572Z Task         : Get sources
2019-10-14T14:58:27.7296620Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2019-10-14T17:20:34Z

Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2019-10-14T15:20:01.4693733Z ##[command]git remote add origin https://github.com/rust-lang/rust
2019-10-14T15:20:01.4805184Z ##[command]git config gc.auto 0
2019-10-14T15:20:01.4877095Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2019-10-14T15:20:01.4939132Z ##[command]git config --get-all http.proxy
2019-10-14T15:20:01.5086379Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/65307/merge:refs/remotes/pull/65307/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

varkor

Why remove the full stop here?

Phosphorus15 · 2019-10-15T10:13:57Z

Why remove the full stop here?

There were something wrong with CI, and I just tried to trigger the re-run by a commit, I'll revert this change

varkor · 2019-10-15T13:45:23Z

In the future, you can trigger the CI to restart by amending the last commit and force-pushing.

If you could squash your commits into a single commit, I'll approve the PR :)

add test to for the fix add descriptive text for the fix simplified code logics update descriptive comments update to cope with the tidyness requirement merged commit suggestions Co-Authored-By: varkor <github@varkor.com> truncated redundant comments update to cope with tidy-check

Phosphorus15 · 2019-10-15T14:10:13Z

Thanks a lot 🎁 , I'm somewhat new to the rust community and you've helped me greatly.

varkor · 2019-10-15T14:35:41Z

Thanks for your work on this issue!

@bors r+ rollup

bors · 2019-10-15T14:35:43Z

📌 Commit 53187c5 has been approved by varkor

Try fix incorrect "explicit lifetime name needed" This pr is trying to fixes rust-lang#65285 .

@ghost

Rollup of 14 pull requests Successful merges: - #64603 (Reducing spurious unused lifetime warnings.) - #64623 (Remove last uses of gensyms) - #65235 (don't assume we can *always* find a return type hint in async fn) - #65242 (Fix suggestion to constrain trait for method to be found) - #65265 (Cleanup librustc mir err codes) - #65293 (Optimize `try_expand_impl_trait_type`) - #65307 (Try fix incorrect "explicit lifetime name needed") - #65308 (Add long error explanation for E0574) - #65353 (save-analysis: Don't ICE when resolving qualified type paths in struct members) - #65389 (Return `false` from `needs_drop` for all zero-sized arrays.) - #65402 (Add troubleshooting section to PGO chapter in rustc book.) - #65425 (Optimize `BitIter`) - #65438 (Organize `never_type` tests) - #65444 (Implement AsRef<[T]> for List<T>) Failed merges: - #65390 (Add long error explanation for E0576) r? @ghost

rust-highfive assigned cramertj Oct 11, 2019

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 11, 2019

rust-highfive assigned varkor and unassigned cramertj Oct 11, 2019

varkor reviewed Oct 13, 2019

View reviewed changes

varkor reviewed Oct 14, 2019

View reviewed changes

src/librustc/hir/lowering.rs Outdated Show resolved Hide resolved

Phosphorus15 force-pushed the master branch from 4699e99 to 50bc3df Compare October 14, 2019 14:51

varkor reviewed Oct 15, 2019

View reviewed changes

Phosphorus15 force-pushed the master branch from 80c11f2 to 25c06ad Compare October 15, 2019 10:17

Phosphorus15 force-pushed the master branch from 25c06ad to 53187c5 Compare October 15, 2019 14:03

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Oct 15, 2019

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019

Rollup merge of rust-lang#65307 - Phosphorus15:master, r=varkor

077a26a

Try fix incorrect "explicit lifetime name needed" This pr is trying to fixes rust-lang#65285 .

Centril mentioned this pull request Oct 15, 2019

Rollup of 9 pull requests #65449

Closed

Centril added a commit to Centril/rust that referenced this pull request Oct 15, 2019

Rollup merge of rust-lang#65307 - Phosphorus15:master, r=varkor

2abce06

Try fix incorrect "explicit lifetime name needed" This pr is trying to fixes rust-lang#65285 .

Centril mentioned this pull request Oct 15, 2019

Rollup of 8 pull requests #65451

Closed

tmandry added a commit to tmandry/rust that referenced this pull request Oct 15, 2019

Rollup merge of rust-lang#65307 - Phosphorus15:master, r=varkor

ff9b99d

Try fix incorrect "explicit lifetime name needed" This pr is trying to fixes rust-lang#65285 .

tmandry mentioned this pull request Oct 15, 2019

Rollup of 14 pull requests #65454

Merged

bors merged commit 53187c5 into rust-lang:master Oct 16, 2019

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Try fix incorrect "explicit lifetime name needed" #65307

Try fix incorrect "explicit lifetime name needed" #65307

Phosphorus15 commented Oct 11, 2019 •

edited

Loading

rust-highfive commented Oct 11, 2019

Phosphorus15 commented Oct 11, 2019

varkor commented Oct 11, 2019

Phosphorus15 commented Oct 11, 2019

Phosphorus15 commented Oct 12, 2019 •

edited

Loading

varkor Oct 13, 2019

varkor Oct 13, 2019

Phosphorus15 Oct 13, 2019

varkor Oct 14, 2019

rust-highfive commented Oct 14, 2019

varkor commented Oct 14, 2019

rust-highfive commented Oct 14, 2019

rust-highfive commented Oct 14, 2019

varkor left a comment

Phosphorus15 commented Oct 15, 2019

varkor commented Oct 15, 2019

Phosphorus15 commented Oct 15, 2019

varkor commented Oct 15, 2019

bors commented Oct 15, 2019

Try fix incorrect "explicit lifetime name needed" #65307

Try fix incorrect "explicit lifetime name needed" #65307

Conversation

Phosphorus15 commented Oct 11, 2019 • edited Loading

rust-highfive commented Oct 11, 2019

Phosphorus15 commented Oct 11, 2019

varkor commented Oct 11, 2019

Phosphorus15 commented Oct 11, 2019

Phosphorus15 commented Oct 12, 2019 • edited Loading

varkor Oct 13, 2019

Choose a reason for hiding this comment

varkor Oct 13, 2019

Choose a reason for hiding this comment

Phosphorus15 Oct 13, 2019

Choose a reason for hiding this comment

varkor Oct 14, 2019

Choose a reason for hiding this comment

rust-highfive commented Oct 14, 2019

varkor commented Oct 14, 2019

rust-highfive commented Oct 14, 2019

rust-highfive commented Oct 14, 2019

varkor left a comment

Choose a reason for hiding this comment

Phosphorus15 commented Oct 15, 2019

varkor commented Oct 15, 2019

Phosphorus15 commented Oct 15, 2019

varkor commented Oct 15, 2019

bors commented Oct 15, 2019

Phosphorus15 commented Oct 11, 2019 •

edited

Loading

Phosphorus15 commented Oct 12, 2019 •

edited

Loading