move parse_cfgspecs to rustc_interface
#65595
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Centril
commented
Oct 19, 2019
| use crate::session::search_paths::SearchPath; | ||
| extern crate getopts; | ||
|
|
||
| use crate::interface::parse_cfgspecs; |
There was a problem hiding this comment.
(This file has to be moved because of this dependency.)
|
r=me if this strictly moves the code (no changes) -- it's practically impossible to tell if this is the case, though it seems to be. |
|
For the future the best way I know of to make this sort of change reviewable is to have one commit which prepares and is strictly a move and then a second commit which fixes up the previous one -- this way the diff can be reviewed as strictly the fixup changes. |
Mark-Simulacrum
added
the
S-waiting-on-author
|
@bors r=Mark-Simulacrum |
|
📌 Commit d945f98 has been approved by |
bors
added
S-waiting-on-bors
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 19, 2019
move `parse_cfgspecs` to `rustc_interface` Part of rust-lang#65324. r? @Mark-Simulacrum
Centril
added a commit
to Centril/rust
that referenced
this pull request
Oct 20, 2019
move `parse_cfgspecs` to `rustc_interface` Part of rust-lang#65324. r? @Mark-Simulacrum
bors
added a commit
that referenced
this pull request
Oct 20, 2019
Rollup of 6 pull requests Successful merges: - #64996 (Inline `ptr::null(_mut)` even in debug builds) - #65551 (Avoid realloc in `CString::new`) - #65593 (add test for calling non-const fn) - #65595 (move `parse_cfgspecs` to `rustc_interface`) - #65600 (Remove unneeded `ref` from docs) - #65602 (Fix plural mistake in emitter.rs) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #65324.
r? @Mark-Simulacrum