-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Suggest to add lifetime constraint at explicit ouput of functions #65730
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
r? @nikomatsakis for review or reassignment |
983a663
to
545da64
Compare
This comment has been minimized.
This comment has been minimized.
545da64
to
ed3c0b8
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good! One suggestion
src/librustc/infer/error_reporting/nice_region_error/static_impl_trait.rs
Outdated
Show resolved
Hide resolved
ed3c0b8
to
2f98759
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
@bors r+ |
📌 Commit 2f98759c76a7f292970ed7b225821f6b788605c2 has been approved by |
⌛ Testing commit 2f98759c76a7f292970ed7b225821f6b788605c2 with merge eef9c0cfb310ce550148cae4a85572d834740416... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
2f98759
to
1adb26b
Compare
@bors r+ |
📌 Commit 1adb26b has been approved by |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
⌛ Testing commit 9124f7a with merge 873671bceeda26a9a73140d8791812a3bcb85e7b... |
@bors retry in r0llup |
⌛ Testing commit 9124f7a with merge 33887d5c8537a53c3c3ecf1ef096b1a77b6a82f2... |
💔 Test failed - checks-azure |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@bors retry spurious network |
⌛ Testing commit 9124f7a with merge eecdf9d7ee82d1d1d0a2413d8d80183a2c5e036e... |
Suggest to add lifetime constraint at explicit ouput of functions Closes rust-lang#62097
@bors retry rolled up. |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Suggest to add lifetime constraint at explicit ouput of functions Closes rust-lang#62097
Suggest to add lifetime constraint at explicit ouput of functions Closes rust-lang#62097
Rollup of 5 pull requests Successful merges: - #65355 (Stabilize `!` in Rust 1.41.0) - #65730 (Suggest to add lifetime constraint at explicit ouput of functions) - #66468 (Cleanup Miri SIMD intrinsics) - #66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`) - #66602 (Revert "Update Source Code Pro and include italics") Failed merges: r? @ghost
Closes #62097