Reduce size of hir::Expr by boxing more of hir::InlineAsm
#66515
Conversation
rust-highfive
added
the
S-waiting-on-review
|
@bors try @rust-timer queue |
|
Awaiting bors try build completion |
|
⌛ Trying commit 9b7bed080fc3381be02de27bb7167be3a7a74221 with merge 03d05b28688feb26964e046893ba71f5bf7fd69b... |
|
☀️ Try build successful - checks-azure |
|
Queued 03d05b28688feb26964e046893ba71f5bf7fd69b with parent a0d40f8, future comparison URL. |
|
Finished benchmarking try commit 03d05b28688feb26964e046893ba71f5bf7fd69b, comparison URL. |
|
Unsure if this has had an effect on max-rss, but if it has, it's an improvement (loads of green in https://perf.rust-lang.org/compare.html?start=a0d40f8bdfcc3c28355467973f97fd4c45ac5876&end=03d05b28688feb26964e046893ba71f5bf7fd69b&stat=max-rss) |
|
Yeah that's my thinking also; cc @nnethercote |
| @@ -2074,6 +2072,13 @@ pub struct InlineAsm { | |||
| pub dialect: AsmDialect, | |||
| } | |||
|
|
|||
| #[derive(RustcEncodable, RustcDecodable, Debug, HashStable)] | |||
| pub struct InlineAsm { | |||
| pub inner: InlineAsmInner, | |||
There was a problem hiding this comment.
Is there any need to have InlineAsmInner? Could we just have asm, asm_str_style, outputs, and dialect fields directly in InlineAsm?
There was a problem hiding this comment.
I tried but wasn't able to do that; Expr is not Clone and InlineAsmInner needs to be Clone.
|
|
Centril
force-pushed
the
cheaper-inline-asm
branch
from
9b7bed0
to
44cebe5
Compare
|
@bors r=oli-obk |
|
📌 Commit 44cebe5 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 1000, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm` r? @oli-obk
Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm` r? @oli-obk
Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm` r? @oli-obk
Rollup of 5 pull requests Successful merges: - #65355 (Stabilize `!` in Rust 1.41.0) - #65730 (Suggest to add lifetime constraint at explicit ouput of functions) - #66468 (Cleanup Miri SIMD intrinsics) - #66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`) - #66602 (Revert "Update Source Code Pro and include italics") Failed merges: r? @ghost
Rustup to rustc 1.41.0-nightly (35ef33a 2019-11-21) I don't have the right fix for the fmtstr tests, and I'm also hitting problems caused by messense/rustc-test#3 List of rustups: - rust-lang/rust#66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - rust-lang/rust#65355 (Stabilize `!` in Rust 1.41.0) - rust-lang/rust#66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`) - rust-lang/rust#66389 (Specific labels when referring to "expected" and "found" types) - rust-lang/rust#66074 ([mir-opt] Turn on the `ConstProp` pass by default) changelog: none
Rustup to rustc 1.41.0-nightly (35ef33a 2019-11-21) I don't have the right fix for the fmtstr tests, and I'm also hitting problems caused by messense/rustc-test#3 List of rustups: - rust-lang/rust#66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - rust-lang/rust#65355 (Stabilize `!` in Rust 1.41.0) - rust-lang/rust#66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`) - rust-lang/rust#66389 (Specific labels when referring to "expected" and "found" types) - rust-lang/rust#66074 ([mir-opt] Turn on the `ConstProp` pass by default) changelog: none
Rustup to rustc 1.41.0-nightly (35ef33a 2019-11-21) I don't have the right fix for the fmtstr tests, and I'm also hitting problems caused by messense/rustc-test#3 List of rustups: - rust-lang/rust#66271 (syntax: Keep string literals in ABIs and `asm!` more precisely) - rust-lang/rust#65355 (Stabilize `!` in Rust 1.41.0) - rust-lang/rust#66515 (Reduce size of `hir::Expr` by boxing more of `hir::InlineAsm`) - rust-lang/rust#66389 (Specific labels when referring to "expected" and "found" types) - rust-lang/rust#66074 ([mir-opt] Turn on the `ConstProp` pass by default) changelog: none
r? @oli-obk