Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't cast directly from &[T; N] to *const T #65831

Merged
merged 1 commit into from
Nov 10, 2019

Conversation

matthewjasper
Copy link
Contributor

Split out from #64588

r? @oli-obk

Instead coerce to `*const [T; N]` and then cast.
@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Oct 25, 2019
@JohnCSimon
Copy link
Member

Ping from triage.
@oli-obk if you're back from vacation can you please review this PR?
@matthewjasper @varkor
Thank you!

@JohnCSimon
Copy link
Member

Pinging again from triage.
@oli-obk can you please review this PR?
@matthewjasper @varkor
Thank you!

@oli-obk
Copy link
Contributor

oli-obk commented Nov 9, 2019

@bors r+

@bors
Copy link
Contributor

bors commented Nov 9, 2019

📌 Commit 972c3be has been approved by oli-obk

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Nov 9, 2019
JohnTitor added a commit to JohnTitor/rust that referenced this pull request Nov 10, 2019
…-obk

Don't cast directly from &[T; N] to *const T

Split out from rust-lang#64588

r? @oli-obk
bors added a commit that referenced this pull request Nov 10, 2019
Rollup of 7 pull requests

Successful merges:

 - #65719 (Refactor sync::Once)
 - #65831 (Don't cast directly from &[T; N] to *const T)
 - #66048 (Correct error in documentation for Ipv4Addr method)
 - #66058 (Correct deprecated `is_global` IPv6 documentation)
 - #66216 ([mir-opt] Handle return place in ConstProp and improve SimplifyLocals pass)
 - #66217 (invalid_value lint: use diagnostic items)
 - #66235 (rustc_metadata: don't let LLVM confuse rmeta blobs for COFF object files.)

Failed merges:

r? @ghost
@bors bors merged commit 972c3be into rust-lang:master Nov 10, 2019
@matthewjasper matthewjasper deleted the array-ptr-cast branch November 10, 2019 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants