[mir-opt] Handle return place in ConstProp and improve SimplifyLocals pass #66216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
wesleywiser
force-pushed
the
const_prop_codegen_improvements
branch
from
b7c5e63
to
9e515d0
Compare
Centril
reviewed
Nov 8, 2019
|
@bors try |
|
Awaiting bors try build completion |
|
⌛ Trying commit 9e515d06c298e2d5b8639cd7ff20a4beca5b272d with merge 8dcd1f6f3ef0c78f6de84084d375f219df493843... |
oli-obk
approved these changes
Nov 8, 2019
|
☀️ Try build successful - checks-azure |
|
Queued 8dcd1f6f3ef0c78f6de84084d375f219df493843 with parent 76ade3e, future comparison URL. |
|
Finished benchmarking try commit 8dcd1f6f3ef0c78f6de84084d375f219df493843, comparison URL. |
wesleywiser
force-pushed
the
const_prop_codegen_improvements
branch
from
9e515d0
to
4505ff4
Compare
|
@bors r=oli-obk |
|
📌 Commit 4505ff4 has been approved by |
bors
added
S-waiting-on-bors
|
Woah, look at that perf! 💨 |
|
Just a small note, the performance improvements are from #66074 which this PR used to be based on top of. We won't see those improvements until that PR is merged. |
JohnTitor
added a commit
to JohnTitor/rust
that referenced
this pull request
Nov 10, 2019
…ovements, r=oli-obk [mir-opt] Handle return place in ConstProp and improve SimplifyLocals pass Temporarily rebased on top of rust-lang#66074. The top 2 commits are new. r? @oli-obk
bors
added a commit
that referenced
this pull request
Nov 10, 2019
Rollup of 7 pull requests Successful merges: - #65719 (Refactor sync::Once) - #65831 (Don't cast directly from &[T; N] to *const T) - #66048 (Correct error in documentation for Ipv4Addr method) - #66058 (Correct deprecated `is_global` IPv6 documentation) - #66216 ([mir-opt] Handle return place in ConstProp and improve SimplifyLocals pass) - #66217 (invalid_value lint: use diagnostic items) - #66235 (rustc_metadata: don't let LLVM confuse rmeta blobs for COFF object files.) Failed merges: r? @ghost
This was referenced Dec 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporarily rebased on top of #66074. The top 2 commits are new.
r? @oli-obk