-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some issues with attributes on unnamed fields #66669
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
☔ The latest upstream changes (presumably #66680) made this pull request unmergeable. Please resolve the merge conflicts. |
f04899b
to
f1359c6
Compare
@bors r+ |
📌 Commit f1359c6 has been approved by |
⌛ Testing commit f1359c6 with merge e35f2ada430b6f0fd928529cd0ece66d18588a56... |
Your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem. Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
@bors retry |
☀️ Test successful - checks-azure |
Er, well, I nominated for beta and stable backports since #66555 is marked as a stable-to-stable regression. But now I can't reproduce on either beta or stable, so un-nominating. (Leaving I-nominated so someone can follow up.) |
Actually, I can reproduce on stable and beta with the testcase in #66555 (comment). I was using a testcase I built myself using serde attributes (which showed up in the Fuchsia tree). Re-nominating; sorry for the noise :) |
resolve: Resolve visibilities on fields with non-builtin attributes Follow-up to rust-lang#66669. The first commit is primary (and also a backport candidate), the other ones are further cleanups. In this case it's not strictly necessary to avoid reporting errors during speculative resolution because 1) all visibilities are resolved non-speculatively sooner or later and 2) error reporting infrastructure merges identical errors with identical spans anyway. Fixes rust-lang#67006 r? @matthewjasper
[beta] Beta backports Backporting the following pull requests: * resolve: Always resolve visibilities on impl items #67236 * resolve: Resolve visibilities on fields with non-builtin attributes #67106 * E0023: handle expected != tuple pattern type #67044 * Fix `unused_parens` triggers on macro by example code #66983 * Fix some issues with attributes on unnamed fields #66669 * Ensure that we get a hard error on generic ZST constants if their bodies #67134 (via #67297) Some of these conflicted on merge, I resolved where possible, sometimes by cherry-picking a commit or two more from the relevant PRs. Since those changes are necessary though for backport to proceed (otherwise not even std/core compile), seems fine -- they're fairly minor cleanups anyway.
Fixes #66487
Fixes #66555