Rollup of 5 pull requests #66680
Merged
Rollup of 5 pull requests #66680
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It's not even stable in rustc so it shouldn't be stable in rustdoc.
It can be treated like any other unexpected IO error.
…c, r=QuietMisdreavus Stabilize cfg(doc) cc rust-lang#43781.
Point at type in `let` assignment on type errors Fix rust-lang#61067.
…able, r=GuillaumeGomez rustdoc: Mark `--extern-private` as unstable It's not even stable in rustc so it shouldn't be stable in rustdoc. r? @kinnison
…laumeGomez rustdoc: Don't panic when failing to write .lock file It can be treated like any other unexpected IO error. I couldn't think of a good way to add a test for this unfortunately. r? @GuillaumeGomez
Move def collector from `rustc` to `rustc_resolve` It's used only from `rustc_resolve`, so we can move it there, thus reducing the size of `rustc` (rust-lang#65031). It's quite possible that we can merge the def collector pass into the "build reduced graph" pass (they are always run together and do similar things), but it's some larger work. r? @eddyb
|
@bors r+ p=5 rollup=never |
|
📌 Commit c215de0 has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 10, this pull request will be tested once the tree is reopened |
bors
added
the
S-waiting-on-bors
|
Let's test the waters; @bors p=100 |
bors
added a commit
that referenced
this pull request
Nov 23, 2019
Rollup of 5 pull requests Successful merges: - #61351 (Stabilize cfg(doc)) - #66539 (Point at type in `let` assignment on type errors) - #66655 (rustdoc: Mark `--extern-private` as unstable) - #66657 (rustdoc: Don't panic when failing to write .lock file) - #66673 (Move def collector from `rustc` to `rustc_resolve`) Failed merges: r? @ghost
|
☀️ Test successful - checks-azure |
Merged
This was referenced Nov 24, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
letassignment on type errors #66539 (Point at type inletassignment on type errors)--extern-privateas unstable #66655 (rustdoc: Mark--extern-privateas unstable)rustctorustc_resolve#66673 (Move def collector fromrustctorustc_resolve)Failed merges:
r? @ghost