-
Notifications
You must be signed in to change notification settings - Fork 12.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 13 pull requests #67042
Rollup of 13 pull requests #67042
Conversation
This commit clarifies some comments, fixes some minor errors in comments, and adds a state transition diagram.
The build process of the unikernel HermitCore is redesigned and doesn't longer depend on libhermit.
llvm::Module has a print() method. It is unnecessary to create a pass just for the purpose of printing LLVM IR.
When refering to or suggesting raw identifiers, refer to them with `r#`. Fix rust-lang#65634.
In most places, we use a span when emitting `expected...found` errors. However, there were a couple of places where we didn't use any span, resulting in hard-to-interpret error messages. This commit attaches the relevant span to these notes, and additionally switches over to using `note_expected_found` instead of manually formatting the message
…tates, r=nikomatsakis Tweak `ObligationForest` `NodeState`s These two commits improve comments and function names. r? @nikomatsakis
remove dependency from libhermit The build process of the unikernel HermitCore is redesigned and doesn't longer depend on libhermit.
…crichton Tweak wording of `collect()` on bad target type Fix rust-lang#60440.
Standard library support for riscv64gc-unknown-linux-gnu Add std support for RISC-V 64-bit GNU/Linux and update libc for RISC-V support. r? @alexcrichton
…r=Dylan-DPC Clean up error codes r? @Dylan-DPC
Fix pointing at arg when cause is outside of call Closes: rust-lang#66923
Use Module::print() instead of a PrintModulePass llvm::Module has a print() method. It is unnecessary to create a pass just for the purpose of printing LLVM IR.
…Gomez Add long error for E0631 and update ui tests. This PR adds a long error for `E0631`, which covers errors where closure argument types are mismatched. It also updates UI tests where this error is applicable. Part of rust-lang#61137
capitalize Rust Capitalize "Rust" in docs.
Accurately portray raw identifiers in error messages When refering to or suggesting raw identifiers, refer to them with `r#`. Fix rust-lang#65634.
…r=Dylan-DPC Include a span in more `expected...found` notes In most places, we use a span when emitting `expected...found` errors. However, there were a couple of places where we didn't use any span, resulting in hard-to-interpret error messages. This commit attaches the relevant span to these notes, and additionally switches over to using `note_expected_found` instead of manually formatting the message
…s-2, r=Dylan-DPC cleanup long error explanations r? @Dylan-DPC
Fix docs for formatting delegations If you use the example in the docs right now it breaks all the options Formatters have to offer. i.e. https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=214392ecc6eff73b4789c32568395f72 this should've padded the output with 4 zeros but didn't. with the new example it does work: https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=3bdfb29f395230c5129c5f56dcfcb2a9 The only thing i'm not quite sure about is what's the right way to do it in a loop (altough non of the docs talk about it people are doing it in the wild and there were a couple of attempts to include in libcore) i.e. https://play.rust-lang.org/?version=stable&mode=debug&edition=2018&gist=4c4dca3c90ba36779ecd014f3899ab9c
@bors r+ p=13 rollup=never |
📌 Commit b7c40cb has been approved by |
⌛ Testing commit b7c40cb with merge 659ee9aec5c9235afccec39c443f85a149f986e8... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Successful merges:
NodeState::{Waiting,Done}
#66405 (TweakObligationForest
NodeState
s)collect()
on bad target type #66764 (Tweak wording ofcollect()
on bad target type)expected...found
notes #67011 (Include a span in moreexpected...found
notes)Failed merges:
r? @ghost