-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor expression parsing thoroughly #67112
Conversation
This comment has been minimized.
This comment has been minimized.
Rebased (executed |
#66994 has landed so this is ready to go. :) |
This comment has been minimized.
This comment has been minimized.
Rebased. :) |
This comment has been minimized.
This comment has been minimized.
| _______________^ | ||
LL | | | ||
LL | | } | ||
| |_____^ expected `bool`, found `()` |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤯❤️
// Has been misleading, at least in the past (closed Issue #48492). | ||
Applicability::MaybeIncorrect, | ||
) | ||
.emit(); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could add extra checks here to not suggest in
when it wouldn't be appropriate and bubble the error up in those cases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What situations do you have in mind for "inappropriate" ?
@bors r+ |
📌 Commit 7a246ac has been approved by |
⌛ Testing commit 7a246ac with merge 98b05b6811d198d2601444d635c96d0309ce2edc... |
Refactor expression parsing thoroughly Based on rust-lang#66994 together with which this has refactored basically the entirety of `expr.rs`. r? @estebank
@bors retry yield to rollup |
Rollup of 12 pull requests Successful merges: - #67112 (Refactor expression parsing thoroughly) - #67192 (Various const eval and pattern matching ICE fixes) - #67287 (typeck: note other end-point when checking range pats) - #67459 (prune ill-conceived BTreeMap iter_mut assertion and test its mutability) - #67576 (reuse `capacity` variable in slice::repeat) - #67602 (Use issue = "none" instead of "0" in intrinsics) - #67614 (Set callbacks globally) - #67617 (Remove `compiler_builtins_lib` documentation) - #67629 (Remove redundant link texts) - #67632 (Convert collapsed to shortcut reference links) - #67633 (Update .mailmap) - #67635 (Document safety of Path casting) Failed merges: r? @ghost
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
Is the |
☀️ Test successful - checks-azure |
@Zoxc Seems like it, cc @michaelwoerister. |
I've seen that test fail too. |
Based on #66994 together with which this has refactored basically the entirety of
expr.rs
.r? @estebank