…c" representation

The same problem as in rust-lang#65023 was
introduced by rust-lang#67657. This works
around the current incrcomp issue with these attributes by allowing it
here.

Found one wrongly spelled error message and decided to check all the
error messages for wrongly spelled statements.

Signed-off-by: wcampbell <wcampbell1995@gmail.com>

…n the trait's path

Fix Typo on hir::BinOpKind::Sub

"substract" to "subtract"

Fix Typo on "Error cannot substract"

Fix Typo on cannot "substract"

…torino

Treat extern statics just like statics in the "const pointer to static" representation

fixes rust-lang#67612

r? @spastorino

cc @RalfJung this does not affect runtime promotion at all. This is just about promotion within static item bodies.

Explain that associated types and consts can't be accessed directly on the trait's path

Partially address rust-lang#44539.

Fix incremental builds of core by allowing unused attribute.

I *think* that the same problem as in rust-lang#65023 was introduced by rust-lang#67657. This works around the current incrcomp issue with these attributes by allowing it here. This resolves the near-term issue for me, at least.

Use matches macro in libcore and libstd

This PR replaces matches like

```rust
match var {
    value => true,
    _ => false,
}
```

with use of `matches!` macro.

r? @Centril

Move `intravisit` => `rustc_hir` + misc cleanup

Working towards rust-lang#65031.
This should eventually enable getting rid of rustc as a dependency in various passes (e.g. lints).

cc rust-lang#67806 (this also facilitates liberating lints from tcx)
cc rust-lang#67922 (some other dep reductions)

r? @Zoxc

Display more informative ICE

Fixes rust-lang#66696

…, r=matthewjasper

slice patterns: harden match-based borrowck tests

This hardens some move-checking tests wrt. slice patterns and `match` expressions.

r? @matthewjasper
cc @pnkfelix
cc rust-lang#67712
cc rust-lang#53114

…=Dylan-DPC

Improve E0184 explanation

r? @Dylan-DPC

…rror_codes, r=Centril

Spell check librustc_error_codes

Found one wrongly spelled error message and decided to check all the
error messages for wrongly spelled statements.

Fix issue rust-lang#68008

Correcting Typo on error message. From "substract" to "subtract".

Fixes rust-lang#68008.

Remove `-Z continue-parse-after-error`

We are just always recovering and continuing now.

r? @estebank @Centril

Small improvements in lexical_region_resolve

This just replaces a trivial `if` condition with a `|=` in two places.

I could even have used a `fold` in the first case, but I think it would be less readable.