-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak obligation error output #68377
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
e651f86
to
fbb2a90
Compare
fbb2a90
to
288ffa9
Compare
ping |
ae5611c
to
de4b03d
Compare
cc @rust-lang/wg-diagnostics just because I'm stoked about the result :D |
The new spans are awesome! |
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 532f7c2ff15169402902ddcca71fc13833c3fe99 with merge 5a6609e6dd45556e226d848cf5f6b92301748bd9... |
☀️ Try build successful - checks-azure |
Queued 5a6609e6dd45556e226d848cf5f6b92301748bd9 with parent 5371ddf, future comparison URL. |
Finished benchmarking try commit 5a6609e6dd45556e226d848cf5f6b92301748bd9, comparison URL. |
This comment has been minimized.
This comment has been minimized.
a218555
to
009dc5f
Compare
This comment has been minimized.
This comment has been minimized.
Stemming from the thread at https://twitter.com/indygreg/status/1223279056398929920
…ured suggestions when possible
009dc5f
to
342db71
Compare
Sorry for this PR becoming so big 😬, it's just addressing a bunch of intimately related issues. Each commit builds on the previous one. |
34990c8
to
865216b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just a wording, then this lgtm
5439b6e
to
0e58411
Compare
Is that r=oli-obk? 😅 |
@bors r+ yes :D I'll communicate that more clearly next time |
📌 Commit 0e58411 has been approved by |
Tweak obligation error output - Point at arguments or output when fn obligations come from them, or ident when they don't - Point at `Sized` bound (fix #47990) - When object unsafe trait uses itself in associated item suggest using `Self` (fix #66424, fix #33375, partially address #38376, cc #61525) - Point at reason in object unsafe trait with `Self` in supertraits or `where`-clause (cc #40533, cc #68377) - On implicit type parameter `Sized` obligations, suggest `?Sized` (fix #57744, fix #46683)
☀️ Test successful - checks-azure |
Sized
bound (fix Providing a trait object as a type parameter to a function causes nonsense error #47990)Self
(fix Suggest using Self in traits #66424, fix Non trait object safe return diagnostic needs improvement #33375, partially address Special errors for common trait object issues #38376, cc Error when passing a trait object as a generic type doesn't indicate what is the trait object #61525)Self
in supertraits orwhere
-clause (cc Object safety error when using an associated type as a type parameter in the super-trait listing #40533, cc Tweak obligation error output #68377)Sized
obligations, suggest?Sized
(fix Confusing error message when passing trait object to generic function #57744, fix better error message when usingdyn
type #46683, fix Suggest ?Sized on generics where applicable #38936)