Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[beta] backports #68496

Merged
merged 7 commits into from
Jan 24, 2020
Merged

[beta] backports #68496

merged 7 commits into from
Jan 24, 2020

Commits on Jan 23, 2020

  1. fmt data data structures

    @Mark-Simulacrum
    Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5d4b639 View commit details
    Browse the repository at this point in the history

  2. Revert parts of rust-lang#66405. 

    Because it caused major performance regressions in some cases.

That PR had five commits, two of which affected performance, and three
of which were refactorings. This change undoes the performance-affecting
changes, while keeping the refactorings in place.

Fixes rust-lang#67454.
    @nnethercote @Mark-Simulacrum
    nnethercote authored and Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    6a835ea View commit details
    Browse the repository at this point in the history

  3. format librustdoc

    @Mark-Simulacrum
    Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    5386cbd View commit details
    Browse the repository at this point in the history

  4. Distinguish between private items and hidden items in rustdoc 

    I believe rustdoc should not be conflating private items (visibility
lower than `pub`) and hidden items (attribute `doc(hidden)`). This
matters now that Cargo is passing --document-private-items by default
for bin crates. In bin crates that rely on macros, intentionally hidden
implementation details of the macros can overwhelm the actual useful
internal API that one would want to document.

This PR restores the strip-hidden pass when documenting private items,
and introduces a separate unstable --document-hidden-items option to
skip the strip-hidden pass. The two options are orthogonal to one
another.
    @dtolnay @Mark-Simulacrum
    dtolnay authored and Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    4bed1c7 View commit details
    Browse the repository at this point in the history

  5. format librustc_errors

    @Mark-Simulacrum
    Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    d97ae99 View commit details
    Browse the repository at this point in the history

  6. Do not ICE on malformed suggestion spans

    @estebank @Mark-Simulacrum
    estebank authored and Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    356ff77 View commit details
    Browse the repository at this point in the history

  7. review comments

    @estebank @Mark-Simulacrum
    estebank authored and Mark-Simulacrum committed Jan 23, 2020
    Configuration menu
    Copy the full SHA
    b0a99fd View commit details
    Browse the repository at this point in the history