-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add an abstraction for custom query caches #68988
Conversation
@bors try @rust-timer queue |
Awaiting bors try build completion |
⌛ Trying commit 4a5857660c9c9e6e8b313f0c892da0d38551003f with merge 8e818dc3304a24344d80a0481fee50f50da399a1... |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
💔 Test failed - checks-azure |
The job Click to expand the log.
I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
@rust-timer build 8e818dc3304a24344d80a0481fee50f50da399a1 |
Queued 8e818dc3304a24344d80a0481fee50f50da399a1 with parent f8d830b, future comparison URL. |
@@ -12,7 +13,9 @@ use rustc_span::{Span, DUMMY_SP}; | |||
|
|||
/// The `Key` trait controls what types can legally be used as the key | |||
/// for a query. | |||
pub(super) trait Key { | |||
pub trait Key { | |||
type CacheSelector; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
type CacheSelector; | |
type CacheSelector = DefaultCacheSelector; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Zoxc Is this actionable?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's unstable and I ran into some issues trying to use it.
☔ The latest upstream changes (presumably #68693) made this pull request unmergeable. Please resolve the merge conflicts. |
@bors try @rust-timer queue |
Awaiting bors try build completion |
[WIP] Add an abstraction for custom query caches r? @eddyb
☀️ Try build successful - checks-azure |
Queued 5ea002a with parent e168dcd, future comparison URL. |
Finished benchmarking try commit 5ea002a, comparison URL. |
@bors try @rust-timer queue |
Awaiting bors try build completion |
[WIP] Add an abstraction for custom query caches r? @eddyb
src/librustc/query/mod.rs
Outdated
@@ -663,7 +665,8 @@ rustc_queries! { | |||
/// associated types. This is almost always what you want, | |||
/// unless you are doing MIR optimizations, in which case you | |||
/// might want to use `reveal_all()` method to change modes. | |||
query param_env(_: DefId) -> ty::ParamEnv<'tcx> {} | |||
query param_env(_: DefId) -> ty::ParamEnv<'tcx> { | |||
} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are these automatic formatting changes (i.e. caused by changing something in the macro), or can they be removed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, this is just an incomplete reversion. I've rebased these away.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
r=me modulo nits
@bors r=eddyb p=1 |
📌 Commit d924a25 has been approved by |
@bors rollup=never |
☀️ Test successful - checks-azure |
r? @eddyb