-
Notifications
You must be signed in to change notification settings - Fork 12.9k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 9 pull requests #69666
Merged
Merged
Rollup of 9 pull requests #69666
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…loop iterations by variables
…=steveklabnik Improve documentation on iterators length Attempts to resolve rust-lang#66491. @the8472 does this help? r? @steveklabnik
Remove `usable_size` APIs This removes the usable size APIs: - remove `usable_size` (obv) - change return type of allocating methods to include the allocated size - remove `_excess` API r? @Amanieu closes rust-lang/wg-allocators#17
more cleanups * use starts_with() instead of chars().next() == Some(x) * use subsec_micros() instead of subsec_nanos() / 1000 * use for (idx, item) in iter.enumerate() instead of manually counting loop iterations with variables * use values() or keys() respectively when iterating only over keys or values of maps.
…de-e0719, r=davidtwco doc(librustc_error_codes): add long error explanation for E0719 Reference issue rust-lang#61137 - Updated error_codes.rs - Added E0719.md in error_codes - Updated necessary test .stderr files
…Mark-Simulacrum Toolstate: don't duplicate nightly tool list. Just some cleanup, seems good to avoid duplicating this list.
…nto_diagnostic-leak, r=Centril Fix a leak in `DiagnosticBuilder::into_diagnostic`. Fixes rust-lang#69600. r? @Centril
Update my mailmap entry superceding rust-lang#68891
…lan-DPC clean up E0378 explanation r? @Dylan-DPC
…ecstatic-morse Don't convert Results to Options just for matching.
@bors r+ p=9 rollup=never |
📌 Commit e453a0c has been approved by |
bors
added
the
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
label
Mar 3, 2020
☀️ Test successful - checks-azure |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
merged-by-bors
This PR was explicitly merged by bors.
rollup
A PR which is a rollup
S-waiting-on-bors
Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
usable_size
APIs #69609 (Removeusable_size
APIs)DiagnosticBuilder::into_diagnostic
. #69628 (Fix a leak inDiagnosticBuilder::into_diagnostic
.)Failed merges:
r? @ghost