Allow `hir().find` to return `None` #70051

Zoxc · 2020-03-16T18:25:05Z

Fixes #70041

r? @eddyb

eddyb · 2020-03-16T18:57:23Z

@bors r+

bors · 2020-03-16T18:57:24Z

📌 Commit 6207e8d has been approved by eddyb

@eddyb

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

rust-highfive · 2020-03-16T19:41:10Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-16T18:26:28.5666320Z ========================== Starting Command Output ===========================
2020-03-16T18:26:28.5671186Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/4c5ed60d-32df-46a5-8d6a-2b409ab9be78.sh
2020-03-16T18:26:28.5671715Z 
2020-03-16T18:26:28.5676639Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-16T18:26:28.5697275Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-16T18:26:28.5710224Z Task         : Get sources
2020-03-16T18:26:28.5710516Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-16T18:26:28.5710795Z Version      : 1.0.0
2020-03-16T18:26:28.5710985Z Author       : Microsoft
---
2020-03-16T18:26:29.7387953Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-16T18:26:29.7396830Z ##[command]git config gc.auto 0
2020-03-16T18:26:29.7403173Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-16T18:26:29.7408368Z ##[command]git config --get-all http.proxy
2020-03-16T18:26:29.7447522Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70051/merge:refs/remotes/pull/70051/merge
---
2020-03-16T19:29:51.0799877Z .................................................................................................... 1700/9775
2020-03-16T19:29:55.4774941Z .................................................................................................... 1800/9775
2020-03-16T19:30:07.1970790Z ......................................................................i............................. 1900/9775
2020-03-16T19:30:13.6585831Z .................................................................................................... 2000/9775
2020-03-16T19:30:28.7905216Z ............................................................iiiii................................... 2100/9775
2020-03-16T19:30:39.4992454Z .................................................................................................... 2300/9775
2020-03-16T19:30:41.6653299Z .................................................................................................... 2400/9775
2020-03-16T19:30:44.5637967Z .................................................................................................... 2500/9775
2020-03-16T19:31:05.0942474Z .................................................................................................... 2600/9775
---
2020-03-16T19:33:47.4990300Z ................................i...............i................................................... 5000/9775
2020-03-16T19:33:56.4106646Z .................................................................................................... 5100/9775
2020-03-16T19:34:02.8671742Z ...........................................................................i........................ 5200/9775
2020-03-16T19:34:08.2796001Z ..............................................................F..................................... 5300/9775
2020-03-16T19:34:18.1149617Z .........................................................ii.ii........i...i......................... 5400/9775
2020-03-16T19:34:26.1693729Z .................................................................................................... 5600/9775
2020-03-16T19:34:35.7542653Z .................................................................................................... 5700/9775
2020-03-16T19:34:41.6526188Z .................................................i.................................................. 5800/9775
2020-03-16T19:34:48.0585396Z .................................................................................................... 5900/9775
2020-03-16T19:34:48.0585396Z .................................................................................................... 5900/9775
2020-03-16T19:34:57.9796431Z .................................................................................................... 6000/9775
2020-03-16T19:35:04.1875345Z ...........................................ii...i..ii...........i................................... 6100/9775
2020-03-16T19:35:24.0847815Z .................................................................................................... 6300/9775
2020-03-16T19:35:31.1821612Z .................................................................................................... 6400/9775
2020-03-16T19:35:31.1821612Z .................................................................................................... 6400/9775
2020-03-16T19:35:40.0619455Z .........................................................................i..ii...................... 6500/9775
2020-03-16T19:36:03.2169313Z .................................................................................................... 6700/9775
2020-03-16T19:36:12.7013086Z .......................................................................i............................ 6800/9775
2020-03-16T19:36:14.7963496Z .................................................................................................... 6900/9775
2020-03-16T19:36:16.9285092Z .................................................................................................... 7000/9775
---
2020-03-16T19:38:01.5607148Z .................................................................................................... 7800/9775
2020-03-16T19:38:07.3425021Z .................................................................................................... 7900/9775
2020-03-16T19:38:13.1131101Z .......................................................i............................................ 8000/9775
2020-03-16T19:38:23.3046241Z .................................................................................................... 8100/9775
2020-03-16T19:38:28.7916915Z ....iiiiiiiiii.i.................................................................................... 8200/9775
2020-03-16T19:38:42.3950561Z .................................................................................................... 8400/9775
2020-03-16T19:38:52.9868244Z .................................................................................................... 8500/9775
2020-03-16T19:39:05.8480634Z .................................................................................................... 8600/9775
2020-03-16T19:39:12.2700682Z .................................................................................................... 8700/9775
---
2020-03-16T19:41:04.1155164Z ---- [ui] ui/issues/issue-70041.rs stdout ----
2020-03-16T19:41:04.1155381Z 
2020-03-16T19:41:04.1155597Z error: ui test compiled successfully!
2020-03-16T19:41:04.1155875Z status: exit code: 0
2020-03-16T19:41:04.1158084Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-70041.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "--emit" "metadata" "-C" "prefer-dynamic" "--out-dir" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-70041" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "-A" "unused" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-70041/auxiliary"
2020-03-16T19:41:04.1159915Z ------------------------------------------
2020-03-16T19:41:04.1160113Z 
2020-03-16T19:41:04.1160527Z ------------------------------------------
2020-03-16T19:41:04.1160756Z stderr:
---
2020-03-16T19:41:04.1188468Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-16T19:41:04.1188939Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-16T19:41:04.1205790Z 
2020-03-16T19:41:04.1206284Z 
2020-03-16T19:41:04.1211042Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-16T19:41:04.1214142Z 
2020-03-16T19:41:04.1214257Z 
2020-03-16T19:41:04.1225654Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-16T19:41:04.1226029Z Build completed unsuccessfully in 1:07:38
2020-03-16T19:41:04.1226029Z Build completed unsuccessfully in 1:07:38
2020-03-16T19:41:04.1278801Z == clock drift check ==
2020-03-16T19:41:04.1297938Z   local time: Mon Mar 16 19:41:04 UTC 2020
2020-03-16T19:41:04.4240575Z   network time: Mon, 16 Mar 2020 19:41:04 GMT
2020-03-16T19:41:04.4242300Z == end clock drift check ==
2020-03-16T19:41:04.9343862Z 
2020-03-16T19:41:04.9423933Z ##[error]Bash exited with code '1'.
2020-03-16T19:41:04.9439529Z ##[section]Finishing: Run build
2020-03-16T19:41:04.9493636Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-16T19:41:04.9499136Z Task         : Get sources
2020-03-16T19:41:04.9499521Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-16T19:41:04.9499883Z Version      : 1.0.0
2020-03-16T19:41:04.9500148Z Author       : Microsoft
2020-03-16T19:41:04.9500148Z Author       : Microsoft
2020-03-16T19:41:04.9500545Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-16T19:41:04.9501022Z ==============================================================================
2020-03-16T19:41:05.3480210Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-16T19:41:05.3527137Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-16T19:41:05.3615714Z Cleaning up task key
2020-03-16T19:41:05.3616968Z Start cleaning up orphan processes.
2020-03-16T19:41:05.3822853Z Terminate orphan process: pid (3641) (python)
2020-03-16T19:41:05.4026380Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

eddyb · 2020-03-16T19:46:56Z

@bors r-

rust-highfive · 2020-03-16T19:57:58Z

The job mingw-check of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-16T19:53:04.2306165Z ========================== Starting Command Output ===========================
2020-03-16T19:53:04.2310052Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/1e317d35-dc34-4115-ad75-364a75cc4181.sh
2020-03-16T19:53:04.2310364Z 
2020-03-16T19:53:04.2313811Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-16T19:53:04.2334244Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-16T19:53:04.2338359Z Task         : Get sources
2020-03-16T19:53:04.2338692Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-16T19:53:04.2339001Z Version      : 1.0.0
2020-03-16T19:53:04.2339209Z Author       : Microsoft
---
2020-03-16T19:53:06.9945137Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-16T19:53:06.9953499Z ##[command]git config gc.auto 0
2020-03-16T19:53:06.9959182Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-16T19:53:06.9964637Z ##[command]git config --get-all http.proxy
2020-03-16T19:53:06.9976267Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70051/merge:refs/remotes/pull/70051/merge

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

@ghost

Rollup of 7 pull requests Successful merges: - #69870 (expand: Implement something similar to `#[cfg(accessible(path))]`) - #69881 (VariantSizeDifferences: bail on SizeOverflow) - #70000 (resolve: Fix regression in resolution of raw keywords in paths) - #70029 (Bump the bootstrap compiler) - #70046 (Use sublice patterns to avoid computing the len) - #70049 (Fiddle `ParamEnv` through to a place that used to use `ParamEnv::empty` in a buggy manner) - #70051 (Allow `hir().find` to return `None`) Failed merges: r? @ghost

Centril · 2020-03-16T20:48:52Z

Failed in #70053 (comment), @bors r-

rust-highfive · 2020-03-17T13:59:46Z

The job x86_64-gnu-llvm-7 of your PR failed (pretty log, raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

2020-03-17T12:49:09.9120562Z ========================== Starting Command Output ===========================
2020-03-17T12:49:09.9125371Z [command]/bin/bash --noprofile --norc /home/vsts/work/_temp/b44b0a5f-b9f9-4d70-8b36-3653e4db7ab8.sh
2020-03-17T12:49:09.9125821Z 
2020-03-17T12:49:09.9137450Z ##[section]Finishing: Disable git automatic line ending conversion
2020-03-17T12:49:09.9157086Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-17T12:49:09.9160572Z Task         : Get sources
2020-03-17T12:49:09.9160980Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T12:49:09.9161258Z Version      : 1.0.0
2020-03-17T12:49:09.9161447Z Author       : Microsoft
---
2020-03-17T12:49:11.1247176Z ##[command]git remote add origin https://github.com/rust-lang/rust
2020-03-17T12:49:11.1254274Z ##[command]git config gc.auto 0
2020-03-17T12:49:11.1258067Z ##[command]git config --get-all http.https://github.com/rust-lang/rust.extraheader
2020-03-17T12:49:11.1261880Z ##[command]git config --get-all http.proxy
2020-03-17T12:49:11.1269068Z ##[command]git -c http.extraheader="AUTHORIZATION: basic ***" fetch --force --tags --prune --progress --no-recurse-submodules --depth=2 origin +refs/heads/*:refs/remotes/origin/* +refs/pull/70051/merge:refs/remotes/pull/70051/merge
---
2020-03-17T13:48:37.5199057Z .................................................................................................... 1700/9796
2020-03-17T13:48:41.6514381Z .................................................................................................... 1800/9796
2020-03-17T13:48:52.5069441Z ..........................................................................i......................... 1900/9796
2020-03-17T13:48:58.7027569Z .................................................................................................... 2000/9796
2020-03-17T13:49:06.4306992Z ................................................................iiiii............................... 2100/9796
2020-03-17T13:49:23.8086572Z .................................................................................................... 2300/9796
2020-03-17T13:49:25.9894018Z .................................................................................................... 2400/9796
2020-03-17T13:49:28.8652785Z .................................................................................................... 2500/9796
2020-03-17T13:49:48.9054828Z .................................................................................................... 2600/9796
---
2020-03-17T13:52:29.6016619Z ....................................i...............i............................................... 5000/9796
2020-03-17T13:52:38.1775873Z .................................................................................................... 5100/9796
2020-03-17T13:52:44.4599241Z ...............................................................................i.................... 5200/9796
2020-03-17T13:52:49.7737872Z ...................................................................F................................ 5300/9796
2020-03-17T13:53:00.0677533Z .............................................................ii.ii........i...i..................... 5400/9796
2020-03-17T13:53:08.3387714Z i................................................................................................... 5600/9796
2020-03-17T13:53:17.9444651Z .................................................................................................... 5700/9796
2020-03-17T13:53:24.2533499Z ......................................................i............................................. 5800/9796
2020-03-17T13:53:30.6204425Z .................................................................................................... 5900/9796
2020-03-17T13:53:30.6204425Z .................................................................................................... 5900/9796
2020-03-17T13:53:39.7637766Z .................................................................................................... 6000/9796
2020-03-17T13:53:46.3794480Z ................................................ii...i..ii...........i.............................. 6100/9796
2020-03-17T13:54:06.3617319Z .................................................................................................... 6300/9796
2020-03-17T13:54:13.2846186Z .................................................................................................... 6400/9796
2020-03-17T13:54:13.2846186Z .................................................................................................... 6400/9796
2020-03-17T13:54:21.3999753Z ..............................................................................i..ii................. 6500/9796
2020-03-17T13:54:45.1377872Z .................................................................................................... 6700/9796
2020-03-17T13:54:54.0820741Z ............................................................................i....................... 6800/9796
2020-03-17T13:54:56.1289907Z .................................................................................................... 6900/9796
2020-03-17T13:54:58.2168379Z .................................................................................................... 7000/9796
---
2020-03-17T13:56:39.9853827Z .................................................................................................... 7800/9796
2020-03-17T13:56:45.3175006Z .................................................................................................... 7900/9796
2020-03-17T13:56:51.4201398Z .............................................................i...................................... 8000/9796
2020-03-17T13:57:01.2380529Z .................................................................................................... 8100/9796
2020-03-17T13:57:06.8273558Z ..........iiiiiiiiii.i.............................................................................. 8200/9796
2020-03-17T13:57:20.6239635Z .................................................................................................... 8400/9796
2020-03-17T13:57:28.6472367Z .................................................................................................... 8500/9796
2020-03-17T13:57:42.1359673Z .................................................................................................... 8600/9796
2020-03-17T13:57:48.5714664Z .................................................................................................... 8700/9796
---
2020-03-17T13:59:40.3321950Z 
2020-03-17T13:59:40.3322770Z 
2020-03-17T13:59:40.3323201Z The actual stderr differed from the expected stderr.
2020-03-17T13:59:40.3325270Z Actual stderr saved to /checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-70041/issue-70041.stderr
2020-03-17T13:59:40.3327107Z To update references, rerun the tests and pass the `--bless` flag
2020-03-17T13:59:40.3328788Z To only update this specific test, also pass `--test-args issues/issue-70041.rs`
2020-03-17T13:59:40.3330838Z error: 1 errors occurred comparing output.
2020-03-17T13:59:40.3332385Z status: exit code: 0
2020-03-17T13:59:40.3332385Z status: exit code: 0
2020-03-17T13:59:40.3335319Z command: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "/checkout/src/test/ui/issues/issue-70041.rs" "-Zthreads=1" "--target=x86_64-unknown-linux-gnu" "--error-format" "json" "-Zui-testing" "-Zdeduplicate-diagnostics=no" "-C" "prefer-dynamic" "-o" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-70041/a" "-Crpath" "-O" "-Cdebuginfo=0" "-Zunstable-options" "-Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--edition=2018" "-L" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui/issues/issue-70041/auxiliary"
2020-03-17T13:59:40.3337940Z ------------------------------------------
2020-03-17T13:59:40.3338272Z 
2020-03-17T13:59:40.3338818Z ------------------------------------------
2020-03-17T13:59:40.3339174Z stderr:
---
2020-03-17T13:59:40.3348206Z thread 'main' panicked at 'Some tests failed', src/tools/compiletest/src/main.rs:348:22
2020-03-17T13:59:40.3348621Z note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
2020-03-17T13:59:40.3357724Z 
2020-03-17T13:59:40.3357881Z 
2020-03-17T13:59:40.3361867Z command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-tools-bin/compiletest" "--compile-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib" "--run-lib-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/lib/rustlib/x86_64-unknown-linux-gnu/lib" "--rustc-path" "/checkout/obj/build/x86_64-unknown-linux-gnu/stage2/bin/rustc" "--src-base" "/checkout/src/test/ui" "--build-base" "/checkout/obj/build/x86_64-unknown-linux-gnu/test/ui" "--stage-id" "stage2-x86_64-unknown-linux-gnu" "--mode" "ui" "--target" "x86_64-unknown-linux-gnu" "--host" "x86_64-unknown-linux-gnu" "--llvm-filecheck" "/usr/lib/llvm-7/bin/FileCheck" "--nodejs" "/usr/bin/node" "--host-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--target-rustcflags" "-Crpath -O -Cdebuginfo=0 -Zunstable-options  -Lnative=/checkout/obj/build/x86_64-unknown-linux-gnu/native/rust-test-helpers" "--docck-python" "/usr/bin/python2.7" "--lldb-python" "/usr/bin/python2.7" "--gdb" "/usr/bin/gdb" "--quiet" "--llvm-version" "7.0.0\n" "--system-llvm" "--cc" "" "--cxx" "" "--cflags" "" "--llvm-components" "" "--adb-path" "adb" "--adb-test-dir" "/data/tmp/work" "--android-cross-path" "" "--color" "always"
2020-03-17T13:59:40.3364637Z 
2020-03-17T13:59:40.3364738Z 
2020-03-17T13:59:40.3364980Z failed to run: /checkout/obj/build/bootstrap/debug/bootstrap test
2020-03-17T13:59:40.3365322Z Build completed unsuccessfully in 1:04:49
2020-03-17T13:59:40.3365322Z Build completed unsuccessfully in 1:04:49
2020-03-17T13:59:40.3418056Z == clock drift check ==
2020-03-17T13:59:40.3434475Z   local time: Tue Mar 17 13:59:40 UTC 2020
2020-03-17T13:59:40.6378653Z   network time: Tue, 17 Mar 2020 13:59:40 GMT
2020-03-17T13:59:40.6380891Z == end clock drift check ==
2020-03-17T13:59:41.0492449Z 
2020-03-17T13:59:41.0588857Z ##[error]Bash exited with code '1'.
2020-03-17T13:59:41.0602751Z ##[section]Finishing: Run build
2020-03-17T13:59:41.0651441Z ##[section]Starting: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-17T13:59:41.0656416Z Task         : Get sources
2020-03-17T13:59:41.0656753Z Description  : Get sources from a repository. Supports Git, TfsVC, and SVN repositories.
2020-03-17T13:59:41.0657147Z Version      : 1.0.0
2020-03-17T13:59:41.0657586Z Author       : Microsoft
2020-03-17T13:59:41.0657586Z Author       : Microsoft
2020-03-17T13:59:41.0657941Z Help         : [More Information](https://go.microsoft.com/fwlink/?LinkId=798199)
2020-03-17T13:59:41.0658332Z ==============================================================================
2020-03-17T13:59:41.4152788Z Cleaning any cached credential from repository: rust-lang/rust (GitHub)
2020-03-17T13:59:41.4200336Z ##[section]Finishing: Checkout rust-lang/rust@refs/pull/70051/merge to s
2020-03-17T13:59:41.4287328Z Cleaning up task key
2020-03-17T13:59:41.4288603Z Start cleaning up orphan processes.
2020-03-17T13:59:41.4482596Z Terminate orphan process: pid (3575) (python)
2020-03-17T13:59:41.4655336Z ##[section]Finishing: Finalize Job

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @rust-lang/infra. (Feature Requests)

Zoxc · 2020-03-17T18:53:42Z

@bors r=eddyb

bors · 2020-03-17T18:53:44Z

📌 Commit 37bee6d has been approved by eddyb

@eddyb

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#67749 (keyword docs for else and inkeyword docs for else and in.) - rust-lang#69139 (clean up E0308 explanation) - rust-lang#69189 (Erase regions in writeback) - rust-lang#69837 (Use smaller discriminants for generators) - rust-lang#69838 (Expansion-driven outline module parsing) - rust-lang#69839 (Miri error reform) - rust-lang#69899 (Make methods declared by `newtype_index` macro `const`) - rust-lang#69920 (Remove some imports to the rustc crate) - rust-lang#70075 (Fix repr pretty display) - rust-lang#70106 (Tidy: fix running rustfmt twice) Failed merges: - rust-lang#70051 (Allow `hir().find` to return `None`) - rust-lang#70074 (Expand: nix all fatal errors) r? @ghost

bors · 2020-03-19T03:50:21Z

☔ The latest upstream changes (presumably #70118) made this pull request unmergeable. Please resolve the merge conflicts.

bors · 2020-03-21T11:23:54Z

☔ The latest upstream changes (presumably #70211) made this pull request unmergeable. Please resolve the merge conflicts.

Zoxc · 2020-03-21T21:10:59Z

@bors r=eddyb

bors · 2020-03-21T21:11:00Z

📌 Commit 0aa15d0 has been approved by eddyb

@ghost

Rollup of 10 pull requests Successful merges: - rust-lang#70003 (symbol_names: treat ReifyShim like VtableShim.) - rust-lang#70051 (Allow `hir().find` to return `None`) - rust-lang#70126 (Fix ICE caused by truncating a negative ZST enum discriminant) - rust-lang#70197 (For issue 53957: revise unit test to focus on underlying bug of 23076.) - rust-lang#70215 (ast: Compress `AttrId` from `usize` to `u32`) - rust-lang#70218 (Fix deprecated Error.description() usage in docs) - rust-lang#70228 (Remove CARGO_BUILD_TARGET from bootstrap.py) - rust-lang#70231 (Add explanation message for E0224) - rust-lang#70232 (Tweak wording for std::io::Read::read function) - rust-lang#70238 (Add a test for out-of-line module passed through a proc macro) Failed merges: r? @ghost

rust-highfive assigned eddyb Mar 16, 2020

rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label Mar 16, 2020

Zoxc changed the title ~~Allow hir().find to return Some~~ Allow hir().find to return None Mar 16, 2020

Zoxc force-pushed the opt-find branch from 4fe9177 to 6207e8d Compare March 16, 2020 18:25

eddyb approved these changes Mar 16, 2020

View reviewed changes

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels Mar 16, 2020

Centril added a commit to Centril/rust that referenced this pull request Mar 16, 2020

Rollup merge of rust-lang#70051 - Zoxc:opt-find, r=eddyb

9d325cf

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

Centril mentioned this pull request Mar 16, 2020

Rollup of 7 pull requests #70053

Closed

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 16, 2020

Zoxc force-pushed the opt-find branch from 6207e8d to 34e50c8 Compare March 16, 2020 19:52

Zoxc force-pushed the opt-find branch from 34e50c8 to 0c0878a Compare March 17, 2020 12:48

Zoxc force-pushed the opt-find branch from 0c0878a to 37bee6d Compare March 17, 2020 15:57

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 17, 2020

Manishearth added a commit to Manishearth/rust that referenced this pull request Mar 17, 2020

Rollup merge of rust-lang#70051 - Zoxc:opt-find, r=eddyb

c0f826a

Allow `hir().find` to return `None` Fixes rust-lang#70041 r? @eddyb

Manishearth mentioned this pull request Mar 17, 2020

Rollup of 12 pull requests #70085

Closed

Centril mentioned this pull request Mar 18, 2020

Rollup of 8 pull requests #70099

Closed

Centril mentioned this pull request Mar 18, 2020

Rollup of 10 pull requests #70112

Merged

eddyb mentioned this pull request Mar 18, 2020

Add all remaining DefKinds. #70043

Merged

bors added S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. and removed S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. labels Mar 19, 2020

Zoxc force-pushed the opt-find branch from 37bee6d to 64f24fc Compare March 19, 2020 13:57

Allow hir().find to return None

0aa15d0

Zoxc force-pushed the opt-find branch from 64f24fc to 0aa15d0 Compare March 21, 2020 19:13

bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-author Status: This is awaiting some action (such as code changes or more information) from the author. labels Mar 21, 2020

Dylan-DPC-zz mentioned this pull request Mar 21, 2020

Rollup of 10 pull requests #70246

Merged

bors merged commit ce0af8a into rust-lang:master Mar 22, 2020

Zoxc deleted the opt-find branch March 22, 2020 01:04

vorot93 mentioned this pull request Mar 24, 2020

Update Cargo.lock openethereum/parity-ethereum#11573

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Allow `hir().find` to return `None` #70051

Allow `hir().find` to return `None` #70051

Zoxc commented Mar 16, 2020

eddyb commented Mar 16, 2020

bors commented Mar 16, 2020

rust-highfive commented Mar 16, 2020

eddyb commented Mar 16, 2020

rust-highfive commented Mar 16, 2020

Centril commented Mar 16, 2020

rust-highfive commented Mar 17, 2020

Zoxc commented Mar 17, 2020

bors commented Mar 17, 2020

bors commented Mar 19, 2020

bors commented Mar 21, 2020

Zoxc commented Mar 21, 2020

bors commented Mar 21, 2020

Allow hir().find to return None #70051

Allow hir().find to return None #70051

Conversation

Zoxc commented Mar 16, 2020

eddyb commented Mar 16, 2020

bors commented Mar 16, 2020

rust-highfive commented Mar 16, 2020

eddyb commented Mar 16, 2020

rust-highfive commented Mar 16, 2020

Centril commented Mar 16, 2020

rust-highfive commented Mar 17, 2020

Zoxc commented Mar 17, 2020

bors commented Mar 17, 2020

bors commented Mar 19, 2020

bors commented Mar 21, 2020

Zoxc commented Mar 21, 2020

bors commented Mar 21, 2020

Allow `hir().find` to return `None` #70051

Allow `hir().find` to return `None` #70051