For issue 53957: revise unit test to focus on underlying bug of 23076. #70197
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs. (I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of `ToSocketAddrs` and what not. It is not worth it.)
|
(rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
pnkfelix
changed the title
|
(I would also be satisfied with just deleting the |
|
It is kind of icky to have a regression test for a parser bug that contacts the user's DNS server. However, I agree that properly testing this would probably require a lot more work. And as this is certainly an improvement over the old test, let's merge this. @bors r+ |
|
📌 Commit 3db6d1c has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
Mar 21, 2020
…-23076, r=LukasKalbertodt For issue 53957: revise unit test to focus on underlying bug of 23076. Fix rust-lang#53957 by revising unit test to focus on underlying bug of rust-lang#23076. Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs. (I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of `ToSocketAddrs` and what not. It is not worth it.)
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Mar 21, 2020
Rollup of 10 pull requests Successful merges: - rust-lang#70003 (symbol_names: treat ReifyShim like VtableShim.) - rust-lang#70051 (Allow `hir().find` to return `None`) - rust-lang#70126 (Fix ICE caused by truncating a negative ZST enum discriminant) - rust-lang#70197 (For issue 53957: revise unit test to focus on underlying bug of 23076.) - rust-lang#70215 (ast: Compress `AttrId` from `usize` to `u32`) - rust-lang#70218 (Fix deprecated Error.description() usage in docs) - rust-lang#70228 (Remove CARGO_BUILD_TARGET from bootstrap.py) - rust-lang#70231 (Add explanation message for E0224) - rust-lang#70232 (Tweak wording for std::io::Read::read function) - rust-lang#70238 (Add a test for out-of-line module passed through a proc macro) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #53957 by revising unit test to focus on underlying bug of #23076.
Namely, this version focuses on the end-to-end behavior that the attempt to create the UDP binding will fail, regardless of the semantics of how particular DNS servers handle junk inputs.
(I spent some time trying to create a second more-focused test that would sidestep the DNS resolution, but this is not possible without more invasive changes to the internal infrastructure of
ToSocketAddrsand what not. It is not worth it.)