implement size_hint on sys iterators #71308
Closed
+37
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
r? @sfackler (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
Marking as draft because i'm expecting some CI failures |
62 tasks
sfackler
reviewed
Apr 19, 2020
src/libstd/sys/cloudabi/shims/fs.rs
Outdated
| @@ -140,6 +140,10 @@ impl Iterator for ReadDir { | |||
| fn next(&mut self) -> Option<io::Result<DirEntry>> { | |||
| match self.0 {} | |||
| } | |||
|
|
|||
| fn size_hint(&self) -> (usize, Option<usize>) { | |||
| (0, Some(0)) | |||
There was a problem hiding this comment.
This type is uninhabited - does it really need a size_hint override?
There was a problem hiding this comment.
Yeah that makes sense to remove it. I just ported the old pr :D
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
sfackler
reviewed
Apr 19, 2020
| @@ -299,6 +299,9 @@ impl Iterator for LookupHost { | |||
| fn next(&mut self) -> Option<SocketAddr> { | |||
| match self.0 {} | |||
| } | |||
| fn size_hint(&self) -> (usize, Option<usize>) { | |||
There was a problem hiding this comment.
All of these are uninhabited as well.
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
|
I don't see much gain from this though.. guess i'll close it for now :D |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #49205
Rework of #49552