Implement size_hint on various sys iterators #49552

Phlosioneer · 2018-04-01T06:44:32Z

Continuation of #49205

Continuation of rust-lang#49205

shepmaster · 2018-04-07T20:01:13Z

Ping from triage, @Kimundi !

pietroalbini · 2018-04-16T10:25:03Z

Ping from triage! Can @Kimundi (or someone else from @rust-lang/libs) review this?

Kimundi

Sorry for the delay.

I assume the (0, Some(0)) size_hints are for platforms where no sensible implementation is possible? Could you explain real quick why this is the case for each of the platforms?
Two of the size_hints seem to iterate over the internal iterator. I'm not currently aware if that's a thing we do at other places, or wether we try hard to just do constant-time operations in them. Could you explain why you implemented it like this?

Kimundi · 2018-04-16T10:32:17Z

src/libstd/sys/windows/os.rs

+        // There will be at most N + 1 entries, where N is the number of
+        // remaining semicolons.
+        let data = self.data.clone();
+        let semicolons = data.filter(|b| b == (';' as u16)).count();


Hm, is it a good idea for the size_hint calculation to actually iterate over the data? Or am I misunderstanding what is happening here?

This is definitely controversial / not obvious. My motivation to iterate over the data to calculate the size is because, in this case, we have a static guarantee that the thing being iterated over is in-memory, and that iterating over it will have no side-effects. Further, the iterator is over the number of entries in a directory, which is inherently bounded; and it's particularly common to collect the result of a dir entry iterator.

Kimundi · 2018-04-16T10:37:54Z

src/libstd/sys/redox/fs.rs

+            .count();
+        let lower = upper.saturating_sub(2);
+        (lower, Some(upper))
+    }


Same question about iteration here.

Phlosioneer · 2018-04-16T20:39:41Z

The (0, Some(0)) size hints are not there because "no sensible implementation is possible" - they're because there is no implementation. In that sense, they are technically ExactSizeIterators.

pietroalbini · 2018-04-23T10:34:47Z

Ping from triage @Kimundi! The PR author replied to you.

Kimundi · 2018-04-23T10:41:42Z

@bors r+

bors · 2018-04-23T10:41:43Z

📌 Commit e50fb63 has been approved by Kimundi

bors · 2018-04-23T22:50:23Z

⌛ Testing commit e50fb63 with merge 94d38d4155c12531f6d8e98fc851a7bdc7b046d2...

bors · 2018-04-23T22:57:56Z

💔 Test failed - status-appveyor

rust-highfive · 2018-04-23T22:58:08Z

The job mingw-check of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/54/a0/dd89b5ae729ac8aeeb446622604e49c2bd97b7fef3d48f2da2d3bb524e55/awscli-1.15.7-py2.py3-none-any.whl (1.3MB)
/usr/local/lib/python2.7/dist-packages/pip/_vendor/requests/packages/urllib3/util/ssl_.py:122: InsecurePlatformWarning: A true SSLContext object is not available. This prevents urllib3 from configuring SSL appropriately and may cause certain SSL connections to fail. You can upgrade to a newer version of Python to solve this. For more information, see https://urllib3.readthedocs.io/en/latest/security.html#insecureplatformwarning.
  InsecurePlatformWarning
  Downloading https://files.pythonhosted.org/packages/76/98/b3772fa3aa70d441acfcaf41385b8dc1d0fe4a72e42ac8b020e6aab6e891/botocore-1.10.7-py2.py3-none-any.whl (4.2MB)
Collecting rsa<=3.5.0,>=3.1.2 (from awscli)
---
[00:03:55] [RUSTC-TIMING] alloc_jemalloc test:false 0.191
[00:04:02] [RUSTC-TIMING] alloc test:false 6.816
[00:04:02]    Compiling panic_unwind v0.0.0 (file:///checkout/src/libpanic_unwind)
[00:04:02] [RUSTC-TIMING] panic_unwind test:false 0.271
[00:04:07] error[E0277]: the trait bound `&u16: core::cmp::PartialEq<u16>` is not satisfied
[00:04:07]    --> libstd/sys/windows/os.rs:200:44
[00:04:07]     |
[00:04:07] 200 |         let semicolons = data.filter(|b| b == (';' as u16)).count();
[00:04:07]     |                                            ^^ can't compare `&u16` with `u16`
[00:04:07]     |
[00:04:07]     = help: the trait `core::cmp::PartialEq<u16>` is not implemented for `&u16`
[00:04:07] error: aborting due to previous error
[00:04:07] 
[00:04:07] For more information about this error, try `rustc --explain E0277`.
[00:04:07] [RUSTC-TIMING] std test:false 4.908
[00:04:07] [RUSTC-TIMING] std test:false 4.908
[00:04:07] error: Could not compile `std`.
[00:04:07] 
[00:04:07] Caused by:
[00:04:07]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name std libstd/lib.rs --color always --error-format json --crate-type dylib --crate-type rlib --emit=dep-info,metadata -C prefer-dynamic -C debug-assertions=off -C overflow-checks=on --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" -C metadata=468968c2dfd1f66f -C extra-filename=-468968c2dfd1f66f --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps --target i686-pc-windows-gnu -C incremental=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/incremental -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/release/deps --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libcore-8b3bce652622b235.rmeta --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libstd_unicode-830d2308368f417f.rmeta --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libpanic_unwind-f3e7c3dc7c2708ab.rmeta --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libunwind-58ef4a4c55193d82.rmeta --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/liballoc_jemalloc-d183733f4d204e62.rmeta --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/liballoc-f6e9049eef93479d.rmeta --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libpanic_abort-74a515719294f544.rmeta --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/libcompiler_builtins-2c84d9450866a271.rmeta --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/liballoc_system-372ef3f14ce624b1.rmeta --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/deps/liblibc-d8f546a38c967152.rmeta -L native=/checkout/obj/build/i686-pc-windows-gnu/native/libbacktrace/.libs -l static=backtrace -l advapi32 -l ws2_32 -l userenv -l shell32 -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage0-std/i686-pc-windows-gnu/release/build/compiler_builtins-62bfd7e355d8aacf/out -L native=/checkout/obj/build/i686-pc-windows-gnu/native/jemalloc/lib` (exit code: 101)

[00:04:07] travis_time:end:stage0-std:start=1524524164647791195,finish=1524524209481970929,duration=44834179734


[00:04:07] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "check" "--target" "i686-pc-windows-gnu" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[00:04:07] expected success, got: exit code: 101
[00:04:07] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[00:04:07] failed to run: /checkout/obj/build/bootstrap/debug/bootstrap check --target=i686-pc-windows-gnu --host=i686-pc-windows-gnu
[00:04:07] Build completed unsuccessfully in 0:00:46
travis_time:end:1290e298:start=1524523962213070174,finish=1524524209741363438,duration=247528293264

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Kimundi · 2018-04-25T09:44:07Z

@bors retry

Phlosioneer · 2018-05-02T23:07:37Z

Still waiting on bors...

shepmaster · 2018-05-03T02:53:37Z

@bors r=Kimundi

bors · 2018-05-03T02:53:38Z

📌 Commit 29ec498 has been approved by Kimundi

bors · 2018-05-03T04:25:00Z

⌛ Testing commit 29ec498 with merge 80e787ba93870b7474a2f406fcd7e3ff22ad0f11...

bors · 2018-05-03T05:38:07Z

💔 Test failed - status-travis

rust-highfive · 2018-05-03T05:38:09Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:10:41] 
[01:10:41] error[E0425]: cannot find value `i` in this scope
[01:10:41]    --> libstd/sys/redox/fs.rs:174:32
[01:10:41]     |
[01:10:41] 174 |         let upper = self.data[(i + 1)..].iter()
[01:10:41]     |                                ^ help: try: `self.i`
[01:10:41] 
[01:10:44] error[E0277]: the trait bound `&&u8: core::cmp::PartialEq<u8>` is not satisfied
[01:10:44]    --> libstd/sys/redox/fs.rs:175:33
[01:10:44]     |
[01:10:44] 175 |             .filter(|byte| byte == b'\n')
[01:10:44]     |                                 ^^ can't compare `&&u8` with `u8`
[01:10:44]     |
[01:10:44]     = help: the trait `core::cmp::PartialEq<u8>` is not implemented for `&&u8`
[01:10:44] error: aborting due to 2 previous errors
[01:10:44] 
[01:10:44] Some errors occurred: E0277, E0425.
[01:10:44] For more information about an error, try `rustc --explain E0277`.
[01:10:44] For more information about an error, try `rustc --explain E0277`.
[01:10:44] [RUSTC-TIMING] std test:false 3.659
[01:10:44] error: Could not compile `std`.
[01:10:44] 
[01:10:44] Caused by:
[01:10:44]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name std libstd/lib.rs --color always --error-format json --crate-type dylib --crate-type rlib --emit=dep-info,link -C prefer-dynamic -C opt-level=3 --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" -C metadata=d76f05f9c3d5b8d7 -C extra-filename=-d76f05f9c3d5b8d7 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps --target x86_64-unknown-redox -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libcompiler_builtins-469e43b4d14111bc.rlib --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libstd_unicode-203a18552228315c.rlib --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc_jemalloc-7625c0c6ecb8ea45.rlib --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc-c76fe45e7a577193.rlib --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libunwind-21d76117e79c3f0e.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libcore-83234ee7fc2192a2.rlib --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libpanic_unwind-3c9d143744128f78.rlib --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libpanic_abort-22fef0215914bac1.rlib --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc_system-9feb6a57bde20c89.rlib --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liblibc-38812fa12d8f5729.rlib -L native=/checkout/obj/build/x86_64-unknown-redox/native/libbacktrace/.libs -l static=backtrace -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/build/compiler_builtins-2f812540b55ccc61/out` (exit code: 101)
[01:10:44] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-redox" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[01:10:44] expected success, got: exit code: 101
[01:10:44] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[01:10:44] travis_fold:end:stage2-std

[01:10:44] travis_time:end:stage2-std:start=1525325793802945326,finish=1525325848177816514,duration=54374871188

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

rust-highfive · 2018-05-03T05:38:14Z

The job dist-various-1 of your PR failed on Travis (raw log). Through arcane magic we have determined that the following fragments from the build log may contain information about the problem.

Click to expand the log.

[01:10:41] 
[01:10:41] error[E0425]: cannot find value `i` in this scope
[01:10:41]    --> libstd/sys/redox/fs.rs:174:32
[01:10:41]     |
[01:10:41] 174 |         let upper = self.data[(i + 1)..].iter()
[01:10:41]     |                                ^ help: try: `self.i`
[01:10:41] 
[01:10:44] error[E0277]: the trait bound `&&u8: core::cmp::PartialEq<u8>` is not satisfied
[01:10:44]    --> libstd/sys/redox/fs.rs:175:33
[01:10:44]     |
[01:10:44] 175 |             .filter(|byte| byte == b'\n')
[01:10:44]     |                                 ^^ can't compare `&&u8` with `u8`
[01:10:44]     |
[01:10:44]     = help: the trait `core::cmp::PartialEq<u8>` is not implemented for `&&u8`
[01:10:44] error: aborting due to 2 previous errors
[01:10:44] 
[01:10:44] Some errors occurred: E0277, E0425.
[01:10:44] For more information about an error, try `rustc --explain E0277`.
[01:10:44] For more information about an error, try `rustc --explain E0277`.
[01:10:44] [RUSTC-TIMING] std test:false 3.659
[01:10:44] error: Could not compile `std`.
[01:10:44] 
[01:10:44] Caused by:
[01:10:44]   process didn't exit successfully: `/checkout/obj/build/bootstrap/debug/rustc --crate-name std libstd/lib.rs --color always --error-format json --crate-type dylib --crate-type rlib --emit=dep-info,link -C prefer-dynamic -C opt-level=3 --cfg feature="alloc_jemalloc" --cfg feature="backtrace" --cfg feature="jemalloc" --cfg feature="panic-unwind" --cfg feature="panic_unwind" -C metadata=d76f05f9c3d5b8d7 -C extra-filename=-d76f05f9c3d5b8d7 --out-dir /checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps --target x86_64-unknown-redox -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps -L dependency=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/release/deps --extern compiler_builtins=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libcompiler_builtins-469e43b4d14111bc.rlib --extern std_unicode=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libstd_unicode-203a18552228315c.rlib --extern alloc_jemalloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc_jemalloc-7625c0c6ecb8ea45.rlib --extern alloc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc-c76fe45e7a577193.rlib --extern unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libunwind-21d76117e79c3f0e.rlib --extern core=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libcore-83234ee7fc2192a2.rlib --extern panic_unwind=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libpanic_unwind-3c9d143744128f78.rlib --extern panic_abort=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/libpanic_abort-22fef0215914bac1.rlib --extern alloc_system=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liballoc_system-9feb6a57bde20c89.rlib --extern libc=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/deps/liblibc-38812fa12d8f5729.rlib -L native=/checkout/obj/build/x86_64-unknown-redox/native/libbacktrace/.libs -l static=backtrace -L native=/checkout/obj/build/x86_64-unknown-linux-gnu/stage2-std/x86_64-unknown-redox/release/build/compiler_builtins-2f812540b55ccc61/out` (exit code: 101)
[01:10:44] command did not execute successfully: "/checkout/obj/build/x86_64-unknown-linux-gnu/stage0/bin/cargo" "build" "--target" "x86_64-unknown-redox" "-j" "4" "--release" "--locked" "--color" "always" "--features" "panic-unwind jemalloc backtrace" "--manifest-path" "/checkout/src/libstd/Cargo.toml" "--message-format" "json"
[01:10:44] expected success, got: exit code: 101
[01:10:44] thread 'main' panicked at 'cargo must succeed', bootstrap/compile.rs:1091:9
[01:10:44] travis_fold:end:stage2-std

[01:10:44] travis_time:end:stage2-std:start=1525325793802945326,finish=1525325848177816514,duration=54374871188

I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact @TimNN. (Feature Requests)

Phlosioneer · 2018-05-03T05:54:43Z

@TimNN duplicate posts

I'll look into the errors when I have time

pietroalbini · 2018-05-10T12:32:15Z

Weekly ping from triage @Phlosioneer! Will you be able to look into the errors soon?

pietroalbini · 2018-05-21T10:42:46Z

Thank you for this PR @Phlosioneer! Unfortunately we haven't heard from you on this in a while, so I'm closing the PR to keep things tidy. Don't worry though, if you'll have time again in the future please reopen this PR, we'll be happy to review it again!

Implement size_hint on various sys iterators

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.

GPG key ID: 4AEE18F83AFDEB23
Expired

Verified
Learn about vigilant mode

e50fb63

Continuation of rust-lang#49205

rust-highfive assigned Kimundi Apr 1, 2018

Phlosioneer mentioned this pull request Apr 1, 2018

Tracking issue for missing Iterator::size_hint implementations #49205

Closed

62 tasks

pietroalbini added the S-waiting-on-review label Apr 2, 2018

Ixrec mentioned this pull request Apr 4, 2018

Add size_hints for btree iterators #49550

Closed

pietroalbini added the T-libs-api label Apr 16, 2018

Kimundi reviewed Apr 16, 2018

View reviewed changes

pietroalbini added S-waiting-on-author and removed S-waiting-on-review labels Apr 16, 2018

pietroalbini added S-waiting-on-review and removed S-waiting-on-author labels Apr 23, 2018

bors added S-waiting-on-bors and removed S-waiting-on-review labels Apr 23, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels Apr 23, 2018

kennytm added S-waiting-on-author and removed S-waiting-on-review labels Apr 24, 2018

Fix reference error

29ec498

bors removed the S-waiting-on-author label Apr 25, 2018

bors added the S-waiting-on-bors label Apr 25, 2018

bors added S-waiting-on-review and removed S-waiting-on-bors labels May 3, 2018

kennytm added S-waiting-on-author and removed S-waiting-on-review labels May 3, 2018

TimNN mentioned this pull request May 8, 2018

RLA sometimes posts twice rust-lang/rust-log-analyzer#17

Closed

pietroalbini closed this May 21, 2018

pietroalbini added S-inactive and removed S-waiting-on-author labels May 21, 2018

Dylan-DPC-zz mentioned this pull request Apr 19, 2020

implement size_hint on sys iterators #71308

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Implement size_hint on various sys iterators #49552

Implement size_hint on various sys iterators #49552

Phlosioneer commented Apr 1, 2018

shepmaster commented Apr 7, 2018

pietroalbini commented Apr 16, 2018

Kimundi left a comment

Kimundi Apr 16, 2018

Phlosioneer Apr 16, 2018

Kimundi Apr 16, 2018

Phlosioneer commented Apr 16, 2018

pietroalbini commented Apr 23, 2018

Kimundi commented Apr 23, 2018

bors commented Apr 23, 2018

bors commented Apr 23, 2018

bors commented Apr 23, 2018

rust-highfive commented Apr 23, 2018

Kimundi commented Apr 25, 2018

Phlosioneer commented May 2, 2018

shepmaster commented May 3, 2018

bors commented May 3, 2018

bors commented May 3, 2018

bors commented May 3, 2018

rust-highfive commented May 3, 2018

rust-highfive commented May 3, 2018

Phlosioneer commented May 3, 2018

pietroalbini commented May 10, 2018

pietroalbini commented May 21, 2018

Implement size_hint on various sys iterators #49552

Implement size_hint on various sys iterators #49552

Conversation

Phlosioneer commented Apr 1, 2018

shepmaster commented Apr 7, 2018

pietroalbini commented Apr 16, 2018

Kimundi left a comment

Choose a reason for hiding this comment

Kimundi Apr 16, 2018

Choose a reason for hiding this comment

Phlosioneer Apr 16, 2018

Choose a reason for hiding this comment

Kimundi Apr 16, 2018

Choose a reason for hiding this comment

Phlosioneer commented Apr 16, 2018

pietroalbini commented Apr 23, 2018

Kimundi commented Apr 23, 2018

bors commented Apr 23, 2018

bors commented Apr 23, 2018

bors commented Apr 23, 2018

rust-highfive commented Apr 23, 2018

Kimundi commented Apr 25, 2018

Phlosioneer commented May 2, 2018

shepmaster commented May 3, 2018

bors commented May 3, 2018

bors commented May 3, 2018

bors commented May 3, 2018

rust-highfive commented May 3, 2018

rust-highfive commented May 3, 2018

Phlosioneer commented May 3, 2018

pietroalbini commented May 10, 2018

pietroalbini commented May 21, 2018