-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rollup of 7 pull requests #71410
Rollup of 7 pull requests #71410
Commits on Apr 20, 2020
-
Configuration menu - View commit details
-
Copy full SHA for 33905ad - Browse repository at this point
Copy the full SHA 33905adView commit details -
Configuration menu - View commit details
-
Copy full SHA for fae4e2a - Browse repository at this point
Copy the full SHA fae4e2aView commit details -
Suggest
-> impl Trait
and-> Box<dyn Trait>
on fn that doesn't re……turn During development, a function could have a return type set that is a bare trait object by accident. We already suggest using either a boxed trait object or `impl Trait` if the return paths will allow it. We now do so too when there are *no* return paths or they all resolve to `!`. We still don't handle cases where the trait object is *not* the entirety of the return type gracefully.
Configuration menu - View commit details
-
Copy full SHA for d3c96f0 - Browse repository at this point
Copy the full SHA d3c96f0View commit details -
Ensure tail expression will have a
Ty
for E0746When the return type is `!Sized` we look for all the returned expressions in the body to fetch their types and provide a reasonable suggestion. The tail expression of the body is normally evaluated after checking whether the return type is `Sized`. Changing the order of the evaluation produces undesirable knock down effects, so we detect the specific case that newcomers are likely to encounter ,returning a single bare trait object, and only in that case we evaluate the tail expression's type so that the suggestion will be accurate.
Configuration menu - View commit details
-
Copy full SHA for e536257 - Browse repository at this point
Copy the full SHA e536257View commit details -
Configuration menu - View commit details
-
Copy full SHA for 9fc0833 - Browse repository at this point
Copy the full SHA 9fc0833View commit details -
Configuration menu - View commit details
-
Copy full SHA for 4ddf661 - Browse repository at this point
Copy the full SHA 4ddf661View commit details -
Configuration menu - View commit details
-
Copy full SHA for 6850e4a - Browse repository at this point
Copy the full SHA 6850e4aView commit details -
Configuration menu - View commit details
-
Copy full SHA for 9af047f - Browse repository at this point
Copy the full SHA 9af047fView commit details
Commits on Apr 21, 2020
-
Fix #! (shebang) stripping account space issue rust-lang#70528
Ayush Kumar Mishra committedApr 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 0315864 - Browse repository at this point
Copy the full SHA 0315864View commit details -
Refactoring and added test-cases rust-lang#70528
Ayush Kumar Mishra committedApr 21, 2020 Configuration menu - View commit details
-
Copy full SHA for ee5a212 - Browse repository at this point
Copy the full SHA ee5a212View commit details -
Ayush Kumar Mishra committed
Apr 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 365b3cc - Browse repository at this point
Copy the full SHA 365b3ccView commit details -
Configuration menu - View commit details
-
Copy full SHA for 20de922 - Browse repository at this point
Copy the full SHA 20de922View commit details -
Configuration menu - View commit details
-
Copy full SHA for e2901c4 - Browse repository at this point
Copy the full SHA e2901c4View commit details -
Ayush Kumar Mishra committed
Apr 21, 2020 Configuration menu - View commit details
-
Copy full SHA for 1b362cd - Browse repository at this point
Copy the full SHA 1b362cdView commit details -
Configuration menu - View commit details
-
Copy full SHA for 410fc9d - Browse repository at this point
Copy the full SHA 410fc9dView commit details
Commits on Apr 22, 2020
-
Rollup merge of rust-lang#70998 - estebank:suggest-impl-trait-empty-f…
…n, r=varkor Suggest `-> impl Trait` and `-> Box<dyn Trait>` on fn that doesn't return During development, a function could have a return type set that is a bare trait object by accident. We already suggest using either a boxed trait object or `impl Trait` if the return paths will allow it. We now do so too when there are *no* return paths or they all resolve to `!`. We still don't handle cases where the trait object is *not* the entirety of the return type gracefully. Closes rust-lang#38376.
Configuration menu - View commit details
-
Copy full SHA for 24fb393 - Browse repository at this point
Copy the full SHA 24fb393View commit details -
Rollup merge of rust-lang#71236 - sinkuu:cleanup, r=nikomatsakis
Remove unused rustc_serialize::hex module * Remove unused `rustc_serialize::hex` module * Cleanup `Cargo.toml`
Configuration menu - View commit details
-
Copy full SHA for 567e54f - Browse repository at this point
Copy the full SHA 567e54fView commit details -
Rollup merge of rust-lang#71366 - faern:use-assoc-int-consts3, r=dtolnay
Use assoc int consts3 Define module level int consts with associated constants instead of `min_value()` and `max_value()`. So the code become consistent with what the docs recommend etc. Seems natural. Also remove the last usages of the int module constants from this repo (except src/test/ directory which I have still not really done anything in). Some places were missed in the previous PRs because the code uses `crate::<IntTy>` to reach the constants. This is a continuation of rust-lang#70857 r? @dtolnay
Configuration menu - View commit details
-
Copy full SHA for f28e387 - Browse repository at this point
Copy the full SHA f28e387View commit details -
Rollup merge of rust-lang#71372 - ayushmishra2005:shebang_stripping, …
…r=estebank Fix #! (shebang) stripping account space issue rust-lang#70528
Configuration menu - View commit details
-
Copy full SHA for 46a8dce - Browse repository at this point
Copy the full SHA 46a8dceView commit details -
Rollup merge of rust-lang#71384 - RalfJung:RalfJung-patch-1, r=Mark-S…
…imulacrum Fix stage0.txt version number comment r? @Mark-Simulacrum
Configuration menu - View commit details
-
Copy full SHA for 836a64a - Browse repository at this point
Copy the full SHA 836a64aView commit details -
Rollup merge of rust-lang#71390 - aticu:master, r=Dylan-DPC
Fix incorrect description of E0690 r? @steveklabnik
Configuration menu - View commit details
-
Copy full SHA for 3efa70f - Browse repository at this point
Copy the full SHA 3efa70fView commit details -
Rollup merge of rust-lang#71399 - rust-lang:cleanup-e0554, r=Dylan-DPC
Clean up E0554 explanation r? @Dylan-DPC
Configuration menu - View commit details
-
Copy full SHA for 66eaead - Browse repository at this point
Copy the full SHA 66eaeadView commit details