Experimentally add ffi_const and ffi_pure extern fn attributes
#71718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Some changes occurred in diagnostic error codes |
rust-highfive
added
the
S-waiting-on-review
|
Unfortunately I'm too swamped with non-Rust work to take on any more reviews at this time. |
|
☔ The latest upstream changes (presumably #69274) made this pull request unmergeable. Please resolve the merge conflicts. |
|
☔ The latest upstream changes (presumably #71828) made this pull request unmergeable. Please resolve the merge conflicts. |
joelpalmer
added
S-waiting-on-review
|
☔ The latest upstream changes (presumably #69171) made this pull request unmergeable. Please resolve the merge conflicts. |
Introduce function attribute corresponding to the `const`/`pure` attributes supported by GCC, clang and other compilers. Based on the work of gnzlbg <gonzalobg88@gmail.com>.
Based on the work of gnzlbg <gonzalobg88@gmail.com>.
…able book Based on the work of gnzlbg <gonzalobg88@gmail.com>.
|
@bors r+ |
|
📌 Commit a114a23 has been approved by |
bors
added
S-waiting-on-bors
RalfJung
added a commit
to RalfJung/rust
that referenced
this pull request
May 21, 2020
Experimentally add `ffi_const` and `ffi_pure` extern fn attributes Add FFI function attributes corresponding to clang/gcc/... `const` and `pure`. Rebased version of rust-lang#58327 by @gnzlbg with the following changes: - Switched back from the `c_ffi_const` and `c_ffi_pure` naming to `ffi_const` and `ffi_pure`, as I agree with rust-lang#58327 (comment) and this nicely aligns with `ffi_returns_twice` - (Hopefully) took care of all of @hanna-kruppe's change requests in the original PR r? @hanna-kruppe
|
☀️ Test successful - checks-azure |
This was referenced May 21, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add FFI function attributes corresponding to clang/gcc/...
constandpure.Rebased version of #58327 by @gnzlbg with the following changes:
c_ffi_constandc_ffi_purenaming toffi_constandffi_pure, as I agree with Experimentally addffi_constandffi_pureextern fn attributes #58327 (comment) and this nicely aligns withffi_returns_twicer? @hanna-kruppe