Remove old util/liveness.rs module
#71993
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The liveness dataflow analysis now lives in `librustc_mir/dataflow/impls/liveness.rs`. The borrow-checker has an abstraction around of "defs" and "uses" that I've made module private. I would have moved it to `util/def_use.rs`, but there's a slightly different abstraction used for copy propagation with that name.
|
r? @cramertj (rust_highfive has picked a reviewer for you, use r? to override) |
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ |
|
📌 Commit 046848e has been approved by |
|
🌲 The tree is currently closed for pull requests below priority 100, this pull request will be tested once the tree is reopened |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 8, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#71989 (Use a single enum for the kind of a const context) - rust-lang#71993 (Remove old `util/liveness.rs` module) - rust-lang#71999 (Add myself to mailmap.) - rust-lang#72001 (Adjust cfg(version) to lang team decision) - rust-lang#72007 (Fix some tests failing in `--pass check` mode) - rust-lang#72008 (Add const-generics test) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The liveness dataflow analysis now lives in the
dataflowmodule, so this one is no longer necessary. I've copied the relevant bits of the module docs forutil::livenesstoMaybeLiveLocals. The example in the docs is now amir-dataflowtest:rust/src/test/ui/mir-dataflow/liveness-ptr.rs
Lines 6 to 26 in a08c473
The borrow-checker used the same notion of "defs" and "uses", so I've moved it into a submodule. I would have moved it to
util/def_use.rs, since it seems generally useful, but there's already a slightly different version of the same abstraction needed for copy propagation.