exhaustively check ty::Kind during structural match checking
#72153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
Best way to check that: make them
If it's not possible, best to
Yeah... |
RalfJung
reviewed
May 12, 2020
RalfJung
reviewed
May 12, 2020
RalfJung
reviewed
May 12, 2020
This comment has been minimized.
This comment has been minimized.
RalfJung
reviewed
May 13, 2020
RalfJung
reviewed
May 13, 2020
RalfJung
reviewed
May 13, 2020
|
@bors r+ rollup |
|
📌 Commit 60d9df2 has been approved by |
bors
added
S-waiting-on-bors
Dylan-DPC-zz
pushed a commit
to Dylan-DPC-zz/rust
that referenced
this pull request
May 20, 2020
exhaustively check `ty::Kind` during structural match checking This was prone to errors as we may forget new kinds in the future. I am also not yet sure about some kinds. `ty::GeneratorWitness(..) | ty::Infer(_) | ty::Placeholder(_) | ty::UnnormalizedProjection(..) | ty::Bound(..)` might be unreachable here. We may want to forbid `ty::Projection`, similar to `ty::Param`. `ty::Opaque` seems fine afaict, should not be possible in a match atm. I believe `ty::Foreign` should not be structurally match, as I don't even know what that would actually mean. r? @pnkfelix cc @eddyb
|
@bors r- |
bors
added
S-waiting-on-author
|
rebased |
lcnr
added
S-waiting-on-review
|
@pnkfelix Can you once again review/r+ this? |
|
@bors r=pnkfelix |
|
📌 Commit a5a4ec9 has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 25, 2020
Rollup of 4 pull requests Successful merges: - rust-lang#72153 (exhaustively check `ty::Kind` during structural match checking) - rust-lang#72308 (Emit a better diagnostic when function actually has a 'self' parameter) - rust-lang#72560 (Enable `glacier` command via triagebot) - rust-lang#72567 (Clean up E0608 explanation) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was prone to errors as we may forget new kinds in the future.
I am also not yet sure about some kinds.
ty::GeneratorWitness(..) | ty::Infer(_) | ty::Placeholder(_) | ty::UnnormalizedProjection(..) | ty::Bound(..)might be unreachable here.We may want to forbid
ty::Projection, similar toty::Param.ty::Opaqueseems fine afaict, should not be possible in a match atm.I believe
ty::Foreignshould not be structurally match, as I don't even know whatthat would actually mean.
r? @pnkfelix cc @eddyb