JS cleanup #72294
Merged
JS cleanup #72294
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
kinnison
reviewed
May 19, 2020
src/librustdoc/html/static/main.js
Outdated
|
|
||
| url += "/" + document.getElementsByClassName("version-selector")[0].value + stripped; | ||
| url += "/" + document.getElementsByClassName("version-selector")[0].value + stripped; |
There was a problem hiding this comment.
I think tidy dislikes this line.
| @@ -450,7 +450,7 @@ function defocusSearchBar() { | |||
| set_fragment(cur_line_id); | |||
| } | |||
| } | |||
| })(); | |||
| }()); | |||
There was a problem hiding this comment.
While this isn't bad, it seems spurious in a "move code" commit rather than a cleanup one. You can just resolve this if you don't care, otherwise move it to a different commit when you next rebase.
hbina
reviewed
May 19, 2020
| @@ -27,14 +27,15 @@ function removeClass(elem, className) { | |||
| function onEach(arr, func, reversed) { | |||
| if (arr && arr.length > 0 && func) { | |||
| var length = arr.length; | |||
| var i; | |||
There was a problem hiding this comment.
Is this really necessary? Each i is local to the loop so declaring it out here makes reasoning the loop harder.
Edit: Also, is there a fold construct in JS? This simple loop can be made even simpler with that.
There was a problem hiding this comment.
JS vars don't seem to understand the principle of scope. :)
There was a problem hiding this comment.
In JS a var is hoisted to the top of the function. The new let and const don't have this behavior.
There was a problem hiding this comment.
re: fold, yes, browsers implemented Array.prototype.reduce() a long time ago.
https://developer.mozilla.org/en-US/docs/Web/JavaScript/Reference/Global_Objects/Array/reduce
Much like Iter and for loops are equivalent perf in Rust, reduce and map are equivalent in performance to for loops in JS for similar reasons. They are, however, eagerly evaluated! Not lazy.
|
☔ The latest upstream changes (presumably #72422) made this pull request unmergeable. Please resolve the merge conflicts. |
bors
added
the
S-waiting-on-author
GuillaumeGomez
force-pushed
the
js-cleanup
branch
from
867b5e6
to
bea0ef9
Compare
|
The job Click to expand the log.I'm a bot! I can only do what humans tell me to, so if this was not helpful or you have suggestions for improvements, please ping or otherwise contact |
GuillaumeGomez
force-pushed
the
js-cleanup
branch
from
bea0ef9
to
398511a
Compare
|
@bors: r=kinnison |
|
📌 Commit 398511a has been approved by |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
May 26, 2020
Rollup of 6 pull requests Successful merges: - rust-lang#72270 (add a lint against references to packed fields) - rust-lang#72294 (JS cleanup) - rust-lang#72342 (Warn about unused crate deps) - rust-lang#72401 (Use correct function for detecting `const fn` in unsafety checking) - rust-lang#72581 (Allow unlabeled breaks from desugared `?` in labeled blocks) - rust-lang#72592 (Update books) Failed merges: r? @ghost
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal here is just to improve the source code a bit. I recommend to review one commit at a time, otherwise it might not make much sense. :)
The biggest commit is the second one: to prevent to have "global" variables declared in
main.js(and thus prevent name conflict or overwriting), I moved such code into anonymous functions.r? @kinnison
cc @rust-lang/rustdoc