Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid setting wrong obligation cause span of associated type mismatch #72807

Merged
merged 2 commits into from
Jun 1, 2020

Conversation

xiaotianrandom
Copy link

@xiaotianrandom xiaotianrandom commented May 31, 2020

Removes code that sets wrong obligation cause span of associated type mismatch. See the linked issue for details.

Closes #72806.

@rust-highfive
Copy link
Collaborator

Thanks for the pull request, and welcome! The Rust team is excited to review your changes, and you should hear from @cramertj (or someone else) soon.

If any changes to this PR are deemed necessary, please add them as extra commits. This ensures that the reviewer can see what has changed since they last reviewed the code. Due to the way GitHub handles out-of-date commits, this should also make it reasonably obvious what issues have or haven't been addressed. Large or tricky changes may require several passes of review and changes.

Please see the contribution instructions for more information.

@rust-highfive rust-highfive added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. label May 31, 2020
@xiaotianrandom
Copy link
Author

r? @estebank

@rust-highfive rust-highfive assigned estebank and unassigned cramertj May 31, 2020
@estebank
Copy link
Contributor

@bors r+ rollup

@bors
Copy link
Contributor

bors commented May 31, 2020

📌 Commit 1a68c8e has been approved by estebank

@bors bors added S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. and removed S-waiting-on-review Status: Awaiting review from the assignee but also interested parties. labels May 31, 2020
@estebank
Copy link
Contributor

r? @estebank

bors added a commit to rust-lang-ci/rust that referenced this pull request May 31, 2020
Rollup of 5 pull requests

Successful merges:

 - rust-lang#72691 (Fix escape key handling)
 - rust-lang#72807 (Avoid setting wrong obligation cause span of associated type mismatch)
 - rust-lang#72812 (Miri tests: skip parts of test_char_range)
 - rust-lang#72829 (Clarify terms in doc comments)
 - rust-lang#72830 (Fix release notes for niche initialization change)

Failed merges:

r? @ghost
@bors bors merged commit 8e83a7e into rust-lang:master Jun 1, 2020
@xiaotianrandom xiaotianrandom deleted the fix-assoc-type-diagnostics branch June 1, 2020 01:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Wrong obligation cause span of associated type mismatch
5 participants