Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rollup of 5 pull requests #72831

Merged
merged 12 commits into from
Jun 1, 2020
Merged

Rollup of 5 pull requests #72831

merged 12 commits into from
Jun 1, 2020

Conversation

Dylan-DPC-zz
Copy link

Successful merges:

Failed merges:

r? @ghost

GuillaumeGomez and others added 12 commits May 28, 2020 14:51
Doc comments of 'copy_from_slice' say that people should use 'clone_from_slice'
when 'src' doesn't implement 'Copy'. However, 'src' is a reference and
it always implements 'Copy'. The term 'src' should be fixed to 'T' in
the doc comments.

Thank you for reviewing this PR :)
MaybeUninit is not affected by the linked PR.
… r=kinnison

Fix escape key handling

Fixes rust-lang#72647.

The problem was that you could have a timeout just after the moment you press "escape", putting back the results.

r? @kinnison
…ostics, r=estebank

Avoid setting wrong obligation cause span of associated type mismatch

Removes code that sets wrong obligation cause span of associated type mismatch. See the linked issue for details.

Closes rust-lang#72806.
…hievink

Miri tests: skip parts of test_char_range

The new `test_char_range` test takes forever in Miri as it loops over all values of `char`. This makes it skip most of them when being run in Miri.
…evink

Clarify terms in doc comments

Doc comments of `copy_from_slice` say that people should use `clone_from_slice`
when 'src' doesn't implement `Copy`. However, 'src' is a reference and
it always implements `Copy`. The term 'src' should be fixed to `T`(element type of slice 'src') in
the doc comments.

Thank you for reviewing this PR :)  😺
…Simulacrum

Fix release notes for niche initialization change

MaybeUninit is not affected by the linked PR.
@Dylan-DPC-zz
Copy link
Author

@bors r+ rollup=never p=5

@bors
Copy link
Collaborator

bors commented May 31, 2020

📌 Commit 76e0ecc has been approved by Dylan-DPC

@bors bors added the S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion. label May 31, 2020
@bors
Copy link
Collaborator

bors commented May 31, 2020

⌛ Testing commit 76e0ecc with merge 0d93d3f...

@bors
Copy link
Collaborator

bors commented Jun 1, 2020

☀️ Test successful - checks-azure
Approved by: Dylan-DPC
Pushing 0d93d3f to master...

@bors bors added the merged-by-bors This PR was explicitly merged by bors. label Jun 1, 2020
@bors bors merged commit 0d93d3f into rust-lang:master Jun 1, 2020
@JohnTitor JohnTitor added the rollup A PR which is a rollup label Jun 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
merged-by-bors This PR was explicitly merged by bors. rollup A PR which is a rollup S-waiting-on-bors Status: Waiting on bors to run and complete tests. Bors will change the label on completion.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8 participants