Code

Rollup of 5 pull requests#73340

Code

Closed

Dylan-DPC-zz wants to merge 26 commits intorust-lang:masterrust-lang/rust:masterfrom Dylan-DPC-zz:rollup-0vm2o18Dylan-DPC-zz/rust:rollup-0vm2o18Copy head branch name to clipboard

+652-166

Commits

Commits on Jun 7, 2020

• Added an example where explicitly dropping a lock is necessary/a good idea.

  poliorcetics

  committed
  95c4899

  Copy full SHA for 95c4899

• Improved the example to work with mutable data, providing a reason for the mutex holding it

  poliorcetics

  committed
  9c8f881

  Copy full SHA for 9c8f881

Commits on Jun 8, 2020

• Simply use drop instead of std::mem::drop

  Show description for fdef1a5
  

  poliorcetics

  and

  LeSeulArtichaut

  authored
  fdef1a5

  Copy full SHA for fdef1a5

Commits on Jun 9, 2020

• Remove a lot of unecessary/duplicated comments

  poliorcetics

  committed
  1312d30

  Copy full SHA for 1312d30

Commits on Jun 10, 2020

• On recursive ADT, provide indirection structured suggestion

  estebank

  committed
  c29b3fa

  Copy full SHA for c29b3fa

• review comments: only suggest one substitution

  estebank

  committed
  7cde07e

  Copy full SHA for 7cde07e

• fix rebase

  estebank

  committed
  03552ec

  Copy full SHA for 03552ec

Commits on Jun 13, 2020

• Revert heterogeneous SocketAddr PartialEq impls

  Show description for c45231c
  dtolnay

  committed
  c45231c

  Copy full SHA for c45231c

• lint: normalize projections using opaque types

  Show description for 4ff1678
  davidtwco

  committed
  4ff1678

  Copy full SHA for 4ff1678

• Apply suggestions from code review

  Show description for f747073
  

  poliorcetics

  and

  dtolnay

  authored
  f747073

  Copy full SHA for f747073

• Clarify the scope-related explanation

  Show description for 34b3ff0
  poliorcetics

  authored
  34b3ff0

  Copy full SHA for 34b3ff0

• Rewrap comments in Mutex example

  dtolnay

  committed
  c010e71

  Copy full SHA for c010e71

• Add test for comparing SocketAddr with inferred right-hand side

  dtolnay

  committed
  204c236

  Copy full SHA for 204c236

• Move check_op logic to ops module

  ecstatic-morse

  committed
  cecfa43

  Copy full SHA for cecfa43

• Make Qualifs getters public

  ecstatic-morse

  committed
  d73674e

  Copy full SHA for d73674e

• Add feature gate for precise live drop checking

  ecstatic-morse

  committed
  a77f046

  Copy full SHA for a77f046

• Add CheckLiveDrops pass

  ecstatic-morse

  committed
  f5370fa

  Copy full SHA for f5370fa

• Add MIR phase and query for drop elaboration

  ecstatic-morse

  committed
  a43e486

  Copy full SHA for a43e486

• Ensure that drop_elaboration_and_check_consts runs for all const items

  ecstatic-morse

  committed
  21ddf4d

  Copy full SHA for 21ddf4d

• Update incorrect error code docs

  ecstatic-morse

  committed
  9e2ee32

  Copy full SHA for 9e2ee32

• Add tests for const_precise_live_drops

  ecstatic-morse

  committed
  2dcf7db

  Copy full SHA for 2dcf7db

Commits on Jun 14, 2020

• Rollup merge of rust-lang#71824 - ecstatic-morse:const-check-post-drop-elab, r=oli-obk

  Show description for 1fd1d45
  Dylan-DPC

  authored
  1fd1d45

  Copy full SHA for 1fd1d45

• Rollup merge of rust-lang#72740 - estebank:recursive-indirection, r=matthewjasper

  Show description for f8b99dd
  Dylan-DPC

  authored
  f8b99dd

  Copy full SHA for f8b99dd

• Rollup merge of rust-lang#73104 - poliorcetics:explicit-mutex-drop-example, r=dtolnay

  Show description for e1d05a9
  Dylan-DPC

  authored
  e1d05a9

  Copy full SHA for e1d05a9

• Rollup merge of rust-lang#73287 - davidtwco:issue-73251-opaque-types-in-projections, r=estebank

  Show description for 30fc113
  Dylan-DPC

  authored
  30fc113

  Copy full SHA for 30fc113

• Rollup merge of rust-lang#73304 - dtolnay:socketeq, r=Mark-Simulacrum

  Show description for 6b54f86
  Dylan-DPC

  authored
  6b54f86

  Copy full SHA for 6b54f86