-
Notifications
You must be signed in to change notification settings - Fork 12.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Avoid "whitelist" #74127
Avoid "whitelist" #74127
Conversation
(rust_highfive has picked a reviewer for you, use r? to override) |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
The "third party config variable" was a comment. cc @steveklabnik and @nikomatsakis, I guess. The reaction to this PR demonstrates the reason this sort of change should be made sooner rather than later. |
r? @rust-lang/compiler |
Moderation note: Some of the comments already posted on this PR are completely inappropriate. While dissent is always encouraged, it must be provided in a constructive manner. Mixing it with personal attacks is not constructive and it will not be tolerated in official Rust community spaces. Given the nature of this PR, I am locking this PR with the intent that relevant stakeholders are given time to decide how they want to handle this first. It looks like that's probably @rust-lang/compiler. |
8daa312
to
401670a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few nits, but I am in favor of removing the term "whitelist" and moving to "allowlist" or other more precise terminology (big 👍 to "AssumeUsed" in particular). This doesn't look like it affects any "user visible" flags or anything like that, it's purely internal? (I would want to have some kind of "deprecation" for the old flags if there were any.)
99880e8
to
23f8cac
Compare
2b8657b
to
8081312
Compare
@bors r+ p=1 (bitrottyish) |
📌 Commit 62cf767 has been approved by |
Avoid "whitelist" Other terms are more inclusive and precise.
⌛ Testing commit 62cf767 with merge 2bba01db2eec0bab687b341af01c99cb1e7341fd... |
Avoid "whitelist" Other terms are more inclusive and precise.
@bors retry yield |
Avoid "whitelist" Other terms are more inclusive and precise.
This comment has been minimized.
This comment has been minimized.
whitelist = sys.argv[1:] | ||
if whitelist: | ||
tests = [test for test in tests if test in whitelist] | ||
listed = sys.argv[1:] |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
listed
sound like a bool to me. Could we change it to args
or arguments
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yea listed is abit weird word here args seems reasonable.
…arth Rollup of 19 pull requests Successful merges: - rust-lang#71322 (Accept tuple.0.0 as tuple indexing (take 2)) - rust-lang#72303 (Add core::future::{poll_fn, PollFn}) - rust-lang#73862 (Stabilize casts and coercions to `&[T]` in const fn) - rust-lang#73887 (stabilize const mem::forget) - rust-lang#73989 (adjust ub-enum test to be endianess-independent) - rust-lang#74045 (Explain effects of debugging options from config.toml) - rust-lang#74076 (Add `read_exact_at` and `write_all_at` to WASI's `FileExt`) - rust-lang#74099 (Add VecDeque::range* methods) - rust-lang#74100 (Use str::strip* in bootstrap) - rust-lang#74103 (Only add CFGuard on `windows-msvc` targets) - rust-lang#74109 (Only allow `repr(i128/u128)` on enum) - rust-lang#74122 (Start-up clean-up) - rust-lang#74125 (Correctly mark the ending span of a match arm) - rust-lang#74127 (Avoid "whitelist") - rust-lang#74129 (:arrow_up: rust-analyzer) - rust-lang#74135 (Update books) - rust-lang#74145 (Update rust-installer to latest version) - rust-lang#74161 (Fix disabled dockerfiles) - rust-lang#74162 (take self by value in ToPredicate) Failed merges: r? @ghost
This comment has been minimized.
This comment has been minimized.
Now that the PR has been merged and this PR seems to have attracted trolls, I'm going to lock it for good. As Niko said above, name improvements can be iterated on in follow up PRs. Thank you to everyone who participated in this PR constructively! |
Other terms are more inclusive and precise.