Rollup of 17 pull requests #74230
Closed
Rollup of 17 pull requests #74230
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Teymour Aldridge <42674621+teymour-aldridge@users.noreply.github.com>
This patch adds `VecDeque::range` and `VecDeque::range_mut` to provide iterators over a sub-range of a `VecDeque`. This behavior can be emulated with `skip` and `take`, but directly providing a `Range` is more ergonomic. This also partially makes up for `VecDeque`'s lack of `SliceIndex` support.
A function that has no prologue cannot be reasonably expected to support debuginfo. In fact, the existing code (before this patch) would generate invalid instructions that caused crashes. We can solve this easily by just not emitting the debuginfo in this case. Fixes rust-lang#42779 cc rust-lang#32408
This pulls in a fix for the install script on some tr(1) implementations, as well as an update to use `anyhow` instead of `failure` for error handling.
This adds `read_exact_at` and `write_all_at` to WASI's `FileExt`, similar to the Unix versions of the same names.
Rename the existing read_at/write_at to read_vectored_at/write_vectored_at, for consistency with libstd's read_vectored/write_vectored. And, introduce new read_at/write_at functions which take a single buffer, similar to all other targets which provide these functions, so this will make it easier for applications to share code between WASI and other targets. Note that WASI's FileExt is currently unstable.
Suggested by @bjorn3 Every RUN command creates a new overlay on top of the image as of before the RUN command. Using fewer RUN commands prevents intermediate overlays (which in this case would have contained the entire Linux source tree).
When the dockerfiles were moved into the host-x86_64 directory, paths for COPY commands were updated with the new host-x86_64/ prefix. This suggested that the intended context was src/ci/docker. However, the context for disabled docker images was src/ci/docker/host-x86_64. This broke the new paths and prevented src/ci/docker/scripts from being included in the context at all. This commit corrects this context allowing docker to find the files it needs for COPY commands.
It has a single call site and having it as a separate (higher-order!) function makes the code harder to read.
This makes the two versions (parallel and non-parallel) more similar to each other.
A couple of these are quite long, but they do a much better job of explaining what they do, which was non-obvious before.
This commit replaces the use of `trim_start_matches` because in `rustc -Vv` output there are no lines starting with multiple "release:".
|
@bors r+ p=30 rollup=never |
|
📌 Commit 6475176 has been approved by |
bors
added
the
S-waiting-on-bors
|
⌛ Testing commit 6475176 with merge 950fb228cfe5b6b008b3b0a7b21fb0cade64d940... |
|
💔 Test failed - checks-actions |
bors
added
S-waiting-on-review
|
@bors retry network |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6475176 with merge bf04e78300753264de115ed1eb8fb3e0c2421f76... |
|
💥 Test timed out |
bors
added
S-waiting-on-review
|
@bors retry |
bors
added
S-waiting-on-bors
|
⌛ Testing commit 6475176 with merge f4c29df54623294b311d53c8213920618563fc6d... |
|
It's the arm-android hang again
|
|
Okay, that's actually #74105 (comment) |
|
@bors r- retry yield |
bors
added
S-waiting-on-author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
&[T]in const fn #73862 (Stabilize casts and coercions to&[T]in const fn)read_exact_atandwrite_all_atto WASI'sFileExt#74076 (Addread_exact_atandwrite_all_atto WASI'sFileExt)windows-msvctargets #74103 (Only add CFGuard onwindows-msvctargets)repr(i128/u128)on enum #74109 (Only allowrepr(i128/u128)on enum)Failed merges:
r? @ghost