include backtrace folder in rust-src component #74520
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rust-highfive
added
the
S-waiting-on-review
|
@bors r+ p=1 This broke perf (though I fixed that without that, rust-lang/rustc-perf#693) but I suspect it'll break rust-analyzer and other similar tooling. We should maybe think about checking that rust-src can build std or something along those lines in CI. |
|
📌 Commit d7a36d8 has been approved by |
bors
added
S-waiting-on-bors
|
@bors rollup |
|
Sorry for the breakage! |
|
⌛ Testing commit d7a36d8 with merge decd538723a45cd490ece6b8bf040ef1d546e6b0... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
@bors retry p=5 Cargo's CI is also broken. |
bors
added
S-waiting-on-bors
|
⌛ Testing commit d7a36d8 with merge 157907fef84eafe3d595b9d3f4e7ec20b5e17854... |
|
💔 Test failed - checks-azure |
bors
added
S-waiting-on-review
|
That... is an unexpected failure! I guess it's presumably spurious, though, since this PR isn't touching anything related. @bors retry backtrace-debuginfo test trace does not match position list |
bors
added
S-waiting-on-bors
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 20, 2020
…arth Rollup of 9 pull requests Successful merges: - rust-lang#73618 (Documentation for the false keyword) - rust-lang#74486 (Improve Read::read_exact documentation) - rust-lang#74514 (Do not clobber RUSTDOCFLAGS) - rust-lang#74516 (do not try fetching the ancestors of errored trait impls) - rust-lang#74520 (include backtrace folder in rust-src component) - rust-lang#74523 (Improve documentation for `core::fmt` internals) - rust-lang#74527 (Add myself to toolstate change notifications for rustfmt) - rust-lang#74534 (Only skip impls of foreign unstable traits) - rust-lang#74536 (fix documentation surrounding the `in` and `for` keywords) Failed merges: r? @ghost
This was referenced Jul 20, 2020
bors
added a commit
to rust-lang-ci/rust
that referenced
this pull request
Jul 22, 2020
Fix rust-src component. The rust-src component could not be installed by rustup because it included some symbolic links. rust-lang#74520 added the backtrace directory which included some symlinks. Since the rust-src component doesn't need most of the files in the `backtrace` submodule, this changes it to only include the minimum necessary. Tested with cargo's build-std that it can build from the resulting tarball. Fixes rust-lang#74577
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
libstd has a mandatory dependency on this code, ergo we need to include it in rust-src.
r? @oli-obk
Fixes #74506