Rollup of 9 pull requests #74543
Merged
Rollup of 9 pull requests #74543
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Co-authored-by: Joshua Nelson <joshua@yottadb.com>
We were setting these in both Builder::cargo and here, which ended up only setting the first of the two.
Previously unstable impls were skipped, which meant that any impl with an unstable method would get skipped.
Clear up wording regarding the iterator and usage of `break`. Co-authored-by: Josh Triplett <josh@joshtriplett.org>
Documentation for the false keyword Partial fix of rust-lang#34601. Short documentation for the false keyword mainly pointing to the `true` keyword.
…o-read, r=Mark-Simulacrum Improve Read::read_exact documentation Fixes rust-lang#72186. For now I simply added a link to `Read::read` and held off changing the text in `Read::read_exact`. I can do it if it is deemed necessary. @rustbot modify labels: C-enhancement, T-libs
… r=ollie27 Do not clobber RUSTDOCFLAGS We were setting these in both Builder::cargo and here, which ended up only setting the first of the two. Fixes rust-lang#74511
…hewjasper do not try fetching the ancestors of errored trait impls fixes rust-lang#74483 While building the specialization graph, we use `tcx.all_impls` which discards impls with incorrect self types, we do however call `trait_def.ancestors` with these impls which caused an ICE as they aren't part of the specialization graph.
…lacrum include backtrace folder in rust-src component libstd has a [mandatory dependency on this code](https://github.com/rust-lang/rust/pull/73441/files#diff-242481015141f373dcb178e93cffa850), ergo we need to include it in rust-src. r? @oli-obk Fixes rust-lang#74506
Improve documentation for `core::fmt` internals The public interface of `core::fmt` is well-documented, but the internals have very minimal documentation.
…aintainers, r=Mark-Simulacrum Add myself to toolstate change notifications for rustfmt I'd like to get the toolstate change notifications for rustfmt as well so that I'll know when things break. Have spoken with @topecongiro about this offline already.
…r=Manishearth Only skip impls of foreign unstable traits Previously unstable impls were skipped, which meant that any impl with an unstable method would get skipped. Fixes rust-lang#74531.
fix documentation surrounding the `in` and `for` keywords Addresses rust-lang#74529 The `in` keyword incorrectly referenced the `Iterator` trait. This reference was changed to `IntoIterator` without changing the underlying link. Additionally, the `IntoIterator` trait was referenced towards the end of the documentation for `for`. An additional reference was added earlier and broadened the existing documentation from any iterator to anything that can be turned into an iterator.
|
📌 Commit 27947b6 has been approved by |
bors
added
the
S-waiting-on-bors
|
@bors treeclosed=6 p=6 will try and watch this |
|
☀️ Test successful - checks-actions, checks-azure |
|
@nnethercote I expect #74514 because it documents private items. So not actually a perf loss, just doing more work. It could also be #74534 though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Successful merges:
core::fmtinternals #74523 (Improve documentation forcore::fmtinternals)inandforkeywords #74536 (fix documentation surrounding theinandforkeywords)Failed merges:
r? @ghost